All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH 1/1] s390: correct __bootdata / __bootdata_preserved macros
Date: Tue, 27 Oct 2020 00:57:00 +0100	[thread overview]
Message-ID: <20201026235700.3dga6r5obn7z5cxv@lion.mk-sys.cz> (raw)
In-Reply-To: <patch-1.thread-96dc81.git-96dc8112cea9.your-ad-here.call-01603716370-ext-5478@work.hours>

[-- Attachment #1: Type: text/plain, Size: 2519 bytes --]

On Mon, Oct 26, 2020 at 01:49:08PM +0100, Vasily Gorbik wrote:
> Currently s390 build is broken.
> 
>   SECTCMP .boot.data
> error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
> make[2]: *** [arch/s390/boot/section_cmp.boot.data] Error 1
>   SECTCMP .boot.preserved.data
> error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
> make[2]: *** [arch/s390/boot/section_cmp.boot.preserved.data] Error 1
> make[1]: *** [bzImage] Error 2
> 
> Commit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)
> to __section("foo")") converted all __section(foo) to __section("foo").
> This is wrong for __bootdata / __bootdata_preserved macros which want
> variable names to be a part of intermediate section names .boot.data.<var
> name> and .boot.preserved.data.<var name>. Those sections are later
> sorted by alignment + name and merged together into final .boot.data
> / .boot.preserved.data sections. Those sections must be identical in
> the decompressor and the decompressed kernel (that is checked during
> the build).
> 
> Fixes: 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")")
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

Tested-by: Michal Kubecek <mkubecek@suse.cz>

Thank you,
Michal

> ---
>  arch/s390/include/asm/sections.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/include/asm/sections.h b/arch/s390/include/asm/sections.h
> index a996d3990a02..0c2151451ba5 100644
> --- a/arch/s390/include/asm/sections.h
> +++ b/arch/s390/include/asm/sections.h
> @@ -26,14 +26,14 @@ static inline int arch_is_kernel_initmem_freed(unsigned long addr)
>   * final .boot.data section, which should be identical in the decompressor and
>   * the decompressed kernel (that is checked during the build).
>   */
> -#define __bootdata(var) __section(".boot.data.var") var
> +#define __bootdata(var) __section(".boot.data." #var) var
>  
>  /*
>   * .boot.preserved.data is similar to .boot.data, but it is not part of the
>   * .init section and thus will be preserved for later use in the decompressed
>   * kernel.
>   */
> -#define __bootdata_preserved(var) __section(".boot.preserved.data.var") var
> +#define __bootdata_preserved(var) __section(".boot.preserved.data." #var) var
>  
>  extern unsigned long __sdma, __edma;
>  extern unsigned long __stext_dma, __etext_dma;
> -- 
> 2.25.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2020-10-26 23:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 10:48 [Regression] s390x build broken with 5.10-rc1 (bisected) Michal Kubecek
2020-10-26 12:49 ` Vasily Gorbik
2020-10-26 12:49   ` [PATCH 1/1] s390: correct __bootdata / __bootdata_preserved macros Vasily Gorbik
2020-10-26 13:31     ` Joe Perches
2020-10-26 13:31       ` Joe Perches
2020-10-26 23:57     ` Michal Kubecek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026235700.3dga6r5obn7z5cxv@lion.mk-sys.cz \
    --to=mkubecek@suse.cz \
    --cc=gor@linux.ibm.com \
    --cc=joe@perches.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.