From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9651C56201 for ; Tue, 27 Oct 2020 04:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89811216FD for ; Tue, 27 Oct 2020 04:15:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="MUoZsjxh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505377AbgJ0EPn (ORCPT ); Tue, 27 Oct 2020 00:15:43 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:14514 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2442776AbgJ0EPl (ORCPT ); Tue, 27 Oct 2020 00:15:41 -0400 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20201027041538epoutp02e438203bd262a2e2bb9591fc43ad1d3a~BvkM0Z0mM2845428454epoutp02S for ; Tue, 27 Oct 2020 04:15:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20201027041538epoutp02e438203bd262a2e2bb9591fc43ad1d3a~BvkM0Z0mM2845428454epoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1603772138; bh=QmsAGZ914pVlhHj0JHteeAL0P0zGoJ524XNBMQDKb8Y=; h=From:To:Cc:Subject:Date:References:From; b=MUoZsjxhxWwzlGSTuqbrbHxZspX8fATWzvDdidscqKYhCifl4DBp1EeBtZ7WI15mb nwK+xAQIOH7wfahUTnxXc2D7qKLjwTKYEDynVM/fHddXeMQOGemQEKdvY2HccoKu3U 6EM0b7PMGqtCnq4ijY3RCQ90mcWdLRIU5+jv5tw4= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20201027041537epcas1p30f7ea22517894f410c44df158889104d~BvkMZDT7r2989729897epcas1p3M; Tue, 27 Oct 2020 04:15:37 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.40.156]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4CKyzq3K73zMqYkl; Tue, 27 Oct 2020 04:15:35 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 49.FE.09918.7EE979F5; Tue, 27 Oct 2020 13:15:35 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44~BvkJwmHd61218612186epcas1p2r; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201027041534epsmtrp19af9fc5465560dd1a1a189dd624fbd57~BvkJvs7WX0073800738epsmtrp1X; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) X-AuditID: b6c32a36-713ff700000026be-34-5f979ee7ca32 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id EC.69.08745.6EE979F5; Tue, 27 Oct 2020 13:15:34 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.111.64]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201027041534epsmtip143f2b95ee50675314e32c1f7f2d92141~BvkJeuwhv2895528955epsmtip1f; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) From: Hoegeun Kwon To: maxime@cerno.tech, eric@anholt.net, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, dave.stevenson@raspberrypi.com, sungguk.na@samsung.com, hoegeun.kwon@samsung.com Subject: [PATCH 0/1] drm/vc4: drv: Add error handding for bind Date: Tue, 27 Oct 2020 13:14:41 +0900 Message-Id: <20201027041442.30352-1-hoegeun.kwon@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAJsWRmVeSWpSXmKPExsWy7bCmge7zedPjDRbeE7boPXeSyWJt71EW i//bJjJbvJ27mMVi/pFzrBZXvr5nszjQeJnR4v3yLjaLTY+vsVpc3jWHzWLi7Q3sFjN+/GO0 aN17hN1ix7yDjA58Hk3vj7F5zLp/ls3jzrnzbB57vy1g8di0qpPNY/u3B6we97uPM3lsXlLv 0Xr0F4tH35ZVjB6fN8kFcEdl22SkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl 5qbaKrn4BOi6ZeYAvaGkUJaYUwoUCkgsLlbSt7Mpyi8tSVXIyC8usVVKLUjJKbAs0CtOzC0u zUvXS87PtTI0MDAyBSpMyM74P/UeW8EmnoobN9+wNjAu5epi5OSQEDCRmPLtETuILSSwg1Fi 4muBLkYuIPsTo8TyFzeZIJzPjBLH97xjh+noeHKcDSKxi1FixpH37HBVTw/MYAGpYhPQlfja c50JxBYRiJe41tvGClLELLCKSeLcjiVgRcICdhKdbw4A2RwcLAKqEu+fu4CEeQVsJTafXssG sU1eYvWGA8wgvRICUzkknk34wAyRcJF42X8WqkhY4tXxLVDnSQHF26DsYokrM1+xQDQ3MEr0 T5wNlTCW2L90MhPIYmYBTYn1u/QhwooSO3/PZQSxmQX4JN597WEFKZEQ4JXoaBOCKFGTeNZw gBXClpE41bucCcL2kFgy/RYrJBxjJW7cn8k6gVF2FsKCBYyMqxjFUguKc9NTiw0LjJBjaRMj OGlqme1gnPT2g94hRiYOxkOMEhzMSiK8c2SmxgvxpiRWVqUW5ccXleakFh9iNAWG10RmKdHk fGDaziuJNzQ1MjY2tjAxNDM1NFQS5/2j3REvJJCeWJKanZpakFoE08fEwSnVwOT9qM/ibln/ y7uXltu5TZ3SyRXjLvLehkVI+cvaHFe5y53zps1Wu+W/mud51147papelXXzzB7ZfVs7Kza7 rO/1j7qnlbpP/d4x2z34vemZyqWb23nnRVv32E3eK7qwdeFbWRlOr8svnP6JmnNLb7B+yZIQ Njlrxu7fjVPTpAxFpTYFLU/eLqnJG3tGZuuaU5f3WNjJdO1v1rPv0b077dQ6xU9VTUFby+2d dH6qekVd4/+pnfPRx0vIZmHNZzuTc34M/2MKHJYzRa/aMPFlzi4JadZ3E6cekDqdt/ixmHSW VI7nfMGFJU+yc7mreialyEx+y127L3FPS+CU+IkKL8JD2NmmJT0TYer0UQwOU2Ipzkg01GIu Kk4EAAH6wbQjBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsWy7bCSnO6zedPjDU4/1rXoPXeSyWJt71EW i//bJjJbvJ27mMVi/pFzrBZXvr5nszjQeJnR4v3yLjaLTY+vsVpc3jWHzWLi7Q3sFjN+/GO0 aN17hN1ix7yDjA58Hk3vj7F5zLp/ls3jzrnzbB57vy1g8di0qpPNY/u3B6we97uPM3lsXlLv 0Xr0F4tH35ZVjB6fN8kFcEdx2aSk5mSWpRbp2yVwZfyfeo+tYBNPxY2bb1gbGJdydTFyckgI mEh0PDnO1sXIxSEksINRYs2sfUwQCRmJVf1bWLsYOYBsYYnDh4shaj4ySjycsIcZpIZNQFfi a891sHoRgVSJtvdHWECKmAU2MUn0nexhBEkIC9hJdL45wAIyiEVAVeL9cxeQMK+ArcTm02vZ IHbJS6zecIB5AiPPAkaGVYySqQXFuem5xYYFRnmp5XrFibnFpXnpesn5uZsYwUGspbWDcc+q D3qHGJk4GA8xSnAwK4nwzpGZGi/Em5JYWZValB9fVJqTWnyIUZqDRUmc9+ushXFCAumJJanZ qakFqUUwWSYOTqkGpoiuhujHNQGfM49liP9dxeDgzzmZV3rDXbM53Mqr9j6KnRtc/l7sOcOt vbmr/zs8Slhq/nHd92lTFq9ev1XSuaQq8kf4tmdFK/8bHxG1P7p9y9Oa2YsNtih2nW/L2j1v pVh16vSGA5f+Wzl/yZdffvuht0nR9+XNc71Weh5waPnrMfea7Up2Rpkwrz/tPmUP5Y6tOa3y dwHHuoX7rtert/QrFW8XEVtzs2TxPu3HT2ex6MjPe+Ps2Fp7o6ed5bMq871PZmqOT/da6937 wjFrSwkrz4S/W8+uu84QdvPa0rmtm1OFpuz3EPjCUXrhUYDFX/FF0294rOp88/SWrnXFY7Uu o0fz5gm7HBZ+sC9TiGuuEktxRqKhFnNRcSIAkUSQbtECAAA= X-CMS-MailID: 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44 References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello all, There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side as shown below. Add error handding for drm_mode_config. unreferenced object 0xffffff80f5a7a6c8 (size 576): comm "swapper/0", pid 1, jiffies 4294892559 (age 181.448s) hex dump (first 32 bytes): 00 00 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ f8 f1 0e f5 80 ff ff ff e0 a6 a7 f5 80 ff ff ff ................ backtrace: [<00000000fd3656dc>] kmem_cache_alloc+0x1a4/0x328 [<000000009dfa1aab>] radix_tree_node_alloc.constprop.19+0x50/0x108 [<00000000a9f1657b>] idr_get_free+0x21c/0x2b8 [<0000000099f2eea6>] idr_alloc_u32+0x68/0xf0 [<00000000525beb52>] idr_alloc+0x44/0x80 [<00000000dbfbaa4b>] __drm_mode_object_add+0x64/0xc0 [<000000002c24dfc8>] drm_mode_object_add+0x3c/0x50 [<00000000f45b491f>] drm_property_create+0xf0/0x1a0 [<000000002e1a296b>] drm_connector_create_standard_properties+0x30/0x130 [<000000007c53e4bd>] drm_mode_config_init+0x138/0x498 [<00000000cc1b0767>] vc4_drm_bind+0x168/0x1f8 [<0000000041d69f98>] try_to_bring_up_master+0x180/0x1e8 [<00000000d1e1caae>] component_master_add_with_match+0xbc/0x108 [<0000000085cea46d>] vc4_platform_drm_probe+0xd8/0x108 [<00000000eacabf20>] platform_drv_probe+0x58/0xa8 [<000000003822d094>] really_probe+0x10c/0x350 Best regards, Hoegeun Hoegeun Kwon (1): drm/vc4: drv: Add error handding for bind drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28DDC4363A for ; Tue, 27 Oct 2020 04:17:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8497821D41 for ; Tue, 27 Oct 2020 04:17:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iR9W+s87"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="MUoZsjxh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8497821D41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:Message-Id:Date:Subject:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=w0Bdvw8C3s1n+PoHLHSY+bJoAAGc67mUKcuaOoZvycw=; b=iR9W+s878i2lYrd033x5y2k83M 9sLzzIQ4Rs8LUYaP06PDv1OVYOMq5TxQ5YupG0WoQAXIfn236ly+50z1fCZ7MGQkWIqFZF97kAimo ke2AELH43qvKHo44P3SEufwp+EA1zKlo4bBrzSoQ7Pwpgm25Px9Cgm3tPvSOzQnAHc/lb75BLYKSE aszvWJ5WwZelRCmMoxYiaMzGkgETFR2J/WAcYJpsMemHdK1cIPr/8KORPq/TFW5LpXk9+wYmWacKq KpzKkxc9bgGmCgceXd+AelYEVXAL6LNVtRuomGlQD4uJu04GxZjz/qc4LtrbiuCkIGEGyWjV7oNTk 7oahtA5Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXGOf-00035b-9a; Tue, 27 Oct 2020 04:15:45 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXGOb-00033t-KH for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 04:15:43 +0000 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20201027041538epoutp0451bc41d834ba64c0edb54b181b286566~BvkM0Nhqc0041200412epoutp04O for ; Tue, 27 Oct 2020 04:15:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20201027041538epoutp0451bc41d834ba64c0edb54b181b286566~BvkM0Nhqc0041200412epoutp04O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1603772138; bh=QmsAGZ914pVlhHj0JHteeAL0P0zGoJ524XNBMQDKb8Y=; h=From:To:Cc:Subject:Date:References:From; b=MUoZsjxhxWwzlGSTuqbrbHxZspX8fATWzvDdidscqKYhCifl4DBp1EeBtZ7WI15mb nwK+xAQIOH7wfahUTnxXc2D7qKLjwTKYEDynVM/fHddXeMQOGemQEKdvY2HccoKu3U 6EM0b7PMGqtCnq4ijY3RCQ90mcWdLRIU5+jv5tw4= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20201027041537epcas1p30f7ea22517894f410c44df158889104d~BvkMZDT7r2989729897epcas1p3M; Tue, 27 Oct 2020 04:15:37 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.40.156]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4CKyzq3K73zMqYkl; Tue, 27 Oct 2020 04:15:35 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 49.FE.09918.7EE979F5; Tue, 27 Oct 2020 13:15:35 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44~BvkJwmHd61218612186epcas1p2r; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201027041534epsmtrp19af9fc5465560dd1a1a189dd624fbd57~BvkJvs7WX0073800738epsmtrp1X; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) X-AuditID: b6c32a36-713ff700000026be-34-5f979ee7ca32 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id EC.69.08745.6EE979F5; Tue, 27 Oct 2020 13:15:34 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.111.64]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201027041534epsmtip143f2b95ee50675314e32c1f7f2d92141~BvkJeuwhv2895528955epsmtip1f; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) From: Hoegeun Kwon To: maxime@cerno.tech, eric@anholt.net, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org Subject: [PATCH 0/1] drm/vc4: drv: Add error handding for bind Date: Tue, 27 Oct 2020 13:14:41 +0900 Message-Id: <20201027041442.30352-1-hoegeun.kwon@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAJsWRmVeSWpSXmKPExsWy7bCmge7zedPjDRbeE7boPXeSyWJt71EW i//bJjJbvJ27mMVi/pFzrBZXvr5nszjQeJnR4v3yLjaLTY+vsVpc3jWHzWLi7Q3sFjN+/GO0 aN17hN1ix7yDjA58Hk3vj7F5zLp/ls3jzrnzbB57vy1g8di0qpPNY/u3B6we97uPM3lsXlLv 0Xr0F4tH35ZVjB6fN8kFcEdl22SkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl 5qbaKrn4BOi6ZeYAvaGkUJaYUwoUCkgsLlbSt7Mpyi8tSVXIyC8usVVKLUjJKbAs0CtOzC0u zUvXS87PtTI0MDAyBSpMyM74P/UeW8EmnoobN9+wNjAu5epi5OSQEDCRmPLtETuILSSwg1Fi 4muBLkYuIPsTo8TyFzeZIJzPjBLH97xjh+noeHKcDSKxi1FixpH37HBVTw/MYAGpYhPQlfja c50JxBYRiJe41tvGClLELLCKSeLcjiVgRcICdhKdbw4A2RwcLAKqEu+fu4CEeQVsJTafXssG sU1eYvWGA8wgvRICUzkknk34wAyRcJF42X8WqkhY4tXxLVDnSQHF26DsYokrM1+xQDQ3MEr0 T5wNlTCW2L90MhPIYmYBTYn1u/QhwooSO3/PZQSxmQX4JN597WEFKZEQ4JXoaBOCKFGTeNZw gBXClpE41bucCcL2kFgy/RYrJBxjJW7cn8k6gVF2FsKCBYyMqxjFUguKc9NTiw0LjJBjaRMj OGlqme1gnPT2g94hRiYOxkOMEhzMSiK8c2SmxgvxpiRWVqUW5ccXleakFh9iNAWG10RmKdHk fGDaziuJNzQ1MjY2tjAxNDM1NFQS5/2j3REvJJCeWJKanZpakFoE08fEwSnVwOT9qM/ibln/ y7uXltu5TZ3SyRXjLvLehkVI+cvaHFe5y53zps1Wu+W/mud51147papelXXzzB7ZfVs7Kza7 rO/1j7qnlbpP/d4x2z34vemZyqWb23nnRVv32E3eK7qwdeFbWRlOr8svnP6JmnNLb7B+yZIQ Njlrxu7fjVPTpAxFpTYFLU/eLqnJG3tGZuuaU5f3WNjJdO1v1rPv0b077dQ6xU9VTUFby+2d dH6qekVd4/+pnfPRx0vIZmHNZzuTc34M/2MKHJYzRa/aMPFlzi4JadZ3E6cekDqdt/ixmHSW VI7nfMGFJU+yc7mreialyEx+y127L3FPS+CU+IkKL8JD2NmmJT0TYer0UQwOU2Ipzkg01GIu Kk4EAAH6wbQjBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsWy7bCSnO6zedPjDU4/1rXoPXeSyWJt71EW i//bJjJbvJ27mMVi/pFzrBZXvr5nszjQeJnR4v3yLjaLTY+vsVpc3jWHzWLi7Q3sFjN+/GO0 aN17hN1ix7yDjA58Hk3vj7F5zLp/ls3jzrnzbB57vy1g8di0qpPNY/u3B6we97uPM3lsXlLv 0Xr0F4tH35ZVjB6fN8kFcEdx2aSk5mSWpRbp2yVwZfyfeo+tYBNPxY2bb1gbGJdydTFyckgI mEh0PDnO1sXIxSEksINRYs2sfUwQCRmJVf1bWLsYOYBsYYnDh4shaj4ySjycsIcZpIZNQFfi a891sHoRgVSJtvdHWECKmAU2MUn0nexhBEkIC9hJdL45wAIyiEVAVeL9cxeQMK+ArcTm02vZ IHbJS6zecIB5AiPPAkaGVYySqQXFuem5xYYFRnmp5XrFibnFpXnpesn5uZsYwUGspbWDcc+q D3qHGJk4GA8xSnAwK4nwzpGZGi/Em5JYWZValB9fVJqTWnyIUZqDRUmc9+ushXFCAumJJanZ qakFqUUwWSYOTqkGpoiuhujHNQGfM49liP9dxeDgzzmZV3rDXbM53Mqr9j6KnRtc/l7sOcOt vbmr/zs8Slhq/nHd92lTFq9ev1XSuaQq8kf4tmdFK/8bHxG1P7p9y9Oa2YsNtih2nW/L2j1v pVh16vSGA5f+Wzl/yZdffvuht0nR9+XNc71Weh5waPnrMfea7Up2Rpkwrz/tPmUP5Y6tOa3y dwHHuoX7rtert/QrFW8XEVtzs2TxPu3HT2ex6MjPe+Ps2Fp7o6ed5bMq871PZmqOT/da6937 wjFrSwkrz4S/W8+uu84QdvPa0rmtm1OFpuz3EPjCUXrhUYDFX/FF0294rOp88/SWrnXFY7Uu o0fz5gm7HBZ+sC9TiGuuEktxRqKhFnNRcSIAkUSQbtECAAA= X-CMS-MailID: 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_001542_157015_11CF9413 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, sungguk.na@samsung.com, dave.stevenson@raspberrypi.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, hoegeun.kwon@samsung.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello all, There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side as shown below. Add error handding for drm_mode_config. unreferenced object 0xffffff80f5a7a6c8 (size 576): comm "swapper/0", pid 1, jiffies 4294892559 (age 181.448s) hex dump (first 32 bytes): 00 00 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ f8 f1 0e f5 80 ff ff ff e0 a6 a7 f5 80 ff ff ff ................ backtrace: [<00000000fd3656dc>] kmem_cache_alloc+0x1a4/0x328 [<000000009dfa1aab>] radix_tree_node_alloc.constprop.19+0x50/0x108 [<00000000a9f1657b>] idr_get_free+0x21c/0x2b8 [<0000000099f2eea6>] idr_alloc_u32+0x68/0xf0 [<00000000525beb52>] idr_alloc+0x44/0x80 [<00000000dbfbaa4b>] __drm_mode_object_add+0x64/0xc0 [<000000002c24dfc8>] drm_mode_object_add+0x3c/0x50 [<00000000f45b491f>] drm_property_create+0xf0/0x1a0 [<000000002e1a296b>] drm_connector_create_standard_properties+0x30/0x130 [<000000007c53e4bd>] drm_mode_config_init+0x138/0x498 [<00000000cc1b0767>] vc4_drm_bind+0x168/0x1f8 [<0000000041d69f98>] try_to_bring_up_master+0x180/0x1e8 [<00000000d1e1caae>] component_master_add_with_match+0xbc/0x108 [<0000000085cea46d>] vc4_platform_drm_probe+0xd8/0x108 [<00000000eacabf20>] platform_drv_probe+0x58/0xa8 [<000000003822d094>] really_probe+0x10c/0x350 Best regards, Hoegeun Hoegeun Kwon (1): drm/vc4: drv: Add error handding for bind drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E50F3C4363A for ; Tue, 27 Oct 2020 04:15:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C0D921707 for ; Tue, 27 Oct 2020 04:15:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="MUoZsjxh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C0D921707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7633B6E10A; Tue, 27 Oct 2020 04:15:44 +0000 (UTC) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3038F6E10A for ; Tue, 27 Oct 2020 04:15:40 +0000 (UTC) Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20201027041538epoutp01595e51c7980c9b40498fb457c4b9a34c~BvkMz6wAb2004020040epoutp01v for ; Tue, 27 Oct 2020 04:15:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20201027041538epoutp01595e51c7980c9b40498fb457c4b9a34c~BvkMz6wAb2004020040epoutp01v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1603772138; bh=QmsAGZ914pVlhHj0JHteeAL0P0zGoJ524XNBMQDKb8Y=; h=From:To:Cc:Subject:Date:References:From; b=MUoZsjxhxWwzlGSTuqbrbHxZspX8fATWzvDdidscqKYhCifl4DBp1EeBtZ7WI15mb nwK+xAQIOH7wfahUTnxXc2D7qKLjwTKYEDynVM/fHddXeMQOGemQEKdvY2HccoKu3U 6EM0b7PMGqtCnq4ijY3RCQ90mcWdLRIU5+jv5tw4= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20201027041537epcas1p30f7ea22517894f410c44df158889104d~BvkMZDT7r2989729897epcas1p3M; Tue, 27 Oct 2020 04:15:37 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.40.156]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4CKyzq3K73zMqYkl; Tue, 27 Oct 2020 04:15:35 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 49.FE.09918.7EE979F5; Tue, 27 Oct 2020 13:15:35 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44~BvkJwmHd61218612186epcas1p2r; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201027041534epsmtrp19af9fc5465560dd1a1a189dd624fbd57~BvkJvs7WX0073800738epsmtrp1X; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) X-AuditID: b6c32a36-713ff700000026be-34-5f979ee7ca32 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id EC.69.08745.6EE979F5; Tue, 27 Oct 2020 13:15:34 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.111.64]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201027041534epsmtip143f2b95ee50675314e32c1f7f2d92141~BvkJeuwhv2895528955epsmtip1f; Tue, 27 Oct 2020 04:15:34 +0000 (GMT) From: Hoegeun Kwon To: maxime@cerno.tech, eric@anholt.net, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org Subject: [PATCH 0/1] drm/vc4: drv: Add error handding for bind Date: Tue, 27 Oct 2020 13:14:41 +0900 Message-Id: <20201027041442.30352-1-hoegeun.kwon@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAJsWRmVeSWpSXmKPExsWy7bCmge7zedPjDRbeE7boPXeSyWJt71EW i//bJjJbvJ27mMVi/pFzrBZXvr5nszjQeJnR4v3yLjaLTY+vsVpc3jWHzWLi7Q3sFjN+/GO0 aN17hN1ix7yDjA58Hk3vj7F5zLp/ls3jzrnzbB57vy1g8di0qpPNY/u3B6we97uPM3lsXlLv 0Xr0F4tH35ZVjB6fN8kFcEdl22SkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl 5qbaKrn4BOi6ZeYAvaGkUJaYUwoUCkgsLlbSt7Mpyi8tSVXIyC8usVVKLUjJKbAs0CtOzC0u zUvXS87PtTI0MDAyBSpMyM74P/UeW8EmnoobN9+wNjAu5epi5OSQEDCRmPLtETuILSSwg1Fi 4muBLkYuIPsTo8TyFzeZIJzPjBLH97xjh+noeHKcDSKxi1FixpH37HBVTw/MYAGpYhPQlfja c50JxBYRiJe41tvGClLELLCKSeLcjiVgRcICdhKdbw4A2RwcLAKqEu+fu4CEeQVsJTafXssG sU1eYvWGA8wgvRICUzkknk34wAyRcJF42X8WqkhY4tXxLVDnSQHF26DsYokrM1+xQDQ3MEr0 T5wNlTCW2L90MhPIYmYBTYn1u/QhwooSO3/PZQSxmQX4JN597WEFKZEQ4JXoaBOCKFGTeNZw gBXClpE41bucCcL2kFgy/RYrJBxjJW7cn8k6gVF2FsKCBYyMqxjFUguKc9NTiw0LjJBjaRMj OGlqme1gnPT2g94hRiYOxkOMEhzMSiK8c2SmxgvxpiRWVqUW5ccXleakFh9iNAWG10RmKdHk fGDaziuJNzQ1MjY2tjAxNDM1NFQS5/2j3REvJJCeWJKanZpakFoE08fEwSnVwOT9qM/ibln/ y7uXltu5TZ3SyRXjLvLehkVI+cvaHFe5y53zps1Wu+W/mud51147papelXXzzB7ZfVs7Kza7 rO/1j7qnlbpP/d4x2z34vemZyqWb23nnRVv32E3eK7qwdeFbWRlOr8svnP6JmnNLb7B+yZIQ Njlrxu7fjVPTpAxFpTYFLU/eLqnJG3tGZuuaU5f3WNjJdO1v1rPv0b077dQ6xU9VTUFby+2d dH6qekVd4/+pnfPRx0vIZmHNZzuTc34M/2MKHJYzRa/aMPFlzi4JadZ3E6cekDqdt/ixmHSW VI7nfMGFJU+yc7mreialyEx+y127L3FPS+CU+IkKL8JD2NmmJT0TYer0UQwOU2Ipzkg01GIu Kk4EAAH6wbQjBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsWy7bCSnO6zedPjDU4/1rXoPXeSyWJt71EW i//bJjJbvJ27mMVi/pFzrBZXvr5nszjQeJnR4v3yLjaLTY+vsVpc3jWHzWLi7Q3sFjN+/GO0 aN17hN1ix7yDjA58Hk3vj7F5zLp/ls3jzrnzbB57vy1g8di0qpPNY/u3B6we97uPM3lsXlLv 0Xr0F4tH35ZVjB6fN8kFcEdx2aSk5mSWpRbp2yVwZfyfeo+tYBNPxY2bb1gbGJdydTFyckgI mEh0PDnO1sXIxSEksINRYs2sfUwQCRmJVf1bWLsYOYBsYYnDh4shaj4ySjycsIcZpIZNQFfi a891sHoRgVSJtvdHWECKmAU2MUn0nexhBEkIC9hJdL45wAIyiEVAVeL9cxeQMK+ArcTm02vZ IHbJS6zecIB5AiPPAkaGVYySqQXFuem5xYYFRnmp5XrFibnFpXnpesn5uZsYwUGspbWDcc+q D3qHGJk4GA8xSnAwK4nwzpGZGi/Em5JYWZValB9fVJqTWnyIUZqDRUmc9+ushXFCAumJJanZ qakFqUUwWSYOTqkGpoiuhujHNQGfM49liP9dxeDgzzmZV3rDXbM53Mqr9j6KnRtc/l7sOcOt vbmr/zs8Slhq/nHd92lTFq9ev1XSuaQq8kf4tmdFK/8bHxG1P7p9y9Oa2YsNtih2nW/L2j1v pVh16vSGA5f+Wzl/yZdffvuht0nR9+XNc71Weh5waPnrMfea7Up2Rpkwrz/tPmUP5Y6tOa3y dwHHuoX7rtert/QrFW8XEVtzs2TxPu3HT2ex6MjPe+Ps2Fp7o6ed5bMq871PZmqOT/da6937 wjFrSwkrz4S/W8+uu84QdvPa0rmtm1OFpuz3EPjCUXrhUYDFX/FF0294rOp88/SWrnXFY7Uu o0fz5gm7HBZ+sC9TiGuuEktxRqKhFnNRcSIAkUSQbtECAAA= X-CMS-MailID: 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44 References: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, sungguk.na@samsung.com, dave.stevenson@raspberrypi.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, hoegeun.kwon@samsung.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello all, There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side as shown below. Add error handding for drm_mode_config. unreferenced object 0xffffff80f5a7a6c8 (size 576): comm "swapper/0", pid 1, jiffies 4294892559 (age 181.448s) hex dump (first 32 bytes): 00 00 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ f8 f1 0e f5 80 ff ff ff e0 a6 a7 f5 80 ff ff ff ................ backtrace: [<00000000fd3656dc>] kmem_cache_alloc+0x1a4/0x328 [<000000009dfa1aab>] radix_tree_node_alloc.constprop.19+0x50/0x108 [<00000000a9f1657b>] idr_get_free+0x21c/0x2b8 [<0000000099f2eea6>] idr_alloc_u32+0x68/0xf0 [<00000000525beb52>] idr_alloc+0x44/0x80 [<00000000dbfbaa4b>] __drm_mode_object_add+0x64/0xc0 [<000000002c24dfc8>] drm_mode_object_add+0x3c/0x50 [<00000000f45b491f>] drm_property_create+0xf0/0x1a0 [<000000002e1a296b>] drm_connector_create_standard_properties+0x30/0x130 [<000000007c53e4bd>] drm_mode_config_init+0x138/0x498 [<00000000cc1b0767>] vc4_drm_bind+0x168/0x1f8 [<0000000041d69f98>] try_to_bring_up_master+0x180/0x1e8 [<00000000d1e1caae>] component_master_add_with_match+0xbc/0x108 [<0000000085cea46d>] vc4_platform_drm_probe+0xd8/0x108 [<00000000eacabf20>] platform_drv_probe+0x58/0xa8 [<000000003822d094>] really_probe+0x10c/0x350 Best regards, Hoegeun Hoegeun Kwon (1): drm/vc4: drv: Add error handding for bind drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel