From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D852C55179 for ; Tue, 27 Oct 2020 08:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DA812224E for ; Tue, 27 Oct 2020 08:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603788867; bh=CsoM0AEgwvLsKHr0ZMDCjtTRgkzvE3qeyp+nM1UlaW8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uI94BG01McFvW5AVRiXaNT7+UVWc5uVUu9vBvJWap5zn7Le3tF1j2LNYn8fkgc+gG YW9LrngmBbOmofMEOXMgDQQEOsMrFhliHhEhKwysSL2r5V9X34vrU5lBwV/wtCCcds ubTvD04XCHg8D4kxxItO/12LbLMXDujzBRjiODOI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895137AbgJ0IyX (ORCPT ); Tue, 27 Oct 2020 04:54:23 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:39919 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895135AbgJ0IyX (ORCPT ); Tue, 27 Oct 2020 04:54:23 -0400 Received: by mail-ej1-f67.google.com with SMTP id bn26so1068738ejb.6; Tue, 27 Oct 2020 01:54:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pl76InKLYF2UwW9waAthO63zpy2TGEsyyfIicHpInyw=; b=kieuVls0MHnoY8T0ezMslg13UBPaOt5M1Jk1huNNVh5v1BfM8JHT7UabQX8UFvo/4m hAbDT3ky7mV/dKYx3a7l2ttWH2LlJe5ZDXh6BR7XhxzwyHwmbv28ZhFYvvAEwZVfRFKC CcVlc9O4w88D/O1LDMy5Qul/E8ecJtuxNxHtlMiWpmLNsy0290qz64N5jaebap3q/HUR eZZvxw6WkyJALTPJR3FImcmQxjGhQVEs5F94kmCRxb1L6AlUrAr7H/5I+aeGUocgEFqX wHN/5wFVgTusCA+TeuYNZFTqOEiRW//DmprNSt7nPMxCgrN7fcnzmCecUuN9EGoKWKZr chsw== X-Gm-Message-State: AOAM531ig2VoO4phRloNS5AKclnBodDOXXONqv/igzRU2qoqTmoR+Laj XAha6rU8hq63TRVYzDJYas8= X-Google-Smtp-Source: ABdhPJzmpTJ+ZcG8BezO09PSRSuSnCiQ/tWevDipQfx8F299/Gs4qAXSPmuMp8sWXOngl8h7jPxqAw== X-Received: by 2002:a17:906:23f2:: with SMTP id j18mr1312596ejg.526.1603788861157; Tue, 27 Oct 2020 01:54:21 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id p9sm574643ejo.75.2020.10.27.01.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 01:54:20 -0700 (PDT) Date: Tue, 27 Oct 2020 09:54:17 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property Message-ID: <20201027085417.GD4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-5-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: > Tegra20 External Memory Controller talks to DRAM chips and it needs to be > reprogrammed when memory frequency changes. Tegra Memory Controller sits > behind EMC and these controllers are tightly coupled. This patch adds the > new phandle property which allows to properly express connection of EMC > and MC hardware in a device-tree, it also put the Tegra20 EMC binding on > par with Tegra30+ EMC bindings, which is handy to have. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > index 567cffd37f3f..1b0d4417aad8 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > @@ -12,6 +12,7 @@ Properties: > irrespective of ram-code configuration. > - interrupts : Should contain EMC General interrupt. > - clocks : Should contain EMC clock. > +- nvidia,memory-controller : Phandle of the Memory Controller node. It looks like you adding a required property which is an ABI break. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F226AC56201 for ; Tue, 27 Oct 2020 08:54:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A532B22282 for ; Tue, 27 Oct 2020 08:54:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A532B22282 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DFE86EB25; Tue, 27 Oct 2020 08:54:24 +0000 (UTC) Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1F956EB25 for ; Tue, 27 Oct 2020 08:54:22 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id d6so1035759ejb.11 for ; Tue, 27 Oct 2020 01:54:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pl76InKLYF2UwW9waAthO63zpy2TGEsyyfIicHpInyw=; b=RMmxBnOT61RQ4KmoS5z+r6tv0k1mD2LOsgvHcF5w2gFe1vwuGa6YeNFptNWpcXIIGW TEO7fybyF+YrLEqlvf4VFTfkVymRGTMNphbcy+KkyWSURjqWLu3C+N50u12NURKS5cFm ukZ+p6EhfR0N1GM2KBg5KeNpp29uWenUo54/kDbCApVd+1a7wfOQBK2wvnvjPNCNofY7 r6oCJuZEMP9IYbx5fpl+7eMtqAIQGQX0O+HdGYEDzpGPxn94s1tW3R+b4gcq2ad6Poqb I37vp4vW9PO1m8+Ovr3phcfAiBdZEjTMPQfdnMwxf/5e9GRzq5L7YDe7lx1zK3EJXy3o hEkA== X-Gm-Message-State: AOAM530/DErFjf2FQav8zEZjveM2qr8ee59eioBMtNjfwofqPmNWNj01 s8Ebk0XikY3VtMxzxKRMIKU= X-Google-Smtp-Source: ABdhPJzmpTJ+ZcG8BezO09PSRSuSnCiQ/tWevDipQfx8F299/Gs4qAXSPmuMp8sWXOngl8h7jPxqAw== X-Received: by 2002:a17:906:23f2:: with SMTP id j18mr1312596ejg.526.1603788861157; Tue, 27 Oct 2020 01:54:21 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id p9sm574643ejo.75.2020.10.27.01.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 01:54:20 -0700 (PDT) Date: Tue, 27 Oct 2020 09:54:17 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property Message-ID: <20201027085417.GD4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-5-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: > Tegra20 External Memory Controller talks to DRAM chips and it needs to be > reprogrammed when memory frequency changes. Tegra Memory Controller sits > behind EMC and these controllers are tightly coupled. This patch adds the > new phandle property which allows to properly express connection of EMC > and MC hardware in a device-tree, it also put the Tegra20 EMC binding on > par with Tegra30+ EMC bindings, which is handy to have. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > index 567cffd37f3f..1b0d4417aad8 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > @@ -12,6 +12,7 @@ Properties: > irrespective of ram-code configuration. > - interrupts : Should contain EMC General interrupt. > - clocks : Should contain EMC clock. > +- nvidia,memory-controller : Phandle of the Memory Controller node. It looks like you adding a required property which is an ABI break. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel