From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFB4C388F9 for ; Tue, 27 Oct 2020 10:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B038322264 for ; Tue, 27 Oct 2020 10:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603794316; bh=8moFYmfRTlWKD1pyyKVLtqo6L0wLVrEIDAkiNHmxNE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2bpnijaVm4EWVPGS840sy7AAHGd5jUJn0K0RY//OBiocbJDywz6HCZ6NLHjJbuJ3U tj6DDBcEojeDK4yDcYA24AlDHnmU5QqQaNf37XWjIUV9cJl7yZv3fNhmrookHbz5dp YTb08mvrCLotbyHBAcJAFPSL7Hz9sMOg5ISlqE4g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2898004AbgJ0KZN (ORCPT ); Tue, 27 Oct 2020 06:25:13 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:36791 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437932AbgJ0KZM (ORCPT ); Tue, 27 Oct 2020 06:25:12 -0400 Received: by mail-ej1-f66.google.com with SMTP id w27so1456087ejb.3; Tue, 27 Oct 2020 03:25:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ylNf2aSrBKpAGk/XmG8j77J1836YfOHwLDEKrBDhhto=; b=NuKxOtcoZKhMi/J7Bot2LzRHZtsIY2tGA0BrI6LMNM65U4R1IqMebM9shwg8F5t9EO 9Ir1sOXB1QXLHxyPQlKLRBnKtyG9nawGJR+PadH6RE0AniM2hakKmfDW5N5jMY3kcviF mfOVQccNZaOdkw3rzqy7mFLXjCh0wLnb9LyVpnpjl7CaIgEcbJB2FjR3d1bgZuSUU17v rg+gknmK0bjcGc6gIuzW4Hkhc1Z0/KywBeMvzUmoyiWIGOPb+Tq221SehO3oXm/9opbL r/MLwO1418C2YTiM+JOkUcovvnDUmpWD41z1hXjtK0Mnmldwjk+I+3hbIgkJIVOO762w xO7Q== X-Gm-Message-State: AOAM530bW5sa6rcrzlz1oOICU00c9s/tYrX2p5utioi/S5B4XN/F3QcU dT+SFvplZSClrvm1RpX/yFs= X-Google-Smtp-Source: ABdhPJyTiWvQkB0SHAsJaXsSdNHED7COpFBG6lf+CNCt8imIyB1mFelDwWrl3AGCqa/XD9EaDgO3wg== X-Received: by 2002:a17:906:3bc7:: with SMTP id v7mr1586575ejf.245.1603794310498; Tue, 27 Oct 2020 03:25:10 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id yw17sm747674ejb.97.2020.10.27.03.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 03:25:09 -0700 (PDT) Date: Tue, 27 Oct 2020 11:25:06 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property Message-ID: <20201027102506.GB17089@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-14-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-14-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: > External memory controller is interconnected with memory controller and > with external memory. Document new interconnect property which turns > External Memory Controller into interconnect provider. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > index 278549f9e051..ac00832ceac1 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > @@ -29,6 +29,9 @@ properties: > items: > - const: emc > > + "#interconnect-cells": > + const: 0 > + > nvidia,memory-controller: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -327,6 +330,7 @@ required: > - clocks > - clock-names > - nvidia,memory-controller > + - "#interconnect-cells" Another required property, what about all existing users of this binding? > > additionalProperties: false > > @@ -345,6 +349,7 @@ examples: > > #iommu-cells = <1>; > #reset-cells = <1>; > + #interconnect-cells = <1>; You meant '0'? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE26C4363A for ; Tue, 27 Oct 2020 10:25:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02BB922264 for ; Tue, 27 Oct 2020 10:25:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02BB922264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 646B76EB63; Tue, 27 Oct 2020 10:25:13 +0000 (UTC) Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDA206EB63 for ; Tue, 27 Oct 2020 10:25:11 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id p9so1452105eji.4 for ; Tue, 27 Oct 2020 03:25:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ylNf2aSrBKpAGk/XmG8j77J1836YfOHwLDEKrBDhhto=; b=Rayd2+8OzbLQtbSKXxixk3xS92uid68VmFb651GFFOUwiNSdI6qKc4lic7reJEg9uJ LSdLCPpDFDgRlwccy5183vfQ4hlt0InOq1fQBbBeksuPiIvD5eMogxsG/TmsRduL0dwE MG2+Sg0Q9ytixauX21LJ2E2p/TTMmpxIL/vbN+E3AP8js8j6pq6xVdpFrnuZPwynrHDC ak7ldC2ZK+npBHsBV8CYq+rJv2hrm7c5frqBKKACegGRcub295EkeOMNLVyxWYg6wATm RHnVVgrA7dPTaXP4QZAp0ikkTxEgyrvEW5xmDJfNJ2ErF/mhw0Bf4HESggj4naA+SFrB P5Pg== X-Gm-Message-State: AOAM532b1NEMh7U+MoHZFyiVHg+y3nxqRy+5Tqk7SF1gcg4OK4BFbZGO x6Sbb0cBW3pwBvn9boIpXP8= X-Google-Smtp-Source: ABdhPJyTiWvQkB0SHAsJaXsSdNHED7COpFBG6lf+CNCt8imIyB1mFelDwWrl3AGCqa/XD9EaDgO3wg== X-Received: by 2002:a17:906:3bc7:: with SMTP id v7mr1586575ejf.245.1603794310498; Tue, 27 Oct 2020 03:25:10 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id yw17sm747674ejb.97.2020.10.27.03.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 03:25:09 -0700 (PDT) Date: Tue, 27 Oct 2020 11:25:06 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property Message-ID: <20201027102506.GB17089@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-14-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-14-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: > External memory controller is interconnected with memory controller and > with external memory. Document new interconnect property which turns > External Memory Controller into interconnect provider. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > index 278549f9e051..ac00832ceac1 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > @@ -29,6 +29,9 @@ properties: > items: > - const: emc > > + "#interconnect-cells": > + const: 0 > + > nvidia,memory-controller: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -327,6 +330,7 @@ required: > - clocks > - clock-names > - nvidia,memory-controller > + - "#interconnect-cells" Another required property, what about all existing users of this binding? > > additionalProperties: false > > @@ -345,6 +349,7 @@ examples: > > #iommu-cells = <1>; > #reset-cells = <1>; > + #interconnect-cells = <1>; You meant '0'? Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel