From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06834C2D0A3 for ; Thu, 29 Oct 2020 19:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B1732076D for ; Thu, 29 Oct 2020 19:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725747AbgJ2TAS (ORCPT ); Thu, 29 Oct 2020 15:00:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:38707 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgJ2TAR (ORCPT ); Thu, 29 Oct 2020 15:00:17 -0400 IronPort-SDR: feIWC+QJVWzVyyVVqblEl+4neV9J8as5JvRzpgs7RDSFR3vFKOE3byQ/uSWppJmCXNaK8JMDlS E6vi0a2pgG1w== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="186285521" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="186285521" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 12:00:16 -0700 IronPort-SDR: vYyOwMyWII2nnIDUIc08l8IliMLKBJ603xz01XJ4wF9ile+oI8Rrs6LcTcUNd/cTp7YqSaf8KP /Ykq/lp7Cqow== X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="525623700" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 12:00:13 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kYDAh-001S76-PX; Thu, 29 Oct 2020 21:01:15 +0200 Date: Tue, 27 Oct 2020 15:29:11 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Sumit Semwal , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org, Bartosz Golaszewski Subject: Re: [PATCH 4/8] pinctrl: use krealloc_array() Message-ID: <20201027132911.GX4077@smile.fi.intel.com> References: <20201027121725.24660-1-brgl@bgdev.pl> <20201027121725.24660-5-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027121725.24660-5-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Oct 27, 2020 at 01:17:21PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/pinctrl/pinctrl-utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-utils.c b/drivers/pinctrl/pinctrl-utils.c > index f2bcbf62c03d..93df0d4c0a24 100644 > --- a/drivers/pinctrl/pinctrl-utils.c > +++ b/drivers/pinctrl/pinctrl-utils.c > @@ -39,7 +39,7 @@ int pinctrl_utils_reserve_map(struct pinctrl_dev *pctldev, > if (old_num >= new_num) > return 0; > > - new_map = krealloc(*map, sizeof(*new_map) * new_num, GFP_KERNEL); > + new_map = krealloc_array(*map, new_num, sizeof(*new_map), GFP_KERNEL); > if (!new_map) { > dev_err(pctldev->dev, "krealloc(map) failed\n"); ...and here? > return -ENOMEM; > -- > 2.29.1 > -- With Best Regards, Andy Shevchenko