From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71FEC55179 for ; Tue, 27 Oct 2020 13:35:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68CC121D24 for ; Tue, 27 Oct 2020 13:35:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iNNryRd2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbgJ0Nfg (ORCPT ); Tue, 27 Oct 2020 09:35:36 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:46380 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbgJ0Nfg (ORCPT ); Tue, 27 Oct 2020 09:35:36 -0400 Received: by mail-ej1-f66.google.com with SMTP id t25so2218884ejd.13; Tue, 27 Oct 2020 06:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8mQg3nh3RaesRS2P5WKkQKj2n7Sdjc0/yYomgGjrqio=; b=iNNryRd2nlTyxGTMh11x7reba8pbjJ8oqfWUoqPdnRReHWdK6LUDGWM37tgyyDiv2N nmVRPh2dnjwsreFvaLadAUa4r0NXafbS0cJjVn0CEAGJx4eOdW2Em5ss8a12y8JZMB+4 /S/Yln/enOzx6L1kmudHZ1nv+NQ9o1lPA0rJg7590Wn4H6Qss8bLjEmxtM5fCCN7o9Wf sHUahJRhBp6VZkCtCdUFCawRCFuthVnlM3P4VIhf4F3UwSrkUf7OXKU35ikqReEa9EaX qKd2NASh2NmgCn+6hfZM55WiAUQ7wBFXG4WsqUWSa9XEE9JWgDuJLG4bQJJSkp7p7s2S JfOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8mQg3nh3RaesRS2P5WKkQKj2n7Sdjc0/yYomgGjrqio=; b=DR98hxxTxDEYd7wFPoqFfELoL2kOdlZeDdVd20p4ZKl2p1ybiUwFX0pO+aN7kqVAip XLbB/Im6FTZNxfqwbbAGRYgtMfKXs3u00N/K1XyTLEB8W0p9IwppR9FuBhAeTJdbbHUt gt+zSyTcMKIRFsBmPkoBm4EdVUyJ1u4Uo9VxwlnS1cNoO1ciA0y22haNVXA86U5168F/ WjOy0cFagMCLUx67L09luT/i7fUNa0pYvormWcINnlawI8gdhePE/8EhZoVW3+u2YvB6 dH9iulXpqCHrjui14euqCpWcHqbjrQm99YscVqj00/5E9LfLXNvN4xChgWW9MfwrzC6/ cQvw== X-Gm-Message-State: AOAM530OH7xtpqH+VDXHaVeQlS16qddENbqROKXI9VNWLzs9WOpa+nSR YaQTg5e9N17/DfBkgIRNdFg= X-Google-Smtp-Source: ABdhPJyOS2GplJQHwJKYItyPwxlHn7uJ1Z/j8baAH8JyKjiTKLXB69/Mh3ufO4PujfYg/8EqfgktPw== X-Received: by 2002:a17:906:c095:: with SMTP id f21mr2593939ejz.108.1603805733846; Tue, 27 Oct 2020 06:35:33 -0700 (PDT) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id 6sm1054545ejv.49.2020.10.27.06.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 06:35:32 -0700 (PDT) Date: Tue, 27 Oct 2020 14:35:31 +0100 From: Thierry Reding To: Dmitry Osipenko Cc: Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 28/52] memory: tegra: Add and use devm_tegra_get_memory_controller() Message-ID: <20201027133531.GI1822510@ulmo> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-29-digetx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oxV4ZoPwBLqAyY+a" Content-Disposition: inline In-Reply-To: <20201025221735.3062-29-digetx@gmail.com> User-Agent: Mutt/1.14.7 (2020-08-29) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org --oxV4ZoPwBLqAyY+a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 26, 2020 at 01:17:11AM +0300, Dmitry Osipenko wrote: > Multiple Tegra drivers need to retrieve Memory Controller and there is > duplication of the retrieval code among the drivers. This patch removes > the duplication and fixes put_device() which was missed in the duplicated > code. >=20 > EMC drivers now use new common devm_tegra_get_memory_controller() helper > instead of opencoding the MC retrieval. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/mc.c | 48 ++++++++++++++++++++++++ > drivers/memory/tegra/tegra124-emc.c | 18 ++------- > drivers/memory/tegra/tegra210-emc-core.c | 39 +++++-------------- > drivers/memory/tegra/tegra30-emc.c | 18 ++------- > include/soc/tegra/mc.h | 10 +++++ > 5 files changed, 74 insertions(+), 59 deletions(-) Acked-by: Thierry Reding --oxV4ZoPwBLqAyY+a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+YIiMACgkQ3SOs138+ s6Hfiw//dsmnyOi26C1B542Xl69Kt0RSahaqPgCob+RFtXhq//XjyEuLvOvQAjRe lxz5ae9bOY4g4M2xwaGEoD+itgWFP0Ls+bvD5nbLBGnO1Z+oHWlKyGx2qzJveXOj qP+dJHaaIyBO49MBznLzuWCOiP/lXB32WBNU3i/qsxh9S/7X7q3ihqYqezzrUMfh Gdhsfj+EWMF5w7ZlXv9WoiR0ZSdmqDTJTuE3JDs/r0olxRtN/wb0PRzAaYo1qyiv 7YRNvSzCDWeap4l0SH+i/Yndul783XqNtZAjEb0oS/wzCiH+szPJNhcozS/2TI+D Xza9bOPLxiY0GcngyhUQb/z6Z3PfdODVP6tHfFjOKzHnwyh9/XqgyZIzl8dKsk73 n9aYJUmv3cFU9fqqNFf3hjpcwjXIYk1FimqFTrvoC6emwsMjwEu7qARmWqpyIDEA bMTabxLAnzBW1Q/ftB8K1MK4h24B1jLGG6BfQDwW272+zbRkVP5fI5bhAKn85X1s npFW3cCKehnIAuxgLIob/RxLcu0T6U5TBD7yqyiuL79WqlW8xpN1oKLirEuToWFi 0XxaYBzC4vWO/5CGlSkbxlfBXNDscHte/b/Rany9br+SuiWFybW3a/IirgDSEzUh fiH8r5or8XwD6rXR5Qy7IhBmJOYserCHHQk0AGmwMUhfBHPgXRw= =Gbon -----END PGP SIGNATURE----- --oxV4ZoPwBLqAyY+a-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B18C55178 for ; Tue, 27 Oct 2020 13:35:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC71D21556 for ; Tue, 27 Oct 2020 13:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iNNryRd2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC71D21556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E3066E09E; Tue, 27 Oct 2020 13:35:36 +0000 (UTC) Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36AAB6E09E for ; Tue, 27 Oct 2020 13:35:35 +0000 (UTC) Received: by mail-ej1-x642.google.com with SMTP id c15so2295659ejs.0 for ; Tue, 27 Oct 2020 06:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8mQg3nh3RaesRS2P5WKkQKj2n7Sdjc0/yYomgGjrqio=; b=iNNryRd2nlTyxGTMh11x7reba8pbjJ8oqfWUoqPdnRReHWdK6LUDGWM37tgyyDiv2N nmVRPh2dnjwsreFvaLadAUa4r0NXafbS0cJjVn0CEAGJx4eOdW2Em5ss8a12y8JZMB+4 /S/Yln/enOzx6L1kmudHZ1nv+NQ9o1lPA0rJg7590Wn4H6Qss8bLjEmxtM5fCCN7o9Wf sHUahJRhBp6VZkCtCdUFCawRCFuthVnlM3P4VIhf4F3UwSrkUf7OXKU35ikqReEa9EaX qKd2NASh2NmgCn+6hfZM55WiAUQ7wBFXG4WsqUWSa9XEE9JWgDuJLG4bQJJSkp7p7s2S JfOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8mQg3nh3RaesRS2P5WKkQKj2n7Sdjc0/yYomgGjrqio=; b=t7XwAuo2g6PPxpomy3C/XheNGL2Tmsl4sJAVS+++/QQT/asFOqpXu7v6vYTneBNdu4 Xw5n6dsrIF2GtGUvvuMQxk3KzL+eWW6Fyu/JRXimJUSkU8iEvDMEZTA/K89G0BQ7kK5K GkB495SThnwiUb0L2McwOnjR31WqbRgCvGEP82Kh8QjObd1I8Bb3HMFU79mOVltN6okd 9mF8EBQxe/x8XNCwvuexIuL0eXdUdPXzC1MX3oeQYS4lY0QK1bHWj//XXzdcOnDaeNDO qink/9F5RXBJNYcoUR0Tus/it67zqPV6JqsNJyrBsnk3nugV7kjWJeKl0m/QsLgzGj40 N3Ng== X-Gm-Message-State: AOAM531o1mrrd3MNVD8mABJa7L7DLcJbKQVmoxIu2/MOODwDyUXkxIcB 7juhNSdjz2YdfkLY1Q29ajo= X-Google-Smtp-Source: ABdhPJyOS2GplJQHwJKYItyPwxlHn7uJ1Z/j8baAH8JyKjiTKLXB69/Mh3ufO4PujfYg/8EqfgktPw== X-Received: by 2002:a17:906:c095:: with SMTP id f21mr2593939ejz.108.1603805733846; Tue, 27 Oct 2020 06:35:33 -0700 (PDT) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id 6sm1054545ejv.49.2020.10.27.06.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 06:35:32 -0700 (PDT) Date: Tue, 27 Oct 2020 14:35:31 +0100 From: Thierry Reding To: Dmitry Osipenko Subject: Re: [PATCH v6 28/52] memory: tegra: Add and use devm_tegra_get_memory_controller() Message-ID: <20201027133531.GI1822510@ulmo> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-29-digetx@gmail.com> MIME-Version: 1.0 In-Reply-To: <20201025221735.3062-29-digetx@gmail.com> User-Agent: Mutt/1.14.7 (2020-08-29) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Peter De Schrijver , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Georgi Djakov , Chanwoo Choi , Kyungmin Park , Rob Herring , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Jonathan Hunter , Michael Turquette Content-Type: multipart/mixed; boundary="===============0009705127==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0009705127== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oxV4ZoPwBLqAyY+a" Content-Disposition: inline --oxV4ZoPwBLqAyY+a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 26, 2020 at 01:17:11AM +0300, Dmitry Osipenko wrote: > Multiple Tegra drivers need to retrieve Memory Controller and there is > duplication of the retrieval code among the drivers. This patch removes > the duplication and fixes put_device() which was missed in the duplicated > code. >=20 > EMC drivers now use new common devm_tegra_get_memory_controller() helper > instead of opencoding the MC retrieval. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/mc.c | 48 ++++++++++++++++++++++++ > drivers/memory/tegra/tegra124-emc.c | 18 ++------- > drivers/memory/tegra/tegra210-emc-core.c | 39 +++++-------------- > drivers/memory/tegra/tegra30-emc.c | 18 ++------- > include/soc/tegra/mc.h | 10 +++++ > 5 files changed, 74 insertions(+), 59 deletions(-) Acked-by: Thierry Reding --oxV4ZoPwBLqAyY+a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+YIiMACgkQ3SOs138+ s6Hfiw//dsmnyOi26C1B542Xl69Kt0RSahaqPgCob+RFtXhq//XjyEuLvOvQAjRe lxz5ae9bOY4g4M2xwaGEoD+itgWFP0Ls+bvD5nbLBGnO1Z+oHWlKyGx2qzJveXOj qP+dJHaaIyBO49MBznLzuWCOiP/lXB32WBNU3i/qsxh9S/7X7q3ihqYqezzrUMfh Gdhsfj+EWMF5w7ZlXv9WoiR0ZSdmqDTJTuE3JDs/r0olxRtN/wb0PRzAaYo1qyiv 7YRNvSzCDWeap4l0SH+i/Yndul783XqNtZAjEb0oS/wzCiH+szPJNhcozS/2TI+D Xza9bOPLxiY0GcngyhUQb/z6Z3PfdODVP6tHfFjOKzHnwyh9/XqgyZIzl8dKsk73 n9aYJUmv3cFU9fqqNFf3hjpcwjXIYk1FimqFTrvoC6emwsMjwEu7qARmWqpyIDEA bMTabxLAnzBW1Q/ftB8K1MK4h24B1jLGG6BfQDwW272+zbRkVP5fI5bhAKn85X1s npFW3cCKehnIAuxgLIob/RxLcu0T6U5TBD7yqyiuL79WqlW8xpN1oKLirEuToWFi 0XxaYBzC4vWO/5CGlSkbxlfBXNDscHte/b/Rany9br+SuiWFybW3a/IirgDSEzUh fiH8r5or8XwD6rXR5Qy7IhBmJOYserCHHQk0AGmwMUhfBHPgXRw= =Gbon -----END PGP SIGNATURE----- --oxV4ZoPwBLqAyY+a-- --===============0009705127== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0009705127==--