From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD90C4363A for ; Tue, 27 Oct 2020 18:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45F1A21556 for ; Tue, 27 Oct 2020 18:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603822721; bh=iBpv/+Q85ki7UClkXoDyjvr5iE7xHj1vnd2xSUXZCvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MEcD4Xe+TxugQqxSmJpdf7j9G/2UqB5N6b++HFdsij6tzJy11qZYgg10T5zIcttqn oC9i7qhORK/4Ma15qm14S0yH6WsgiXOdJKMXGoUaKKsbNoijsBbOFbWEQGmjUn9V9F as++DTTetm5ZRNJ+1CHwpgkkJjjrDD/qlCyr1hEQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1826304AbgJ0SSk (ORCPT ); Tue, 27 Oct 2020 14:18:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:59808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506898AbgJ0OLC (ORCPT ); Tue, 27 Oct 2020 10:11:02 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF83D2072D; Tue, 27 Oct 2020 14:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807862; bh=iBpv/+Q85ki7UClkXoDyjvr5iE7xHj1vnd2xSUXZCvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0R+/6s5RPcfqjtyFgzIuT4lGGKIMvLZWvxzskLzC0bNdq3MFpiDQ2hWM5/SCbvG6I 4aGOQhDVdR2Y8LcmA6CR+JYI1uou5/IKG/CrEAotuNYNKphhImwLwsvHwCUGnzJD4d Vov8E9vvEEw8LIbr7hx3r2AmKPIVf9PwlUYYwgkk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 037/191] media: platform: fcp: Fix a reference count leak. Date: Tue, 27 Oct 2020 14:48:12 +0100 Message-Id: <20201027134911.532172058@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134909.701581493@linuxfoundation.org> References: <20201027134909.701581493@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu [ Upstream commit 63e36a381d92a9cded97e90d481ee22566557dd1 ] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 6eaafbdb668b ("[media] v4l: rcar-fcp: Keep the coding style consistent") Signed-off-by: Qiushi Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rcar-fcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c index 0047d144c9326..19502a1860cf5 100644 --- a/drivers/media/platform/rcar-fcp.c +++ b/drivers/media/platform/rcar-fcp.c @@ -106,8 +106,10 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp) return 0; ret = pm_runtime_get_sync(fcp->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_noidle(fcp->dev); return ret; + } return 0; } -- 2.25.1