From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 136F4C4363A for ; Tue, 27 Oct 2020 18:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDE462076D for ; Tue, 27 Oct 2020 18:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603821978; bh=nya+DzPfGCgen7n8gz7XXNnfG1S3MiBW7FmTdewTuYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=anH7jvUfsRlbs4W7lhaWkeVUuWFeYeZT07RR9zqNyfT2qwx2YdQIY0Xfko9Y8GDdt FO3Pm/57Q+bcQcWgsMqqeNNtRbMcIwocN7nCefzbLKVXqd3cOg6ToLMIuPJb/lDjo+ /ewH9x4ZcPk8KHT1yHmgKlr4UuA53gTLoeA8dQ4U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1824833AbgJ0SGM (ORCPT ); Tue, 27 Oct 2020 14:06:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:40326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757270AbgJ0ORR (ORCPT ); Tue, 27 Oct 2020 10:17:17 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA26E2072D; Tue, 27 Oct 2020 14:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808237; bh=nya+DzPfGCgen7n8gz7XXNnfG1S3MiBW7FmTdewTuYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u+SHuCUoBCXLUNTcBaKYuBCaXx+T1iC7tPr/6LEGLP7LKhhxxNqn44oGnxCvnzZF0 JyS/5yAN3GbFEVC6kV1XeS3XNdlwkKM5Z9TCbIh0Ypmb3WNtqM69Otp2DVPjwVsnUq Ww8dpyszh4lA3ROJUnxtjt0lvPpX1Y/ahe3L0SA8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Karsten Graul , Jakub Kicinski Subject: [PATCH 4.19 008/264] net/smc: fix valid DMBE buffer sizes Date: Tue, 27 Oct 2020 14:51:06 +0100 Message-Id: <20201027135431.048873832@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135430.632029009@linuxfoundation.org> References: <20201027135430.632029009@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Karsten Graul [ Upstream commit ef12ad45880b696eb993d86c481ca891836ab593 ] The SMCD_DMBE_SIZES should include all valid DMBE buffer sizes, so the correct value is 6 which means 1MB. With 7 the registration of an ISM buffer would always fail because of the invalid size requested. Fix that and set the value to 6. Fixes: c6ba7c9ba43d ("net/smc: add base infrastructure for SMC-D and ISM") Signed-off-by: Karsten Graul Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/smc/smc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -770,7 +770,7 @@ static struct smc_buf_desc *smcr_new_buf return buf_desc; } -#define SMCD_DMBE_SIZES 7 /* 0 -> 16KB, 1 -> 32KB, .. 6 -> 1MB */ +#define SMCD_DMBE_SIZES 6 /* 0 -> 16KB, 1 -> 32KB, .. 6 -> 1MB */ static struct smc_buf_desc *smcd_new_buf_create(struct smc_link_group *lgr, bool is_dmb, int bufsize)