From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382DDC388F9 for ; Tue, 27 Oct 2020 14:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE0082072D for ; Tue, 27 Oct 2020 14:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808532; bh=/3DGhVJWA+qE/dFPc+EzjBK/VRNYI0Cyn4S2SSTLUAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UdP820nv1ojcopjx9kKuHl0jO3ckrCNVZ+J+L0go5m/U0GEFkTjcmxUM6sUVo8SAY rMHExb6hx+Eje2Rrg93tPOwTB7pQrpw9vFQRcZ263Ju27wMSmEIPUrQFIlbDkYCpfH HzaE2zHlc7Jl/6v5luCWr/35sDj4Szb4vncotLO0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758679AbgJ0OWK (ORCPT ); Tue, 27 Oct 2020 10:22:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:43980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758294AbgJ0OUE (ORCPT ); Tue, 27 Oct 2020 10:20:04 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B86B206D4; Tue, 27 Oct 2020 14:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808404; bh=/3DGhVJWA+qE/dFPc+EzjBK/VRNYI0Cyn4S2SSTLUAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZDvwHN1K+WkFuX5xulWSkKSUcT952IOjiC4xPxPzr24uNKWdZIJCVUSsFePA+0j8b I9u2BBjlmNwoa8xfoOgbac9ZQAMHyS6QgrHHhuHAsyxqlmBOIcQxRx+2Ajnc1SNM/R ue1S5kTFKHNkG6ajqyUcKowCBHYdi1xwN2tMefIA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dinghao Liu , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 048/264] media: omap3isp: Fix memleak in isp_probe Date: Tue, 27 Oct 2020 14:51:46 +0100 Message-Id: <20201027135432.935209253@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135430.632029009@linuxfoundation.org> References: <20201027135430.632029009@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dinghao Liu [ Upstream commit d8fc21c17099635e8ebd986d042be65a6c6b5bd0 ] When devm_ioremap_resource() fails, isp should be freed just like other error paths in isp_probe. Fixes: 8644cdf972dd6 ("[media] omap3isp: Replace many MMIO regions by two") Signed-off-by: Dinghao Liu Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/omap3isp/isp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index addd03b517481..00e52f0b8251b 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2265,8 +2265,10 @@ static int isp_probe(struct platform_device *pdev) mem = platform_get_resource(pdev, IORESOURCE_MEM, i); isp->mmio_base[map_idx] = devm_ioremap_resource(isp->dev, mem); - if (IS_ERR(isp->mmio_base[map_idx])) - return PTR_ERR(isp->mmio_base[map_idx]); + if (IS_ERR(isp->mmio_base[map_idx])) { + ret = PTR_ERR(isp->mmio_base[map_idx]); + goto error; + } } ret = isp_get_clocks(isp); -- 2.25.1