From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F5DC55178 for ; Tue, 27 Oct 2020 14:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AC95207C3 for ; Tue, 27 Oct 2020 14:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808850; bh=q3MzAuoQgiGrUsKUnfHFTfEi9q0o14DQOcrrUj1FvCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZWbUluHn9Ro9dMeDvkIJykWgLgrIHzQrY3R+EJ1jmpwgKiqK+jjvYwCISZn1Qy7eE WMhyrmwkRlvNlze7p9MXGSK6xHraaYExhior7rfpPxhUp4h1KiTaz74l4gGiIlHWbY dgVeWZqSGnFesTA4mxmH1GePtqLFh10AaooiJiEQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505810AbgJ0O13 (ORCPT ); Tue, 27 Oct 2020 10:27:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:52912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2901613AbgJ0O04 (ORCPT ); Tue, 27 Oct 2020 10:26:56 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B14120780; Tue, 27 Oct 2020 14:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808815; bh=q3MzAuoQgiGrUsKUnfHFTfEi9q0o14DQOcrrUj1FvCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a8bzNOYzMOPOitivFBfN7U2J+2miG55+hzNTawyRdfafoGS/GzFm/BYHpOeaz9k3K fI3pELUXiuS2paPTIwb42RXVqo84Sr0ZS/SZPtq7GJXrLI9JTcRvklVMy6nMpDnPIT /yPln0Z+U6925KqT5quaayYzXUNqhVCYXxuk6LQ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+9991561e714f597095da@syzkaller.appspotmail.com, Jan Kara , Sasha Levin Subject: [PATCH 4.19 234/264] udf: Limit sparing table size Date: Tue, 27 Oct 2020 14:54:52 +0100 Message-Id: <20201027135441.638130094@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135430.632029009@linuxfoundation.org> References: <20201027135430.632029009@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Kara [ Upstream commit 44ac6b829c4e173fdf6df18e6dd86aecf9a3dc99 ] Although UDF standard allows it, we don't support sparing table larger than a single block. Check it during mount so that we don't try to access memory beyond end of buffer. Reported-by: syzbot+9991561e714f597095da@syzkaller.appspotmail.com Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/super.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/udf/super.c b/fs/udf/super.c index 1676a175cd7a8..caeb01ca039b7 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1349,6 +1349,12 @@ static int udf_load_sparable_map(struct super_block *sb, (int)spm->numSparingTables); return -EIO; } + if (le32_to_cpu(spm->sizeSparingTable) > sb->s_blocksize) { + udf_err(sb, "error loading logical volume descriptor: " + "Too big sparing table size (%u)\n", + le32_to_cpu(spm->sizeSparingTable)); + return -EIO; + } for (i = 0; i < spm->numSparingTables; i++) { loc = le32_to_cpu(spm->locSparingTable[i]); -- 2.25.1