From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA4DC388F9 for ; Tue, 27 Oct 2020 17:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4107320878 for ; Tue, 27 Oct 2020 17:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603819940; bh=tC9peKfGXTrex7BCxMuGu53hB4t52oYA35XieGlzdLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bX9d0Wpu0M3pzHpdY8y0MxyfAsf9+9k9Qrsn+A/o8A9M1CJwMO1l/nPSqW4QdTWig PT6ORCD3DioJl+xEk9uzduLzmWnwlAGbDKERg+NaSv590tGiuOUNMOMnUGAUDWAehu uvMWwv9HNbeyfz1QKbKTXnrZDvoRCxYtA5j6HOp4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1820032AbgJ0RcS (ORCPT ); Tue, 27 Oct 2020 13:32:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:41218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762291AbgJ0Olq (ORCPT ); Tue, 27 Oct 2020 10:41:46 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BA06206B2; Tue, 27 Oct 2020 14:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809705; bh=tC9peKfGXTrex7BCxMuGu53hB4t52oYA35XieGlzdLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=te9JIMKsrbM5S29rNSzMntbY+n0cOAQnRluosrsMQPTQ+wGt8adQJY8sjhcJgj726 PcL/L/Zt9tbti5Z3P+Uh/lAnYTwxTGHXDQwHvjmzmJx+H77tFHvY00bOz/frch/WYU PfLOguAkwefh4ogEtP/vASi3EYhMdgyhl4Fp+WdA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jing Xiangfeng , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 291/408] scsi: bfa: Fix error return in bfad_pci_init() Date: Tue, 27 Oct 2020 14:53:49 +0100 Message-Id: <20201027135508.544244355@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Xiangfeng [ Upstream commit f0f6c3a4fcb80fcbcce4ff6739996dd98c228afd ] Fix to return error code -ENODEV from the error handling case instead of 0. Link: https://lore.kernel.org/r/20200925062423.161504-1-jingxiangfeng@huawei.com Fixes: 11ea3824140c ("scsi: bfa: fix calls to dma_set_mask_and_coherent()") Signed-off-by: Jing Xiangfeng Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/bfa/bfad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index 2f9213b257a4a..93e4011809919 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -749,6 +749,7 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad) if (bfad->pci_bar0_kva == NULL) { printk(KERN_ERR "Fail to map bar0\n"); + rc = -ENODEV; goto out_release_region; } -- 2.25.1