From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77421C388F9 for ; Tue, 27 Oct 2020 15:03:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2357021D24 for ; Tue, 27 Oct 2020 15:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811012; bh=XI/PGtV0g0DQ1gOTZuh8r193FjOwkN/55NTCqAc7kB8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yoWP/5nYgPdAwyfAJ7Md0S3At7nZEuxAs1ravha7eSrxOVUXsjaqvk4Zo+7kbgKbA wOKkYBwOMIK4uEh7/JgMY+x9NE5A3DyXci8ZAF/kATd7CxaLzNSc2TryYi+E4C/wF8 qad5+1PcZHw8Tzf/4Q3Mv33TFN1+RJEf/5+CcEZ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1790010AbgJ0PDa (ORCPT ); Tue, 27 Oct 2020 11:03:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:33686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1788707AbgJ0PAc (ORCPT ); Tue, 27 Oct 2020 11:00:32 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50BD622264; Tue, 27 Oct 2020 15:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810831; bh=XI/PGtV0g0DQ1gOTZuh8r193FjOwkN/55NTCqAc7kB8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NCC55EjwxSu1qiGK2DWGAp4OQCUO8D9eZLkvZGDJiWbljc7mGSwrY18owKqntPeYf 7fSF1zcsd7VTEPqVO9PImKK5VJkpyTW7o5/BUtYSvwlSBo0U7gulSuiKJvPNusJpQf AZte+qUmwIUcYlYXDcHADUB3IuCLLhABWXIseBVQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Murphy , Mark Brown , Sasha Levin Subject: [PATCH 5.8 247/633] ASoC: tas2770: Add missing bias level power states Date: Tue, 27 Oct 2020 14:49:50 +0100 Message-Id: <20201027135534.265361809@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Murphy [ Upstream commit 4272caf34aa4699eca8e6e7f4a8e5ea2bde275c9 ] Add the BIAS_STANDBY and BIAS_PREPARE to the set_bias_level or else the driver will return -EINVAL which is not correct as they are valid states. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy Link: https://lore.kernel.org/r/20200918190548.12598-2-dmurphy@ti.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/tas2770.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index 9f759c51ca435..4d67b1c160380 100644 --- a/sound/soc/codecs/tas2770.c +++ b/sound/soc/codecs/tas2770.c @@ -57,7 +57,12 @@ static int tas2770_set_bias_level(struct snd_soc_component *component, TAS2770_PWR_CTRL_MASK, TAS2770_PWR_CTRL_ACTIVE); break; - + case SND_SOC_BIAS_STANDBY: + case SND_SOC_BIAS_PREPARE: + snd_soc_component_update_bits(component, + TAS2770_PWR_CTRL, + TAS2770_PWR_CTRL_MASK, TAS2770_PWR_CTRL_MUTE); + break; case SND_SOC_BIAS_OFF: snd_soc_component_update_bits(component, TAS2770_PWR_CTRL, -- 2.25.1