From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D69C388F7 for ; Thu, 29 Oct 2020 00:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC67020791 for ; Thu, 29 Oct 2020 00:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603933098; bh=bd15X0ZO/kKl56YTZtPK2286ovxkGWRvjUY09nh7kq4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=XeGhzAtC9lkBK+2nlNcdZOk+WwykioVgr4f+U4M91gP65m58ySEFpnI4hXw286iRg 3XlZGtQvCiRVxRsVkRZt1SzNlSFeo2KDzeq0JwbvfUhknG7Xt6i35QVae0EPq56mXW MCuAsqYIf74ut6S9SOr8SqbrEaSovFBlNke0hxOA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbgJ2A6R (ORCPT ); Wed, 28 Oct 2020 20:58:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:60518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731582AbgJ1WRc (ORCPT ); Wed, 28 Oct 2020 18:17:32 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D9B90222D9; Wed, 28 Oct 2020 00:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603846471; bh=bd15X0ZO/kKl56YTZtPK2286ovxkGWRvjUY09nh7kq4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L20IJGQtEtrEoLKXAHARu3Eqoz4drhMWZC/OnKcl8MOLELTjQqaxghn1LeYvApIY/ vN4gel8NeDlz/iH/e0Bp9YTi+sOsaE18ZIp3689mKtyOTuOaX+FyejQ/DefkkPBu9f Yd/cSwI3PDj7pZC0vxW3vKMU2TWO4ZvBpCzyLd0E= Date: Tue, 27 Oct 2020 17:54:30 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Cc: Michal Suchanek , netdev@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Cristobal Forno , "David S. Miller" , Cris Forno , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-ID: <20201027175430.1f6a74b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201026200407.fcf43678ba4cef7fe0cb7c98@suse.de> References: <20201026104221.26570-1-msuchanek@suse.de> <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201026200407.fcf43678ba4cef7fe0cb7c98@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote: > > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > > From: Thomas Bogendoerfer > > > > > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > > > but now suppresses bridged frames, which are accepted by the hypervisor > > > otherwise bridging won't work at all. > > > > > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > > > Signed-off-by: Michal Suchanek > > > > Since the From: line says Thomas we need a signoff from him. > > you can add > > Signed-off-by: tbogendoerfer@suse.de Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203C5C388F9 for ; Wed, 28 Oct 2020 00:56:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87D37222E9 for ; Wed, 28 Oct 2020 00:56:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="L20IJGQt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87D37222E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CLVWQ05d9zDqS6 for ; Wed, 28 Oct 2020 11:56:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=kuba@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=L20IJGQt; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CLVTQ3NjLzDqRN for ; Wed, 28 Oct 2020 11:54:34 +1100 (AEDT) Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D9B90222D9; Wed, 28 Oct 2020 00:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603846471; bh=bd15X0ZO/kKl56YTZtPK2286ovxkGWRvjUY09nh7kq4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L20IJGQtEtrEoLKXAHARu3Eqoz4drhMWZC/OnKcl8MOLELTjQqaxghn1LeYvApIY/ vN4gel8NeDlz/iH/e0Bp9YTi+sOsaE18ZIp3689mKtyOTuOaX+FyejQ/DefkkPBu9f Yd/cSwI3PDj7pZC0vxW3vKMU2TWO4ZvBpCzyLd0E= Date: Tue, 27 Oct 2020 17:54:30 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-ID: <20201027175430.1f6a74b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201026200407.fcf43678ba4cef7fe0cb7c98@suse.de> References: <20201026104221.26570-1-msuchanek@suse.de> <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201026200407.fcf43678ba4cef7fe0cb7c98@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cristobal Forno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Michal Suchanek , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Cris Forno Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote: > > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > > From: Thomas Bogendoerfer > > > > > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > > > but now suppresses bridged frames, which are accepted by the hypervisor > > > otherwise bridging won't work at all. > > > > > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > > > Signed-off-by: Michal Suchanek > > > > Since the From: line says Thomas we need a signoff from him. > > you can add > > Signed-off-by: tbogendoerfer@suse.de Applied, thanks.