From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E67B4C388F9 for ; Tue, 27 Oct 2020 18:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FFAA20723 for ; Tue, 27 Oct 2020 18:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1825023AbgJ0SHj (ORCPT ); Tue, 27 Oct 2020 14:07:39 -0400 Received: from foss.arm.com ([217.140.110.172]:49532 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1825005AbgJ0SHg (ORCPT ); Tue, 27 Oct 2020 14:07:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D97A5139F; Tue, 27 Oct 2020 11:07:35 -0700 (PDT) Received: from e108754-lin.cambridge.arm.com (e108754-lin.cambridge.arm.com [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1B7B33F85F; Tue, 27 Oct 2020 11:07:34 -0700 (PDT) From: Ionela Voinescu To: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: dietmar.eggemann@arm.com, qperret@google.com, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ionela.voinescu@arm.com Subject: [PATCH RESEND v2 0/3] condition EAS enablement on FI support Date: Tue, 27 Oct 2020 18:07:10 +0000 Message-Id: <20201027180713.7642-1-ionela.voinescu@arm.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Given the maturity gained by cpufreq-based Frequency Invariance (FI) support following the patches at [1], this series conditions Energy Aware Scheduling (EAS) enablement on a frequency invariant system. Currently, EAS can be enabled on a system without FI support, leading to incorrect (energy-wise) task placements. As no warning is emitted, it could take some debugging effort to track the behavior back to the lack of FI support; this series changes that by disabling EAS (and advertising it) when FI support is missing. The series is structured as follows: - 1/3 - create function that can rebuild the scheduling and EAS' performance domains if EAS' initial conditions change - 2/3 - arm64: rebuild scheduling and performance domains in the case of late, counter-driven FI initialisation. - 3/3 - condition EAS enablement on FI support RESEND v2: rebase and retest on v5.10-rc1 v1 -> v2: - v1 can be found at [2] - 1/2 - moved now "static inline" rebuild_sched_domains_energy() stub in sched/topology.h header, as suggested by Quentin. - Changed the order of 2/3 and 3/3 to maintain bisection as suggested by Quentin. - 3/3 - place the warning under sched_debug() as per Quentin and Dietmar's recommendations. [1] Most recent version at: https://lore.kernel.org/lkml/20200901205549.30096-1-ionela.voinescu@arm.com/ [2] https://lore.kernel.org/lkml/20200924123937.20938-1-ionela.voinescu@arm.com/ Many thanks, Ionela. Ionela Voinescu (3): sched/topology,schedutil: wrap sched domains rebuild arm64: rebuild sched domains on invariance status changes sched/topology: condition EAS enablement on FIE support arch/arm64/kernel/topology.c | 10 ++++++++++ include/linux/sched/topology.h | 8 ++++++++ kernel/sched/cpufreq_schedutil.c | 9 +-------- kernel/sched/topology.c | 27 ++++++++++++++++++++------- 4 files changed, 39 insertions(+), 15 deletions(-) base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F2CC388F9 for ; Tue, 27 Oct 2020 18:09:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1B9820723 for ; Tue, 27 Oct 2020 18:09:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NVxGOlnq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1B9820723 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=lZCYFRZ87/lopHABeFj6X0USBhJxYkb+azUNpHQyzmQ=; b=NVxGOlnqOT0Se1EWjwcWbNJXqA M3Zy45s5eqCnqMFx8U6zjSjjeMYGMQIxvmuFFJlxzHmqCUBlh6hcb46uI0+cWHM21Hjdiq7I7k0Q/ aHSGI4V2ztapc2KDuWd+UfPB4xJJejQtmUfU6wc2Js3SSDZAxo4ksVTL1LZCytlAGYs/FYVdJcFgv iQN5THZzFtpJIxXi36KToHE9H70YyXXwqqFVEgfJYhx16rsAnnIHunAXC9NxDe0qhV8SnhQ+mxKIu cw37W2dhX2yHQDfQ8EEXfXgdOOZXAvDazHK2mYlg22QNy1dMYNLGWlvywNUKfCDzqXBy857t2qJV/ VOOT86cQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXTNj-0006cz-Ge; Tue, 27 Oct 2020 18:07:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXTNh-0006cP-6j for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 18:07:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D97A5139F; Tue, 27 Oct 2020 11:07:35 -0700 (PDT) Received: from e108754-lin.cambridge.arm.com (e108754-lin.cambridge.arm.com [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1B7B33F85F; Tue, 27 Oct 2020 11:07:34 -0700 (PDT) From: Ionela Voinescu To: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH RESEND v2 0/3] condition EAS enablement on FI support Date: Tue, 27 Oct 2020 18:07:10 +0000 Message-Id: <20201027180713.7642-1-ionela.voinescu@arm.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_140737_348175_254E534A X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, qperret@google.com, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, ionela.voinescu@arm.com, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Given the maturity gained by cpufreq-based Frequency Invariance (FI) support following the patches at [1], this series conditions Energy Aware Scheduling (EAS) enablement on a frequency invariant system. Currently, EAS can be enabled on a system without FI support, leading to incorrect (energy-wise) task placements. As no warning is emitted, it could take some debugging effort to track the behavior back to the lack of FI support; this series changes that by disabling EAS (and advertising it) when FI support is missing. The series is structured as follows: - 1/3 - create function that can rebuild the scheduling and EAS' performance domains if EAS' initial conditions change - 2/3 - arm64: rebuild scheduling and performance domains in the case of late, counter-driven FI initialisation. - 3/3 - condition EAS enablement on FI support RESEND v2: rebase and retest on v5.10-rc1 v1 -> v2: - v1 can be found at [2] - 1/2 - moved now "static inline" rebuild_sched_domains_energy() stub in sched/topology.h header, as suggested by Quentin. - Changed the order of 2/3 and 3/3 to maintain bisection as suggested by Quentin. - 3/3 - place the warning under sched_debug() as per Quentin and Dietmar's recommendations. [1] Most recent version at: https://lore.kernel.org/lkml/20200901205549.30096-1-ionela.voinescu@arm.com/ [2] https://lore.kernel.org/lkml/20200924123937.20938-1-ionela.voinescu@arm.com/ Many thanks, Ionela. Ionela Voinescu (3): sched/topology,schedutil: wrap sched domains rebuild arm64: rebuild sched domains on invariance status changes sched/topology: condition EAS enablement on FIE support arch/arm64/kernel/topology.c | 10 ++++++++++ include/linux/sched/topology.h | 8 ++++++++ kernel/sched/cpufreq_schedutil.c | 9 +-------- kernel/sched/topology.c | 27 ++++++++++++++++++++------- 4 files changed, 39 insertions(+), 15 deletions(-) base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel