From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1kXTO9-0005b9-FN
	for mharc-grub-devel@gnu.org; Tue, 27 Oct 2020 14:08:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53920)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1kXTO7-0005Y8-9L
 for grub-devel@gnu.org; Tue, 27 Oct 2020 14:08:03 -0400
Received: from dibed.net-space.pl ([84.10.22.86]:57772)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1kXTO5-0000fK-QO
 for grub-devel@gnu.org; Tue, 27 Oct 2020 14:08:02 -0400
Received: from router-fw.i.net-space.pl ([192.168.52.1]:57516 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S2051318AbgJ0SH6 (ORCPT <rfc822;grub-devel@gnu.org>);
 Tue, 27 Oct 2020 19:07:58 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Tue, 27 Oct 2020 19:07:56 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Glenn Washburn <development@efficientek.com>
Subject: Re: [PATCH v3 09/10] cryptodisk: Rename offset in grub_cryptodisk_t
 to offset_sectors.
Message-ID: <20201027180756.vi3trmlkezhxn4u2@tomti.i.net-space.pl>
References: <20201009100122.GH2088@tanuki>
 <cover.1603148098.git.development@efficientek.com>
 <74c6232c9b707d7c3a3236969a6e3f8744e563d5.1603148099.git.development@efficientek.com>
 <20201023175813.GD810@tanuki>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201023175813.GD810@tanuki>
User-Agent: NeoMutt/20170113 (1.7.2)
Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl;
 helo=dibed.net-space.pl
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 14:03:44
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic] [fuzzy]
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Oct 2020 18:08:03 -0000

On Fri, Oct 23, 2020 at 07:58:13PM +0200, Patrick Steinhardt wrote:
> On Mon, Oct 19, 2020 at 06:09:57PM -0500, Glenn Washburn wrote:
> > This makes it clear that the offset represents sectors, not bytes, in order
> > to improve readability.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel