From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kXUay-0007tY-Bu for mharc-grub-devel@gnu.org; Tue, 27 Oct 2020 15:25:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXUaw-0007ph-GC for grub-devel@gnu.org; Tue, 27 Oct 2020 15:25:22 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:57943) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1kXUau-00043f-O7 for grub-devel@gnu.org; Tue, 27 Oct 2020 15:25:22 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:57704 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2052096AbgJ0TZQ (ORCPT ); Tue, 27 Oct 2020 20:25:16 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Tue, 27 Oct 2020 20:25:13 +0100 From: Daniel Kiper To: Glenn Washburn Cc: grub-devel@gnu.org, Patrick Steinhardt Subject: Re: [PATCH v3 00/10] Cryptodisk fixes for v2.06 redux Message-ID: <20201027192513.gtrjl5koqgf5gxca@tomti.i.net-space.pl> References: <20201009100122.GH2088@tanuki> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 14:03:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 19:25:22 -0000 On Mon, Oct 19, 2020 at 06:09:48PM -0500, Glenn Washburn wrote: > Heres an updated patch series which addresses comment from Patrick. The only > code change is adding a slot_key member to grub_luks2_keyslot and using that > instead of an extra out parameter to luks2_get_keyslot. > > Glenn Washburn (10): > luks2: Fix use of incorrect index and some grub_error() messages. > luks2: Improve readability in luks2_get_keyslot. > luks2: Use more intuitive keyslot key instead of index when naming > keyslot. > luks2: grub_cryptodisk_t->total_length is the max number of device > native sectors > cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'. > cryptodisk: Properly handle non-512 byte sized sectors. > cryptodisk: Replace some literals with constants in > grub_cryptodisk_endecrypt. > cryptodisk: Rename total_length field in grub_cryptodisk_t to > total_sectors. > cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors. > luks2: Rename source disk variabled named 'disk' to 'source' as in > luks.c. Most of LUKS2 patches require rework. The rest which got Patrick's and my RB I will push into the GRUB git repo by the end of this week. Of course if there are no objections... Daniel