From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C6DC55178 for ; Tue, 27 Oct 2020 19:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9814522267 for ; Tue, 27 Oct 2020 19:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603827583; bh=TqdeKbdqomt0pCdLikA/s/iCEfGiwOdKuyQw8BO6JOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Rf2qppvLhBJBCuUNo4UWqZTqq+WExdYVSFqrB4pKIdMMEWJAdZlJyku8ozOlHps31 Wq27OWd/LkZkYCvRXziH34lBAy8yeicPidW+0SnNcpPIchAyChQuT4fIw4wIAiFTGm pPkk0YnZajfyv7gPe0GNWymgtBuGzgllQRKlmgo0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1830348AbgJ0Tjg convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2020 15:39:36 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:37830 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504405AbgJ0Tjf (ORCPT ); Tue, 27 Oct 2020 15:39:35 -0400 Received: by mail-ed1-f68.google.com with SMTP id o18so2697061edq.4; Tue, 27 Oct 2020 12:39:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=prGqBiI5JimrXFF/vzXUDQaJ2EGlRDSeqqtNy7sjrCk=; b=eeR7ZZa3mX1J7wzslIN5qYkm+IQGhYbwJeOmzoTdhUPcL86D23ES7Jl5HoyCXGruDH KTLluNLroz3oyiWpKcmD4dzPWoGbfnHGdbbhXlBwN+9m1/dDEacXhT9P97iQ0CLzb0Sc fVzvHsbz+8fRmGrr/XFkCXGdFvEaA0N74CbVK+qmZQXBFh9krF5qDFV2PsPhRU6mZrR8 9ldQtTdh7mhiFABYLipfG6XGZxdK/PbDwlF7mYu6ANQIlgQSWeIl+vBFDvfFIcNtCXhG 7TkJD2+HMG50DA1gbOBxIVkSJTtEHoOpele95FXOm1rvC86K8M+1675sqGa+zdawEufW JWiQ== X-Gm-Message-State: AOAM531T+qFshkMml7G943NSB/MjydGTj0s1rC7pkm4WIbrnXzhxi6hE SnCkcDpDho/Da1wTAEM5lDc= X-Google-Smtp-Source: ABdhPJx/SLYaSJuvkdADGSTZROEQyUbm34KcNB5Cvm3aHaUVFHZ7v9Fg+sHR2VzYjZ1cuP6eGnu2Ow== X-Received: by 2002:a50:d0d0:: with SMTP id g16mr3879489edf.18.1603827573664; Tue, 27 Oct 2020 12:39:33 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id n22sm1534573edr.11.2020.10.27.12.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:39:32 -0700 (PDT) Date: Tue, 27 Oct 2020 20:39:30 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 09/52] dt-bindings: memory: tegra30: mc: Document new interconnect property Message-ID: <20201027193930.GC140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-10-digetx@gmail.com> <20201027090550.GI4244@kozik-lap> <7770b89e-f30b-3bfd-1e21-8ebbe905efcd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <7770b89e-f30b-3bfd-1e21-8ebbe905efcd@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Oct 27, 2020 at 10:18:35PM +0300, Dmitry Osipenko wrote: > 27.10.2020 12:05, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:52AM +0300, Dmitry Osipenko wrote: > >> Memory controller is interconnected with memory clients and with the > >> External Memory Controller. Document new interconnect property which > >> turns memory controller into interconnect provider. > >> > >> Acked-by: Rob Herring > >> Signed-off-by: Dmitry Osipenko > >> --- > >> .../bindings/memory-controllers/nvidia,tegra30-mc.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > >> index 84fd57bcf0dc..5436e6d420bc 100644 > >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > >> @@ -57,6 +57,9 @@ properties: > >> "#iommu-cells": > >> const: 1 > >> > >> + "#interconnect-cells": > >> + const: 1 > >> + > >> patternProperties: > >> "^emc-timings-[0-9]+$": > >> type: object > >> @@ -120,6 +123,7 @@ required: > >> - clock-names > >> - "#reset-cells" > >> - "#iommu-cells" > >> + - "#interconnect-cells" > > > > Rob, > > > > You were fine with adding a new required property which breaks all > > existing DTBs? > > This is a required property for the new bindings and optional for the > older. Does it really need to be made optional in the binding? Mhmm... that's an interesting point. I assumed that the bindings should reflect current status of the ABI, but I could imagine that you update the bindings while keeping the driver working with older DTBs. How do you actually track then the ABI? If incompatible change can be added to the bindings, later anyone anytime can also update the driver to enforce the bindings. To require such property. Best regards, Krzysztof > > > Were these bindings marked as unstable? The patchset does not even > > say/scream that it breaks the ABI, so this might be quite a surprise for > > someone... > > Please see tegra_mc_interconnect_setup() in "memory: tegra-mc: Add > interconnect framework" patch, which check presence of the new ICC DT > property. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1044C4363A for ; Tue, 27 Oct 2020 19:39:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86C3D2222C for ; Tue, 27 Oct 2020 19:39:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86C3D2222C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D8BF66E029; Tue, 27 Oct 2020 19:39:35 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13CF86E029 for ; Tue, 27 Oct 2020 19:39:35 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id v19so2673918edx.9 for ; Tue, 27 Oct 2020 12:39:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=prGqBiI5JimrXFF/vzXUDQaJ2EGlRDSeqqtNy7sjrCk=; b=EhPldmRSRuT/Z/Zo0nGEIzcJXQkGXl42sPlFQ+PlzL7swXnY1Qpl3at9HErmLYfH+h eaRZ8VjF1aYM5AmqksV/q4BMkpHnpAr4Zy205g/otGWwSzrS2pdzLtAwXiK9//7Gk+GT e5aO6A7IXtqgpLFfy0yzQ8EnhMCNY1MaDVpeF6ssQ6IOtd127JHpXyoKD7ag4ULtJgQo /EU6VJcLLE3BQI7+q8w6oDQ8hQnFfniRMRB/Myl4ixLzl6Hl28XXYslfZY0R2o1fsQ/H l2/nKmRn7mxxGfhYVM4Lt6Iu2iKty4zv4R2tLogLYYAcKlitvEFcrEX+EXXsJ17nJ56a glug== X-Gm-Message-State: AOAM531ANTNAs2pBGRMBJWgpv/0GWkkC9IbJFpqpbt9yU1HQx32B4f+m bqtjBhPJ0QGVSyOe0Orcrlk= X-Google-Smtp-Source: ABdhPJx/SLYaSJuvkdADGSTZROEQyUbm34KcNB5Cvm3aHaUVFHZ7v9Fg+sHR2VzYjZ1cuP6eGnu2Ow== X-Received: by 2002:a50:d0d0:: with SMTP id g16mr3879489edf.18.1603827573664; Tue, 27 Oct 2020 12:39:33 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id n22sm1534573edr.11.2020.10.27.12.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:39:32 -0700 (PDT) Date: Tue, 27 Oct 2020 20:39:30 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 09/52] dt-bindings: memory: tegra30: mc: Document new interconnect property Message-ID: <20201027193930.GC140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-10-digetx@gmail.com> <20201027090550.GI4244@kozik-lap> <7770b89e-f30b-3bfd-1e21-8ebbe905efcd@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7770b89e-f30b-3bfd-1e21-8ebbe905efcd@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBPY3QgMjcsIDIwMjAgYXQgMTA6MTg6MzVQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI3LjEwLjIwMjAgMTI6MDUsIEtyenlzenRvZiBLb3psb3dza2kg0L/QuNGI0LXR gjoKPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjUyQU0gKzAzMDAsIERtaXRyeSBP c2lwZW5rbyB3cm90ZToKPiA+PiBNZW1vcnkgY29udHJvbGxlciBpcyBpbnRlcmNvbm5lY3RlZCB3 aXRoIG1lbW9yeSBjbGllbnRzIGFuZCB3aXRoIHRoZQo+ID4+IEV4dGVybmFsIE1lbW9yeSBDb250 cm9sbGVyLiBEb2N1bWVudCBuZXcgaW50ZXJjb25uZWN0IHByb3BlcnR5IHdoaWNoCj4gPj4gdHVy bnMgbWVtb3J5IGNvbnRyb2xsZXIgaW50byBpbnRlcmNvbm5lY3QgcHJvdmlkZXIuCj4gPj4KPiA+ PiBBY2tlZC1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+PiBTaWduZWQtb2Zm LWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+Cj4gPj4gLS0tCj4gPj4gIC4u Li9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMzAtbWMueWFtbCAgICAg ICB8IDUgKysrKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+ID4+Cj4g Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnkt Y29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMzAtbWMueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMzAtbWMueWFtbAo+ ID4+IGluZGV4IDg0ZmQ1N2JjZjBkYy4uNTQzNmU2ZDQyMGJjIDEwMDY0NAo+ID4+IC0tLSBhL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlh LHRlZ3JhMzAtbWMueWFtbAo+ID4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMzAtbWMueWFtbAo+ID4+IEBAIC01 Nyw2ICs1Nyw5IEBAIHByb3BlcnRpZXM6Cj4gPj4gICAgIiNpb21tdS1jZWxscyI6Cj4gPj4gICAg ICBjb25zdDogMQo+ID4+ICAKPiA+PiArICAiI2ludGVyY29ubmVjdC1jZWxscyI6Cj4gPj4gKyAg ICBjb25zdDogMQo+ID4+ICsKPiA+PiAgcGF0dGVyblByb3BlcnRpZXM6Cj4gPj4gICAgIl5lbWMt dGltaW5ncy1bMC05XSskIjoKPiA+PiAgICAgIHR5cGU6IG9iamVjdAo+ID4+IEBAIC0xMjAsNiAr MTIzLDcgQEAgcmVxdWlyZWQ6Cj4gPj4gICAgLSBjbG9jay1uYW1lcwo+ID4+ICAgIC0gIiNyZXNl dC1jZWxscyIKPiA+PiAgICAtICIjaW9tbXUtY2VsbHMiCj4gPj4gKyAgLSAiI2ludGVyY29ubmVj dC1jZWxscyIKPiA+IAo+ID4gUm9iLAo+ID4gCj4gPiBZb3Ugd2VyZSBmaW5lIHdpdGggYWRkaW5n IGEgbmV3IHJlcXVpcmVkIHByb3BlcnR5IHdoaWNoIGJyZWFrcyBhbGwKPiA+IGV4aXN0aW5nIERU QnM/Cj4gCj4gVGhpcyBpcyBhIHJlcXVpcmVkIHByb3BlcnR5IGZvciB0aGUgbmV3IGJpbmRpbmdz IGFuZCBvcHRpb25hbCBmb3IgdGhlCj4gb2xkZXIuIERvZXMgaXQgcmVhbGx5IG5lZWQgdG8gYmUg bWFkZSBvcHRpb25hbCBpbiB0aGUgYmluZGluZz8KCk1obW0uLi4gdGhhdCdzIGFuIGludGVyZXN0 aW5nIHBvaW50LiBJIGFzc3VtZWQgdGhhdCB0aGUgYmluZGluZ3Mgc2hvdWxkCnJlZmxlY3QgY3Vy cmVudCBzdGF0dXMgb2YgdGhlIEFCSSwgYnV0IEkgY291bGQgaW1hZ2luZSB0aGF0IHlvdSB1cGRh dGUKdGhlIGJpbmRpbmdzIHdoaWxlIGtlZXBpbmcgdGhlIGRyaXZlciB3b3JraW5nIHdpdGggb2xk ZXIgRFRCcy4KCkhvdyBkbyB5b3UgYWN0dWFsbHkgdHJhY2sgdGhlbiB0aGUgQUJJPyBJZiBpbmNv bXBhdGlibGUgY2hhbmdlIGNhbiBiZQphZGRlZCB0byB0aGUgYmluZGluZ3MsIGxhdGVyIGFueW9u ZSBhbnl0aW1lIGNhbiBhbHNvIHVwZGF0ZSB0aGUgZHJpdmVyCnRvIGVuZm9yY2UgdGhlIGJpbmRp bmdzLiBUbyByZXF1aXJlIHN1Y2ggcHJvcGVydHkuCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoK Cj4gCj4gPiBXZXJlIHRoZXNlIGJpbmRpbmdzIG1hcmtlZCBhcyB1bnN0YWJsZT8gVGhlIHBhdGNo c2V0IGRvZXMgbm90IGV2ZW4KPiA+IHNheS9zY3JlYW0gdGhhdCBpdCBicmVha3MgdGhlIEFCSSwg c28gdGhpcyBtaWdodCBiZSBxdWl0ZSBhIHN1cnByaXNlIGZvcgo+ID4gc29tZW9uZS4uLgo+IAo+ IFBsZWFzZSBzZWUgdGVncmFfbWNfaW50ZXJjb25uZWN0X3NldHVwKCkgaW4gIm1lbW9yeTogdGVn cmEtbWM6IEFkZAo+IGludGVyY29ubmVjdCBmcmFtZXdvcmsiIHBhdGNoLCB3aGljaCBjaGVjayBw cmVzZW5jZSBvZiB0aGUgbmV3IElDQyBEVAo+IHByb3BlcnR5LgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK