From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFABC55179 for ; Thu, 29 Oct 2020 00:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 049C420791 for ; Thu, 29 Oct 2020 00:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w3iZHgAD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728426AbgJ2Ac5 (ORCPT ); Wed, 28 Oct 2020 20:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733169AbgJ1WXW (ORCPT ); Wed, 28 Oct 2020 18:23:22 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98299C0613D2 for ; Wed, 28 Oct 2020 15:23:22 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id de3so579926qvb.5 for ; Wed, 28 Oct 2020 15:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=q3HZdrGNxCI/rwL2bJs+sG1c4DmY7gX64VUv8zPGJp0=; b=w3iZHgADd5v9U6zAOB8D+M8MEqnphniRW2Jy/fJCVN1kcqPClAO4LvMLqXOn07ZoLx ghyYw4tbLkd4ZLpFJ5yYzeB2FBTJQOSqLMu+eu0MDJFJ1PQQMIkmn0b06suSVU6pNGV6 uV39iGdCd3/RgcBjaecMILewDPwDqHInv8BvhYSJukEtH5w8pUdZPPy3QYGUUlq8TXYX hViJ47ZuJPB3vTAc/INXSEvHVjOHsgy8am405mFyVp6YQXoavgdc2s31XtRWYPbONypI 78PXWgfQYCOgG1JQeffggPKb8W+MjeWpY6LcpiSzsV3ffNOzQEzvrZzoRDJygvKe4ngM kzKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=q3HZdrGNxCI/rwL2bJs+sG1c4DmY7gX64VUv8zPGJp0=; b=INhliHcQqGp/5iM6UrPIARAnSQY+dmr8gdJ/4Iucgck2wcbUbosdO7lqKelW8srzlu eR5nKX374CgVn2R8Sv/Ct+pzdPSo5E2x3iZ0K8sQE0c9ZGPsOOgWeLkH6mKZqTIMmWYH F1bYGeDXHLFbzlh4xxEp+kaSyvUmGozXcM/1apUwynNcVGyDPy0ncFFCVCs3Z6dQEEbU vCHv45hDss0uBNYrfgx7helj6P5pqvspFkjSz3F020A0gulva0KAf5C71KUa1gncK0rD 4vRYHfnk+l4UrX8/s8Bt6Y3395laOyrxH43b3gi27xpXefif5LJr3tDgALtSlog/JUNW KKvQ== X-Gm-Message-State: AOAM530NRE+j/Wbq2zX2g4DQ4R+efLjTra8M7jo1dhoG/m71math7YA2 QG+p8lJ102UPhZ3arp4u7sUdmgJCZ9czEg== X-Google-Smtp-Source: ABdhPJx3bloTJFrm0fb9VkDA3VdvEPdnyGyj3MWhkAqG7wE90ovxnS/KcE9dbBFeor/v06ApPv/DnQ== X-Received: by 2002:a05:6a00:2cf:b029:160:c0c:a95c with SMTP id b15-20020a056a0002cfb02901600c0ca95cmr5587882pft.76.1603857803605; Tue, 27 Oct 2020 21:03:23 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id kk14sm3187829pjb.47.2020.10.27.21.03.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2020 21:03:22 -0700 (PDT) Date: Wed, 28 Oct 2020 09:33:20 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 46/52] opp: Put interconnect paths outside of opp_table_lock Message-ID: <20201028040320.4nobxzudy3fuwmms@vireshk-i7> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-47-digetx@gmail.com> <20201027051013.5gr4s3wuuwxsd7ax@vireshk-i7> <44169d24-4afc-5388-788f-d1e8263fc627@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <44169d24-4afc-5388-788f-d1e8263fc627@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 27-10-20, 23:26, Dmitry Osipenko wrote: > 27.10.2020 08:10, Viresh Kumar пишет: > > On 26-10-20, 01:17, Dmitry Osipenko wrote: > >> This patch fixes lockup which happens when OPP table is released if > >> interconnect provider uses OPP in the icc_provider->set() callback > >> and bandwidth of the ICC path is set to 0 by the ICC core when path > >> is released. The icc_put() doesn't need the opp_table_lock protection, > >> hence let's move it outside of the lock in order to resolve the problem. > >> > >> In particular this fixes tegra-devfreq driver lockup on trying to unload > >> the driver module. The devfreq driver uses OPP-bandwidth API and its ICC > >> provider also uses OPP for DVFS, hence they both take same opp_table_lock > >> when OPP table of the devfreq is released. > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > ... > > > > Never make such _fixes_ part of such a big patchset. Always send them > > separately. > > Perhaps it's not obvious from the commit description that this patch > doesn't fix any known problems of the current mainline kernel and it's > needed only for the new patches. No, I understood that we started getting the warning now only after some other patches of yours. Nevertheless, it should be considered as a fix only as that generated lockdep because of locking placement. And so sending such stuff separately is better as that allows people to apply it fast. > > Having said that, I already have a patch with me which shall fix it for you as > > well: > > I see that yours fix is already applied, thanks! I hope it worked for you. Thanks. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E68C4363A for ; Wed, 28 Oct 2020 08:06:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AABA222447 for ; Wed, 28 Oct 2020 08:06:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w3iZHgAD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AABA222447 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77BA589EA9; Wed, 28 Oct 2020 08:06:31 +0000 (UTC) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 027956E03E for ; Wed, 28 Oct 2020 04:03:23 +0000 (UTC) Received: by mail-pf1-x443.google.com with SMTP id 10so2159034pfp.5 for ; Tue, 27 Oct 2020 21:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=q3HZdrGNxCI/rwL2bJs+sG1c4DmY7gX64VUv8zPGJp0=; b=w3iZHgADd5v9U6zAOB8D+M8MEqnphniRW2Jy/fJCVN1kcqPClAO4LvMLqXOn07ZoLx ghyYw4tbLkd4ZLpFJ5yYzeB2FBTJQOSqLMu+eu0MDJFJ1PQQMIkmn0b06suSVU6pNGV6 uV39iGdCd3/RgcBjaecMILewDPwDqHInv8BvhYSJukEtH5w8pUdZPPy3QYGUUlq8TXYX hViJ47ZuJPB3vTAc/INXSEvHVjOHsgy8am405mFyVp6YQXoavgdc2s31XtRWYPbONypI 78PXWgfQYCOgG1JQeffggPKb8W+MjeWpY6LcpiSzsV3ffNOzQEzvrZzoRDJygvKe4ngM kzKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=q3HZdrGNxCI/rwL2bJs+sG1c4DmY7gX64VUv8zPGJp0=; b=j207olx1nq5ko1JnzfaSjLf/0IGXfFVbUpUAXEo3iMuXVr0HDKeh8nAks6LzWN+OPH 6iQ5A6tdI8A9u9KJECegO4X6C6mweic0eqL2huEfU+8XkXMbJpkq4/+gsG9gwGEoK6VV F2KkK2OqcmV3lQDHV6abIioQhqGd1pin3bFzdiBlwckC0z78cBuhykx6YBnkgw3PkVMv PuSsvuvbINmVwpetbNxPsCYo0e29Npa/BagYfdeFc1M4+XWaGdacsH1vuCqXbaSH2E+c EufawZL0yAY3bdkDAfylntZ4Lve3tZaQvzyGQ3acDH/h7ME2wyeaf5peUUEr+ZTIhc3Z NooA== X-Gm-Message-State: AOAM532bnkH5CMXLVyT7YpuQlUKTxg2Tnm0X/9K97oZrIWbk/3MG9fIf 7qh/ly22/nSYXoAAi1oYNryVag== X-Google-Smtp-Source: ABdhPJx3bloTJFrm0fb9VkDA3VdvEPdnyGyj3MWhkAqG7wE90ovxnS/KcE9dbBFeor/v06ApPv/DnQ== X-Received: by 2002:a05:6a00:2cf:b029:160:c0c:a95c with SMTP id b15-20020a056a0002cfb02901600c0ca95cmr5587882pft.76.1603857803605; Tue, 27 Oct 2020 21:03:23 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id kk14sm3187829pjb.47.2020.10.27.21.03.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2020 21:03:22 -0700 (PDT) Date: Wed, 28 Oct 2020 09:33:20 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v6 46/52] opp: Put interconnect paths outside of opp_table_lock Message-ID: <20201028040320.4nobxzudy3fuwmms@vireshk-i7> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-47-digetx@gmail.com> <20201027051013.5gr4s3wuuwxsd7ax@vireshk-i7> <44169d24-4afc-5388-788f-d1e8263fc627@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <44169d24-4afc-5388-788f-d1e8263fc627@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Wed, 28 Oct 2020 08:06:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Krzysztof Kozlowski , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjctMTAtMjAsIDIzOjI2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjcuMTAuMjAyMCAw ODoxMCwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBPbiAyNi0xMC0yMCwgMDE6MTcsIERt aXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiBUaGlzIHBhdGNoIGZpeGVzIGxvY2t1cCB3aGljaCBo YXBwZW5zIHdoZW4gT1BQIHRhYmxlIGlzIHJlbGVhc2VkIGlmCj4gPj4gaW50ZXJjb25uZWN0IHBy b3ZpZGVyIHVzZXMgT1BQIGluIHRoZSBpY2NfcHJvdmlkZXItPnNldCgpIGNhbGxiYWNrCj4gPj4g YW5kIGJhbmR3aWR0aCBvZiB0aGUgSUNDIHBhdGggaXMgc2V0IHRvIDAgYnkgdGhlIElDQyBjb3Jl IHdoZW4gcGF0aAo+ID4+IGlzIHJlbGVhc2VkLiBUaGUgaWNjX3B1dCgpIGRvZXNuJ3QgbmVlZCB0 aGUgb3BwX3RhYmxlX2xvY2sgcHJvdGVjdGlvbiwKPiA+PiBoZW5jZSBsZXQncyBtb3ZlIGl0IG91 dHNpZGUgb2YgdGhlIGxvY2sgaW4gb3JkZXIgdG8gcmVzb2x2ZSB0aGUgcHJvYmxlbS4KPiA+Pgo+ ID4+IEluIHBhcnRpY3VsYXIgdGhpcyBmaXhlcyB0ZWdyYS1kZXZmcmVxIGRyaXZlciBsb2NrdXAg b24gdHJ5aW5nIHRvIHVubG9hZAo+ID4+IHRoZSBkcml2ZXIgbW9kdWxlLiBUaGUgZGV2ZnJlcSBk cml2ZXIgdXNlcyBPUFAtYmFuZHdpZHRoIEFQSSBhbmQgaXRzIElDQwo+ID4+IHByb3ZpZGVyIGFs c28gdXNlcyBPUFAgZm9yIERWRlMsIGhlbmNlIHRoZXkgYm90aCB0YWtlIHNhbWUgb3BwX3RhYmxl X2xvY2sKPiA+PiB3aGVuIE9QUCB0YWJsZSBvZiB0aGUgZGV2ZnJlcSBpcyByZWxlYXNlZC4KPiA+ Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4K PiA+PiAtLS0KPiAuLi4KPiA+IAo+ID4gTmV2ZXIgbWFrZSBzdWNoIF9maXhlc18gcGFydCBvZiBz dWNoIGEgYmlnIHBhdGNoc2V0LiBBbHdheXMgc2VuZCB0aGVtCj4gPiBzZXBhcmF0ZWx5Lgo+IAo+ IFBlcmhhcHMgaXQncyBub3Qgb2J2aW91cyBmcm9tIHRoZSBjb21taXQgZGVzY3JpcHRpb24gdGhh dCB0aGlzIHBhdGNoCj4gZG9lc24ndCBmaXggYW55IGtub3duIHByb2JsZW1zIG9mIHRoZSBjdXJy ZW50IG1haW5saW5lIGtlcm5lbCBhbmQgaXQncwo+IG5lZWRlZCBvbmx5IGZvciB0aGUgbmV3IHBh dGNoZXMuCgpObywgSSB1bmRlcnN0b29kIHRoYXQgd2Ugc3RhcnRlZCBnZXR0aW5nIHRoZSB3YXJu aW5nIG5vdyBvbmx5IGFmdGVyCnNvbWUgb3RoZXIgcGF0Y2hlcyBvZiB5b3Vycy4gTmV2ZXJ0aGVs ZXNzLCBpdCBzaG91bGQgYmUgY29uc2lkZXJlZCBhcwphIGZpeCBvbmx5IGFzIHRoYXQgZ2VuZXJh dGVkIGxvY2tkZXAgYmVjYXVzZSBvZiBsb2NraW5nIHBsYWNlbWVudC4gQW5kCnNvIHNlbmRpbmcg c3VjaCBzdHVmZiBzZXBhcmF0ZWx5IGlzIGJldHRlciBhcyB0aGF0IGFsbG93cyBwZW9wbGUgdG8K YXBwbHkgaXQgZmFzdC4KCj4gPiBIYXZpbmcgc2FpZCB0aGF0LCBJIGFscmVhZHkgaGF2ZSBhIHBh dGNoIHdpdGggbWUgd2hpY2ggc2hhbGwgZml4IGl0IGZvciB5b3UgYXMKPiA+IHdlbGw6Cj4gCj4g SSBzZWUgdGhhdCB5b3VycyBmaXggaXMgYWxyZWFkeSBhcHBsaWVkLCB0aGFua3MhCgpJIGhvcGUg aXQgd29ya2VkIGZvciB5b3UuIFRoYW5rcy4KCi0tIAp2aXJlc2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==