From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B21FC4363A for ; Wed, 28 Oct 2020 23:23:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89EAA20796 for ; Wed, 28 Oct 2020 23:23:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fU9AFtJP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390411AbgJ1XXN (ORCPT ); Wed, 28 Oct 2020 19:23:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732910AbgJ1XXH (ORCPT ); Wed, 28 Oct 2020 19:23:07 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A4C9C0613CF for ; Wed, 28 Oct 2020 16:23:07 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id p15so1060741ljj.8 for ; Wed, 28 Oct 2020 16:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+6fUclNsrtm5gMXmrEHSQ5gd6ZSjUYsqvc8uCaTtZP0=; b=fU9AFtJP9N9ZrEkU32WW+ZW2hKYhgxdDWveN+vqd0EA9koblqxwLbEL1SGmEJRjgbr A3OclRlUTb68Dr0/FZWDZP8u8/W9vYBAjQXLNsl4QN5NaDo279ETxSQ72fIkwo7lOw+m JBHli4x7ihkigeBqgyY6l2oeWmRE3yXwlWvyIiUkYPmxyLl7LgToDG0Tlleff8ZCQD+/ giA0UimlRXh8AzOxecDoMDnFTjfPEFu92uteMrHOyGq60Y2UXDMoPQsPTmnNH5GpqF9T FgK+aRg6lASTLTqTFixV3a5kHSIZXUfi3hgpLRX+pOxOHyeNzovThMTEz3lBq8QeU0iN Dwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+6fUclNsrtm5gMXmrEHSQ5gd6ZSjUYsqvc8uCaTtZP0=; b=HowYJfosgOJMJVXDCN5MNqwoRJLXnr5Qud1/n0+x+aAbkd1fiQqyF6TLxE46ungi1a ir2AKZ/sZiHy0mWJOVMzL9y2R3kvqLZQyhrQmF3Va76flyFXrpNlT7y1gzZ33j/4gP7f HymME1niYEI58rCFgvMS2Ai41ripdU0G0qe97N8d0HspakcT/jGpbPlmWa8XgPVGiyNj Y8E2t9W5zfIrQNfIlj//CjJ6Sp6pRkJvtCEF7iJ35MEv9x6oBxp0dakqEbfBexPOk/6G ILjd/ebeBoLCksC50svOqdQYa2hjvm7Og6jSvBUFFsFOwJ1ISoS2wpe6rIPCE+04VYyv 1m7A== X-Gm-Message-State: AOAM532s3/obIcrh1UoyxHkMSZ9s2PN4JxJFnw+6D4SxHVzEvpRe1HNJ jggiNCmE5zn9GYSaNR3Hjiy1+pK4ZRU= X-Google-Smtp-Source: ABdhPJx7nHQSeOffaFW7QGp1T0qmSUpnn1BwR3U0hx5uKJ38CFWJ/R5YTJQOq4Nu6fLxSIqc/y3Qhg== X-Received: by 2002:a17:906:1804:: with SMTP id v4mr5876544eje.201.1603860154714; Tue, 27 Oct 2020 21:42:34 -0700 (PDT) Received: from ltop.local ([2a02:a03f:b7fe:f700:14ec:85cd:eb33:2a5c]) by smtp.gmail.com with ESMTPSA id v14sm2104156ejh.6.2020.10.27.21.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 21:42:34 -0700 (PDT) Date: Wed, 28 Oct 2020 05:42:32 +0100 From: Luc Van Oostenryck To: Greg KH Cc: Muhammad Usama Anjum , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e, rtl8192u: use correct notation to define pointer Message-ID: <20201028044232.qtzsnrrh7xgdzsoc@ltop.local> References: <20201026121435.GA782465@LEGION> <20201027112303.GA405023@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027112303.GA405023@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 12:23:03PM +0100, Greg KH wrote: > > Are you sure these changes are correct? This isn't just a list of > structures after this at the end of the structure? > > Please look at commit 5979afa2c4d1 ("staging: Replace zero-length array > with flexible-array member") which made most of these flexible arrays. > > This is not a pointer, it really is an array, I think sparse is really > wrong here, be careful. Sparse's warning is not about changing the definition of this member as if it was the argument of a function. It's about how can you use an array of structure when this structure has a flexible member. It's a recent warning, added purposely to catch this. See https://lore.kernel.org/r/CAHk-=wgJZ05ap8VQdzWDWJVWVtZiOYTc6cnNB8gNeQzEnfm-tw@mail.gmail.com -- Luc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=BAYES_20,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6BEC388F7 for ; Wed, 28 Oct 2020 04:42:40 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED3D32076A for ; Wed, 28 Oct 2020 04:42:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fU9AFtJP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED3D32076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4A6F88691A; Wed, 28 Oct 2020 04:42:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ZRm3m7QUV9q; Wed, 28 Oct 2020 04:42:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id C57978692E; Wed, 28 Oct 2020 04:42:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 33C051BF39C for ; Wed, 28 Oct 2020 04:42:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2986F8731A for ; Wed, 28 Oct 2020 04:42:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z1Tiru1W6uEa for ; Wed, 28 Oct 2020 04:42:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by hemlock.osuosl.org (Postfix) with ESMTPS id 4CF3987311 for ; Wed, 28 Oct 2020 04:42:36 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id z5so5329921ejw.7 for ; Tue, 27 Oct 2020 21:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+6fUclNsrtm5gMXmrEHSQ5gd6ZSjUYsqvc8uCaTtZP0=; b=fU9AFtJP9N9ZrEkU32WW+ZW2hKYhgxdDWveN+vqd0EA9koblqxwLbEL1SGmEJRjgbr A3OclRlUTb68Dr0/FZWDZP8u8/W9vYBAjQXLNsl4QN5NaDo279ETxSQ72fIkwo7lOw+m JBHli4x7ihkigeBqgyY6l2oeWmRE3yXwlWvyIiUkYPmxyLl7LgToDG0Tlleff8ZCQD+/ giA0UimlRXh8AzOxecDoMDnFTjfPEFu92uteMrHOyGq60Y2UXDMoPQsPTmnNH5GpqF9T FgK+aRg6lASTLTqTFixV3a5kHSIZXUfi3hgpLRX+pOxOHyeNzovThMTEz3lBq8QeU0iN Dwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+6fUclNsrtm5gMXmrEHSQ5gd6ZSjUYsqvc8uCaTtZP0=; b=J/YYAdEt80RYOezdy9cPPU0uFKbg2+30HPYTuaTblQgiRt+vvnX2c6J3F6AL2Ra/p7 xDnYMULj8Dd/7bFrtm201W9E9Qxez4HLO26JiB5fV3y8VP6ezPGw/u4jc3RLIIFrcq2i bXrNMMhll1hmjJZZkthXt6hFTtQewWpoHmsOBhHAUzngx/cUSnt0IdZZd9lPKQo75I+M SPrUuKkkQMoShmEMZ3vrEB72LrIu3E5himWadHrn68vYoSbLqSpiNggfYpqPw6W1BXtf tAVmbz6ivtS9Qyk7wtCP37K1A1Wa5Myza7s/53u0qVIB7g8f+M715KQHXaiTWqExcAYQ hpKg== X-Gm-Message-State: AOAM531+F/TRxIliEV53/hjCxe6Y0yGrH9KgNfzryZkcbSTsJqRz/0Gf KRtlbGzj1FshvHczzi4jM1w= X-Google-Smtp-Source: ABdhPJx7nHQSeOffaFW7QGp1T0qmSUpnn1BwR3U0hx5uKJ38CFWJ/R5YTJQOq4Nu6fLxSIqc/y3Qhg== X-Received: by 2002:a17:906:1804:: with SMTP id v4mr5876544eje.201.1603860154714; Tue, 27 Oct 2020 21:42:34 -0700 (PDT) Received: from ltop.local ([2a02:a03f:b7fe:f700:14ec:85cd:eb33:2a5c]) by smtp.gmail.com with ESMTPSA id v14sm2104156ejh.6.2020.10.27.21.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 21:42:34 -0700 (PDT) Date: Wed, 28 Oct 2020 05:42:32 +0100 From: Luc Van Oostenryck To: Greg KH Subject: Re: [PATCH] staging: rtl8192e, rtl8192u: use correct notation to define pointer Message-ID: <20201028044232.qtzsnrrh7xgdzsoc@ltop.local> References: <20201026121435.GA782465@LEGION> <20201027112303.GA405023@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027112303.GA405023@kroah.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Muhammad Usama Anjum , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Tue, Oct 27, 2020 at 12:23:03PM +0100, Greg KH wrote: > > Are you sure these changes are correct? This isn't just a list of > structures after this at the end of the structure? > > Please look at commit 5979afa2c4d1 ("staging: Replace zero-length array > with flexible-array member") which made most of these flexible arrays. > > This is not a pointer, it really is an array, I think sparse is really > wrong here, be careful. Sparse's warning is not about changing the definition of this member as if it was the argument of a function. It's about how can you use an array of structure when this structure has a flexible member. It's a recent warning, added purposely to catch this. See https://lore.kernel.org/r/CAHk-=wgJZ05ap8VQdzWDWJVWVtZiOYTc6cnNB8gNeQzEnfm-tw@mail.gmail.com -- Luc _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel