From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ia70=ED=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4B695C4363A
	for <linux-kernel@archiver.kernel.org>; Wed, 28 Oct 2020 22:32:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 055DB20728
	for <linux-kernel@archiver.kernel.org>; Wed, 28 Oct 2020 22:32:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388112AbgJ1Wce (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 28 Oct 2020 18:32:34 -0400
Received: from verein.lst.de ([213.95.11.211]:45343 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2388097AbgJ1Wc2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Oct 2020 18:32:28 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 2A32E68AFE; Wed, 28 Oct 2020 08:12:37 +0100 (CET)
Date:   Wed, 28 Oct 2020 08:12:37 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Pavel Machek <pavel@denx.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 228/264] PM: hibernate: remove the bogus call to
 get_gendisk() in software_resume()
Message-ID: <20201028071236.GA16112@lst.de>
References: <20201027135430.632029009@linuxfoundation.org> <20201027135441.360964081@linuxfoundation.org> <20201028071057.GC8084@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201028071057.GC8084@amd>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 28, 2020 at 08:10:57AM +0100, Pavel Machek wrote:
> This does not fix anything in 4.19, and should not be there.
> 
> It will break resume for people using resumewait option and using
> numeric values, as original changelog explains. Eventually, someone
> will cry regression and we'll have to fix it in the mainline, but no
> need to bring this to -stable, too.

If this code ever gets hit this patch fixes a reference count leak.