From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA609C388F7 for ; Wed, 28 Oct 2020 22:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F5D320704 for ; Wed, 28 Oct 2020 22:23:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VDQN8LNu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732113AbgJ1WXS (ORCPT ); Wed, 28 Oct 2020 18:23:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731746AbgJ1WVp (ORCPT ); Wed, 28 Oct 2020 18:21:45 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95E3EC0613CF for ; Wed, 28 Oct 2020 15:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=llnqtOUD5PjuWZRtuygvRGktMLBxoIHZ8Uu5EwB+W4s=; b=VDQN8LNuMh2lkdSja23JcySLy EK3ZdQshwP15ZezmFQ4KK1Hj6IUtHF1ox0IUVTPdfJnugCZYJLboMH+E6n1KWvrnez9GfCKspNRa2 2dD4McYZCKpdohvK2s3KJU61S15ffJivLBr47a3nH9bNy27Dj8zYbGrMf7lestWWgde+u7B+OrSHa mZbj/1Fh5cm6yBYv/Fv1pxJVQtINQWzjdV40MpOSSMCwF90IkUo8qep2Wy2mfj6P0VtaCiD7uygGP rK9zWweV5BjyUHekQo/FEhhHk3VikuX912O+ZBk6McV5du6jdWphO6tZFq7udADtt23GXSSAZZcLW +qiUhD4bQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52038) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXl4Q-0002o5-8w; Wed, 28 Oct 2020 13:00:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kXl4M-00052p-Pu; Wed, 28 Oct 2020 13:00:50 +0000 Date: Wed, 28 Oct 2020 13:00:50 +0000 From: Russell King - ARM Linux admin To: Ard Biesheuvel Cc: Joel Stanley , Marek Szyprowski , Linux ARM , Linux Samsung SOC , Krzysztof Kozlowski , Linus Walleij , Florian Fainelli , Rob Herring , Nicolas Pitre , =?iso-8859-1?Q?C=E9dric?= Le Goater Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region Message-ID: <20201028130050.GL1551@shell.armlinux.org.uk> References: <20201007083944.27910-1-ardb@kernel.org> <20201007083944.27910-3-ardb@kernel.org> <920965b8-6f87-3f82-9fce-d3051fc543ca@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Oct 28, 2020 at 01:52:48PM +0100, Ard Biesheuvel wrote: > Does this help? > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index bb79e52aeb90..4f355bda872a 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -68,8 +68,8 @@ > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) > > #define FDT_FIXED_BASE UL(0xff800000) > -#define FDT_FIXED_SIZE (2 * PMD_SIZE) > -#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % PMD_SIZE)) > +#define FDT_FIXED_SIZE (2 * SECTION_SIZE) > +#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % SECTION_SIZE)) Is this correct? If the FDT fixed size is 2x, why does FDT_VIRT_ADDR() only work for half of it? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73A1C388F7 for ; Wed, 28 Oct 2020 13:01:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C58F2473A for ; Wed, 28 Oct 2020 13:01:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qyPjUXrM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VDQN8LNu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C58F2473A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=opfAqv9JmeBKKkHaa55Y4/2/nMWgIraeR7YrwPt+LCA=; b=qyPjUXrM/A9GL+j9Sdm6WK3r0 VDFq2Ovk2/9wtO3eAYJ8I0XoCQ1naR6nQ0wmJW5kzU3v+8JBh4sN8GgMw03uDFjAsEDsRSm8bGvWr HQAvUa+43Jg02bbB22BET3rIhRfSOo7avxsNvr0uBgY2VKGRNRxeg/pDC/Pp6NfHZYrCwddBSk+Ed W9hZNm2m40J21VmhF8w1/jODTltPLwMEpP6wCFFbjhJ92EWMTJjB8HmTpv4uHI7h+Nz8viC+l23wd FxBkNyN3BL6iT7Cb9UX+q0+87ZezlwDjIZsldtYOTi40RSxJ8fHSIXuhTqszzqyKV3h1BsJXuLCXZ OWyDPeutw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXl4Y-0006BS-Up; Wed, 28 Oct 2020 13:01:03 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXl4U-00069W-JL for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 13:00:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=llnqtOUD5PjuWZRtuygvRGktMLBxoIHZ8Uu5EwB+W4s=; b=VDQN8LNuMh2lkdSja23JcySLy EK3ZdQshwP15ZezmFQ4KK1Hj6IUtHF1ox0IUVTPdfJnugCZYJLboMH+E6n1KWvrnez9GfCKspNRa2 2dD4McYZCKpdohvK2s3KJU61S15ffJivLBr47a3nH9bNy27Dj8zYbGrMf7lestWWgde+u7B+OrSHa mZbj/1Fh5cm6yBYv/Fv1pxJVQtINQWzjdV40MpOSSMCwF90IkUo8qep2Wy2mfj6P0VtaCiD7uygGP rK9zWweV5BjyUHekQo/FEhhHk3VikuX912O+ZBk6McV5du6jdWphO6tZFq7udADtt23GXSSAZZcLW +qiUhD4bQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52038) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXl4Q-0002o5-8w; Wed, 28 Oct 2020 13:00:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kXl4M-00052p-Pu; Wed, 28 Oct 2020 13:00:50 +0000 Date: Wed, 28 Oct 2020 13:00:50 +0000 From: Russell King - ARM Linux admin To: Ard Biesheuvel Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region Message-ID: <20201028130050.GL1551@shell.armlinux.org.uk> References: <20201007083944.27910-1-ardb@kernel.org> <20201007083944.27910-3-ardb@kernel.org> <920965b8-6f87-3f82-9fce-d3051fc543ca@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_090058_678588_F853AA38 X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Samsung SOC , Nicolas Pitre , Linus Walleij , Krzysztof Kozlowski , Rob Herring , =?iso-8859-1?Q?C=E9dric?= Le Goater , Florian Fainelli , Joel Stanley , Linux ARM , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 01:52:48PM +0100, Ard Biesheuvel wrote: > Does this help? > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index bb79e52aeb90..4f355bda872a 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -68,8 +68,8 @@ > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) > > #define FDT_FIXED_BASE UL(0xff800000) > -#define FDT_FIXED_SIZE (2 * PMD_SIZE) > -#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % PMD_SIZE)) > +#define FDT_FIXED_SIZE (2 * SECTION_SIZE) > +#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % SECTION_SIZE)) Is this correct? If the FDT fixed size is 2x, why does FDT_VIRT_ADDR() only work for half of it? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel