From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E31C4363A for ; Wed, 28 Oct 2020 22:58:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA61E20756 for ; Wed, 28 Oct 2020 22:58:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L860scfc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389886AbgJ1W6I (ORCPT ); Wed, 28 Oct 2020 18:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389674AbgJ1W4g (ORCPT ); Wed, 28 Oct 2020 18:56:36 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04DCC0613CF; Wed, 28 Oct 2020 15:56:35 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id h5so497641vsp.3; Wed, 28 Oct 2020 15:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1W1egpqxhCc2vFNc2hQUMgNWODq/0zt9Ds07G4ofZII=; b=L860scfczkA9wSqGF8yPqs+4WiGw0DM+CJZwafcORwp5SbVMjWFeMq9JVXbLPg2lBV Nid9jh7a/25hDSME6FajktPu2YumoQlg0etsK8T1nAPno57fImnqS1L4uQZFIpa+ugkE 2ff83pu/V2XZ6aEtpzTu/k7VuSkqnJh8WxotME6RYiznbtL8ui5SbhYp1+TMhUk+bgrF LXePUR/BJ4RICmjwsgKuQPaZSGhOyBhHVOqKiwoCCt2UdlydAzUTGVNzMXEWNMknsrXG bzuqU3bUiW9g+uzC8D/AFev1KdPzfFRr1REUicJa80+naRpG7POHETI8mAHvA53V6+Y3 1B6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1W1egpqxhCc2vFNc2hQUMgNWODq/0zt9Ds07G4ofZII=; b=E8kjsypGoE22B4KZ6g4w831gKx8pKHbpS2CzZKQty+49vcviNvdYAPZFBPJNwnTnFH IQp/tXEB/E8mNljTOwZg9gYMIOMEmz8UNmyyF4fL/jaImXlgw/JfTCdLizTkXRhlQJ8k TmXg1g/+06OzOwhhg0GUT4RtCv82WSRZ1eYC7hYNLuLCfs7LggGJsfY/Xw3EJiW8wGO/ PDJ87P6LGZFaP1TY35G/LqLqDeqs3zOxHPr7NSXJSCLhJjuKCZeLCK5gvLNjUOUfaHoc ZnRcm4V5wkl0Zuo3hSo2b7yOORjhoLShH9dQ5/qQ6OkAYqjBjR0/lumB4Zcx34yqLQju SbYA== X-Gm-Message-State: AOAM532xY4v55JYvamy0ikW7ZDwhxNRwp4F5pViB3Wr0UnkIjtIVOoOw F25dKBbJl/nqljVH2WZ9G9bHTVuxBDYjiPeD X-Google-Smtp-Source: ABdhPJwMlV2jZahCPDR0hvozOQvyxC0uu6I4J/KblhnoJWL3KQonuUYAWQkVHMyNCSGBX5ls1W99Ug== X-Received: by 2002:aa7:970f:0:b029:161:ee2d:bb9b with SMTP id a15-20020aa7970f0000b0290161ee2dbb9bmr7492181pfg.63.1603895224531; Wed, 28 Oct 2020 07:27:04 -0700 (PDT) Received: from k5-sbwpb.flets-east.jp (i60-35-254-237.s41.a020.ap.plala.or.jp. [60.35.254.237]) by smtp.gmail.com with ESMTPSA id jy19sm5311663pjb.9.2020.10.28.07.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 07:27:04 -0700 (PDT) From: Tsuchiya Yuto To: Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Maximilian Luz , Andy Shevchenko , verdre@v0yd.nl, Tsuchiya Yuto Subject: [PATCH] mwifiex: pcie: add enable_device_dump module parameter Date: Wed, 28 Oct 2020 23:26:25 +0900 Message-Id: <20201028142625.18642-1-kitakar@gmail.com> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The devicve_dump may take a little bit long time and users may want to disable the dump for daily usage. This commit adds a new module parameter enable_device_dump and disables the device_dump by default. Signed-off-by: Tsuchiya Yuto --- drivers/net/wireless/marvell/mwifiex/pcie.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 6a10ff0377a24..8254e06fb22ce 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -33,6 +33,11 @@ static struct mwifiex_if_ops pcie_ops; +static bool enable_device_dump; +module_param(enable_device_dump, bool, 0644); +MODULE_PARM_DESC(enable_device_dump, + "enable device_dump (default: disabled)"); + static const struct mwifiex_pcie_card_reg mwifiex_reg_8766 = { .cmd_addr_lo = PCIE_SCRATCH_0_REG, .cmd_addr_hi = PCIE_SCRATCH_1_REG, @@ -2938,6 +2943,12 @@ static void mwifiex_pcie_fw_dump(struct mwifiex_adapter *adapter) static void mwifiex_pcie_device_dump_work(struct mwifiex_adapter *adapter) { + if (!enable_device_dump) { + mwifiex_dbg(adapter, MSG, + "device_dump is disabled by module parameter\n"); + return; + } + adapter->devdump_data = vzalloc(MWIFIEX_FW_DUMP_SIZE); if (!adapter->devdump_data) { mwifiex_dbg(adapter, ERROR, -- 2.29.1