From: Maxime Ripard <maxime@cerno.tech>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v3] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init
Date: Wed, 28 Oct 2020 18:44:35 +0100 [thread overview]
Message-ID: <20201028174435.dksz6b7jwabzloxt@gilmour.lan> (raw)
In-Reply-To: <20201020061226.6572-1-dinghao.liu@zju.edu.cn>
On Tue, Oct 20, 2020 at 02:12:26PM +0800, Dinghao Liu wrote:
> When clk_hw_register_fixed_rate_with_accuracy() fails,
> clk_data should be freed. It's the same for the subsequent
> two error paths, but we should also unregister the already
> registered clocks in them.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
kjlu@umn.edu, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [v3] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init
Date: Wed, 28 Oct 2020 18:44:35 +0100 [thread overview]
Message-ID: <20201028174435.dksz6b7jwabzloxt@gilmour.lan> (raw)
In-Reply-To: <20201020061226.6572-1-dinghao.liu@zju.edu.cn>
On Tue, Oct 20, 2020 at 02:12:26PM +0800, Dinghao Liu wrote:
> When clk_hw_register_fixed_rate_with_accuracy() fails,
> clk_data should be freed. It's the same for the subsequent
> two error paths, but we should also unregister the already
> registered clocks in them.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-29 2:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 6:12 [PATCH] [v3] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Dinghao Liu
2020-10-20 6:12 ` Dinghao Liu
2020-10-28 17:44 ` Maxime Ripard [this message]
2020-10-28 17:44 ` Maxime Ripard
2020-10-28 17:52 ` Alexandre Belloni
2020-10-28 17:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028174435.dksz6b7jwabzloxt@gilmour.lan \
--to=maxime@cerno.tech \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.