From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A5BC55179 for ; Thu, 29 Oct 2020 02:01:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E3B52076B for ; Thu, 29 Oct 2020 02:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727777AbgJ2CBF (ORCPT ); Wed, 28 Oct 2020 22:01:05 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46717 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728079AbgJ1Vuv (ORCPT ); Wed, 28 Oct 2020 17:50:51 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 701635C0032; Wed, 28 Oct 2020 13:44:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 28 Oct 2020 13:44:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=2 8qnJnc+eeyqFQKlSstideW9an1PTHl7M5jm4rsFseA=; b=E9jefSgp0MClmUmr5 Yl6QMykUxKlcVWlnSQehrxapW8kDS8aFIR+6hZpVq04YpruAaGepEfCbjkzEbvA0 wlSN9EcRlWHNANE+z7zIOrRtH84oynrjvJhjwXRzIA7leqfHM9A6qN8KyGC/MvbZ 6cRNSdpR7/PbDDkvmvWHt3jB+g8giSfi4aGVX30MAEn/JZIIswaQiy/z6mixjewC CRyqBbM04zKzorDOBdowpzOAjWpkn2CK4Z1r8ssBGlg/iL7fY3mDdipXC2ZB934G TvLlYTqJEegG390ZjeNF7+J/wjGUDoo3A8xhb5uLQqVKFenK4d4ORDJiSmXt6dCy +6GXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=28qnJnc+eeyqFQKlSstideW9an1PTHl7M5jm4rsFs eA=; b=Od+1R2MoOVG5QLp0r/NWqcHrzHxBu4zWHtrVYrWD+TpNWzTxQveoxFl/S 86l3bsueu4RC/RjOoq+nuwuk2UdTlExl1wL9x1vflKrPXk0+5N3NPeFZqIVELjuV PzK9VnTRZBQX+EMMd+DLRKO+i0fKDukX5YocjJ2ojRKtaDSI9dqum5DSg6WGs1MO cv6jVWL1yIQ4ZiPPn9mCMl/sAgh3Ax1ghZjv2vKAG8McknLHj7aKrOkob88SLGpk B4xyZuypxT9J4IzYo8YFrWqrlB9cDRJ+MyODyn0L4kJftFS2mJ53jp6OtuP6gj6j drIHmMB52lhz1os0XQuzfL4XTLHDg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledugddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E00C13280074; Wed, 28 Oct 2020 13:44:36 -0400 (EDT) Date: Wed, 28 Oct 2020 18:44:35 +0100 From: Maxime Ripard To: Dinghao Liu Cc: kjlu@umn.edu, Alessandro Zummo , Alexandre Belloni , Chen-Yu Tsai , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v3] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Message-ID: <20201028174435.dksz6b7jwabzloxt@gilmour.lan> References: <20201020061226.6572-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201020061226.6572-1-dinghao.liu@zju.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2020 at 02:12:26PM +0800, Dinghao Liu wrote: > When clk_hw_register_fixed_rate_with_accuracy() fails, > clk_data should be freed. It's the same for the subsequent > two error paths, but we should also unregister the already > registered clocks in them. >=20 > Signed-off-by: Dinghao Liu Acked-by: Maxime Ripard Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A7C6C388F7 for ; Wed, 28 Oct 2020 17:45:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04876247E4 for ; Wed, 28 Oct 2020 17:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zDr/ryTJ"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="E9jefSgp"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Od+1R2Mo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04876247E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WiVUugPWsnmRh7YHI3FbWG1jSXxiM9mXDFllHKcnVsc=; b=zDr/ryTJWVUCVtUPNbHeIdkbU DXPUO9+xYl5rh/A3BJb/MibM3/mk6r6kekn3uoJb0ydJdWHmSKRXqKLQP9HmG5rsRMHODCdW3UEYw SEQAEfS8+nAPcYnN/hLcvXSf8hcDrTjcMc9zM1uK74c8hYijxvt9KMsfjFw0OMHnkpZvP2wGZDz9U X/0KqjLWW+t2oObd0Kpq7LMKR4LQN0/qm88jWg6t+yfmuAX5Nxj7uFnLkVEIo7KW5fKuu0IKMGmM7 B5rP565mrbmEYkdMsaF2v5NYjRJMKMn2vW8JvbFFV094Yvs65VLjbOSzpx3a8GpJBgCT59yw49LsK GtsZ6zuUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXpV9-00078F-8T; Wed, 28 Oct 2020 17:44:47 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXpV5-00076V-TB for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 17:44:45 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 701635C0032; Wed, 28 Oct 2020 13:44:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 28 Oct 2020 13:44:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=2 8qnJnc+eeyqFQKlSstideW9an1PTHl7M5jm4rsFseA=; b=E9jefSgp0MClmUmr5 Yl6QMykUxKlcVWlnSQehrxapW8kDS8aFIR+6hZpVq04YpruAaGepEfCbjkzEbvA0 wlSN9EcRlWHNANE+z7zIOrRtH84oynrjvJhjwXRzIA7leqfHM9A6qN8KyGC/MvbZ 6cRNSdpR7/PbDDkvmvWHt3jB+g8giSfi4aGVX30MAEn/JZIIswaQiy/z6mixjewC CRyqBbM04zKzorDOBdowpzOAjWpkn2CK4Z1r8ssBGlg/iL7fY3mDdipXC2ZB934G TvLlYTqJEegG390ZjeNF7+J/wjGUDoo3A8xhb5uLQqVKFenK4d4ORDJiSmXt6dCy +6GXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=28qnJnc+eeyqFQKlSstideW9an1PTHl7M5jm4rsFs eA=; b=Od+1R2MoOVG5QLp0r/NWqcHrzHxBu4zWHtrVYrWD+TpNWzTxQveoxFl/S 86l3bsueu4RC/RjOoq+nuwuk2UdTlExl1wL9x1vflKrPXk0+5N3NPeFZqIVELjuV PzK9VnTRZBQX+EMMd+DLRKO+i0fKDukX5YocjJ2ojRKtaDSI9dqum5DSg6WGs1MO cv6jVWL1yIQ4ZiPPn9mCMl/sAgh3Ax1ghZjv2vKAG8McknLHj7aKrOkob88SLGpk B4xyZuypxT9J4IzYo8YFrWqrlB9cDRJ+MyODyn0L4kJftFS2mJ53jp6OtuP6gj6j drIHmMB52lhz1os0XQuzfL4XTLHDg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledugddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E00C13280074; Wed, 28 Oct 2020 13:44:36 -0400 (EDT) Date: Wed, 28 Oct 2020 18:44:35 +0100 From: Maxime Ripard To: Dinghao Liu Subject: Re: [PATCH] [v3] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Message-ID: <20201028174435.dksz6b7jwabzloxt@gilmour.lan> References: <20201020061226.6572-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201020061226.6572-1-dinghao.liu@zju.edu.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_134444_183141_4AE5D59D X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , kjlu@umn.edu, linux-kernel@vger.kernel.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 20, 2020 at 02:12:26PM +0800, Dinghao Liu wrote: > When clk_hw_register_fixed_rate_with_accuracy() fails, > clk_data should be freed. It's the same for the subsequent > two error paths, but we should also unregister the already > registered clocks in them. > > Signed-off-by: Dinghao Liu Acked-by: Maxime Ripard Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel