Re: [PATCH] gpiolib: acpi: Support GpioInt with active_low polarity

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Support GpioInt with active_low polarity
Date: Wed, 28 Oct 2020 20:27:44 +0200	[thread overview]
Message-ID: <20201028182744.GZ4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201028171757.765866-1-ribalda@chromium.org>

On Wed, Oct 28, 2020 at 06:17:57PM +0100, Ricardo Ribalda wrote:
> On the current implementation we only support active_high polarity for
> GpioInt.
> 
> There can be cases where a GPIO has active_low polarity and it is also a
> IRQ source.
> 
> De-couple the irq_polarity and active_low fields instead of re-use it.
> 
> With this patch we support ACPI devices such as:

Is it real device on the market?!

This table is broken. _DSD GPIO active_low is only for GpioIo().

If it is a ChromeBook, please fix the firmware.

> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
> {
>         GpioInt (Edge, ActiveBoth, Exclusive, PullDefault, 0x0000,
>         "\\_SB.PCI0.GPIO", 0x00, ResourceConsumer, ,
>         )
>         {   // Pin list
>                 0x0064
>         }
> })
> Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
> {
>         ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
>         Package (0x01)
>         {
>         Package (0x02)
>         {
>                 "privacy-gpio",
>                 Package (0x04)
>                 {
>                 \_SB.PCI0.XHCI.RHUB.HS07,
>                 Zero,
>                 Zero,
>                 One
>                 }
>         }
>         }
> })

-- 
With Best Regards,
Andy Shevchenko