From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F5DC4363A for ; Wed, 28 Oct 2020 21:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2154246CD for ; Wed, 28 Oct 2020 21:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="JWaTF6lb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbgJ1Vpw (ORCPT ); Wed, 28 Oct 2020 17:45:52 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:43410 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbgJ1Vns (ORCPT ); Wed, 28 Oct 2020 17:43:48 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09SLhaTJ058741; Wed, 28 Oct 2020 16:43:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603921416; bh=rKwBi6lLjjepnpsz5X/9dYoEl9YGuELhyvzjY0sjk3A=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=JWaTF6lbh5Hbhj2kf+cJjx+NqhzDgW+wiExZ4GuLHyty737HA+E8aV8S8F1YJ3ys+ L50g/rUn1E1RKmq8tNSsM0Wxt3yNWYLV+TYXCcfZXz3TP2qEF8n3GY616NGFoYRqf7 bH+qsLjiB82/mXnO6+UgMvsHUXWaQuslSGn962C8= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09SLhaO8122339 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Oct 2020 16:43:36 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 28 Oct 2020 16:43:36 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 28 Oct 2020 16:43:36 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09SLha4b108673; Wed, 28 Oct 2020 16:43:36 -0500 Date: Wed, 28 Oct 2020 16:43:36 -0500 From: Nishanth Menon To: Tero Kristo CC: , , Subject: Re: [PATCH] soc: ti: ti_sci_pm_domains: check for proper args count in xlate Message-ID: <20201028214336.qfwbs46j5x6cpjhr@award> References: <20201028141700.10510-1-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201028141700.10510-1-t-kristo@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16:17-20201028, Tero Kristo wrote: > K2G devices still only use single parameter for power-domains property, > so check for this properly in the driver. Without this, every peripheral > fails to probe resulting in boot failure. > > Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") > Reported-by: Nishanth Menon > Signed-off-by: Tero Kristo > --- > drivers/soc/ti/ti_sci_pm_domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c > index af2126d2b2ff..8afb3f45d263 100644 > --- a/drivers/soc/ti/ti_sci_pm_domains.c > +++ b/drivers/soc/ti/ti_sci_pm_domains.c > @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate( > struct genpd_onecell_data *genpd_data = data; > unsigned int idx = genpdspec->args[0]; > > - if (genpdspec->args_count < 2) > + if (genpdspec->args_count != 1 && genpdspec->args_count != 2) > return ERR_PTR(-EINVAL); > > if (idx >= genpd_data->num_domains) { Thanks Tero. Acked-by: Nishanth Menon Santosh: can we queue this one for 5.10? - I am trying to track and get all platforms booting and functional in 5.10 -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D5F7C388F7 for ; Wed, 28 Oct 2020 21:44:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D70A246CD for ; Wed, 28 Oct 2020 21:44:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OlzUdCC3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="JWaTF6lb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D70A246CD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uQq2Z++TkvLtzy3DwolB0fbn2e9RlPiMr9pd1S9ezVM=; b=OlzUdCC3X/a3vcf6sH/TZmEuU CLHSr5icTR3Noo5/HY3kP+q72uiUb+9Ga7eJTItAFSbhu0XFN9RFR6V6yaRoy8nxz1SlsaD1txIhG u2t3oSS2u8rZL94X8qc1QB+c3hp/Z0xjZ8oS6FyfOIDK2P9uijZ7LZxn6RaGqp/F4AVWRwJZvTvn3 WLFD2eV18/X65tTixIwypw6gnaO+YHIZDGg+C760zLczzxAXavHATCCRIgxRJZ7QKzbpdLS8elD+M bK6DsXVF/mCArP1hGyd4R30dHN4G1LRAV/ztjrNH8dfVekR2qtG6OLljI4zng1EQZJZfUV1cOcQkp fI6stPryA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXtEV-0007wW-BS; Wed, 28 Oct 2020 21:43:51 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXtEK-0007sd-Tp for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 21:43:44 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09SLhaTJ058741; Wed, 28 Oct 2020 16:43:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603921416; bh=rKwBi6lLjjepnpsz5X/9dYoEl9YGuELhyvzjY0sjk3A=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=JWaTF6lbh5Hbhj2kf+cJjx+NqhzDgW+wiExZ4GuLHyty737HA+E8aV8S8F1YJ3ys+ L50g/rUn1E1RKmq8tNSsM0Wxt3yNWYLV+TYXCcfZXz3TP2qEF8n3GY616NGFoYRqf7 bH+qsLjiB82/mXnO6+UgMvsHUXWaQuslSGn962C8= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09SLhaO8122339 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Oct 2020 16:43:36 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 28 Oct 2020 16:43:36 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 28 Oct 2020 16:43:36 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09SLha4b108673; Wed, 28 Oct 2020 16:43:36 -0500 Date: Wed, 28 Oct 2020 16:43:36 -0500 From: Nishanth Menon To: Tero Kristo Subject: Re: [PATCH] soc: ti: ti_sci_pm_domains: check for proper args count in xlate Message-ID: <20201028214336.qfwbs46j5x6cpjhr@award> References: <20201028141700.10510-1-t-kristo@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028141700.10510-1-t-kristo@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_174341_122029_99EF61DD X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ssantosh@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:17-20201028, Tero Kristo wrote: > K2G devices still only use single parameter for power-domains property, > so check for this properly in the driver. Without this, every peripheral > fails to probe resulting in boot failure. > > Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") > Reported-by: Nishanth Menon > Signed-off-by: Tero Kristo > --- > drivers/soc/ti/ti_sci_pm_domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c > index af2126d2b2ff..8afb3f45d263 100644 > --- a/drivers/soc/ti/ti_sci_pm_domains.c > +++ b/drivers/soc/ti/ti_sci_pm_domains.c > @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate( > struct genpd_onecell_data *genpd_data = data; > unsigned int idx = genpdspec->args[0]; > > - if (genpdspec->args_count < 2) > + if (genpdspec->args_count != 1 && genpdspec->args_count != 2) > return ERR_PTR(-EINVAL); > > if (idx >= genpd_data->num_domains) { Thanks Tero. Acked-by: Nishanth Menon Santosh: can we queue this one for 5.10? - I am trying to track and get all platforms booting and functional in 5.10 -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel