From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FBF8C55179 for ; Wed, 28 Oct 2020 22:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0F8824724 for ; Wed, 28 Oct 2020 22:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603922916; bh=yL5J7c1q5ay690O6rsSJuvA1s+2PdZYpho9NQRq8YWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nOr6RbFWavz1VL+XHVlcNZKzS4XlNwL99t5xPXUnvEW6IeJjV1roS6t2fLRV5oUOX 3aEwEwTpK0J8UgefoyumZzw1OIFQH3qFkwRANqqd1ZK8TqUCgAUs16T3utTA10mSJz yRdsEV0kbUmU7DodnDxzdbo4+4QLehTiXKICG9yg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730402AbgJ1WIb (ORCPT ); Wed, 28 Oct 2020 18:08:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730324AbgJ1WI2 (ORCPT ); Wed, 28 Oct 2020 18:08:28 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BE2624724; Wed, 28 Oct 2020 22:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603922907; bh=yL5J7c1q5ay690O6rsSJuvA1s+2PdZYpho9NQRq8YWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XalUGPqlra2XP8lwKDPMvpxskZkdfBM9b/GDI7B3tQ87XeRlSYn9K6j60JPFbqrDz rJg9FXRu3jJX9GoYhgfuaqIqiEfawZMnKChIm24CBR5wLETc8IbY6rflU0IIvN8SMK Xlv5pKee3cw5Nx1VMiUWN7GMGdOnmLcFcN1FRYvA= Date: Wed, 28 Oct 2020 18:08:26 -0400 From: Sasha Levin To: Alan Maguire Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexei Starovoitov Subject: Re: [PATCH 5.8 574/633] selftests/bpf: Fix overflow tests to reflect iter size increase Message-ID: <20201028220826.GB87646@sasha-vm> References: <20201027135522.655719020@linuxfoundation.org> <20201027135549.734594680@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 03:42:10PM +0000, Alan Maguire wrote: >On Tue, 27 Oct 2020, Greg Kroah-Hartman wrote: > >> From: Alan Maguire >> >> [ Upstream commit eb58bbf2e5c7917aa30bf8818761f26bbeeb2290 ] >> >> bpf iter size increase to PAGE_SIZE << 3 means overflow tests assuming >> page size need to be bumped also. >> > >Alexei can correct me if I've got this wrong but I don't believe >it's a stable backport candidate. > >This selftests change should only be relevant when the BPF iterator >size has been bumped up as it was in > >af65320 bpf: Bump iter seq size to support BTF representation of large >data structures > >...so I don't _think_ this commit belongs in stable unless the >above commit is backported also (and unless I'm missing something >I don't see a burning reason to do that currently). > >Backporting this alone will likely induce bpf test failures. >Apologies if the "Fix" in the title was misleading; it should >probably have been "Update" to reflect the fact it's not fixing >an existing bug but rather updating the test to operate correctly >in the context of other changes in the for-next patch series >it was part of. I'll drop it, thanks! -- Thanks, Sasha