Re: [PATCH] opp: Reduce the size of critical section in _opp_table_kref_release()

From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Viresh Kumar <vireshk@kernel.org>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	Rob Clark <robdclark@gmail.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] opp: Reduce the size of critical section in _opp_table_kref_release()
Date: Thu, 29 Oct 2020 09:40:19 +0530	[thread overview]
Message-ID: <20201029041019.xps4dcavkvk6imp5@vireshk-i7> (raw)
In-Reply-To: <160392797572.884498.11353243518476305974@swboyd.mtv.corp.google.com>

On 28-10-20, 16:32, Stephen Boyd wrote:
> Quoting Viresh Kumar (2020-10-27 00:57:06)
> > There is a lot of stuff here which can be done outside of the big
> > opp_table_lock, do that. This helps avoiding few circular dependency
> > lockdeps around debugfs and interconnects.
> > 
> > Reported-by: Rob Clark <robdclark@gmail.com>
> > Reported-by: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> 
> Any Fixes tag?

The circular dependency lockdep appears with 5.11 stuff and so we
don't need to fix it in any of the earlier releases. And so I didn't
wanted to bother with the fixes tag, as the code had been like this
for ever.

> Reviewed-by: Stephen Boyd <sboyd@kernel.org>

Thanks a lot. I was a bit worried about the crazy idea I had to solve
this :)

-- 
viresh