From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC30C2D0A3 for ; Thu, 29 Oct 2020 09:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B49D3206D9 for ; Thu, 29 Oct 2020 09:09:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="jhHChYEG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725923AbgJ2JJA (ORCPT ); Thu, 29 Oct 2020 05:09:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:46456 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbgJ2JIJ (ORCPT ); Thu, 29 Oct 2020 05:08:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603962487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pRfvIcEC60eWRFi87by9E7+LFhlD5mHOp4kKoOmBQUI=; b=jhHChYEGIqkgyrVF2bZZDAP9fShBJKnw5Z76v7XG/lfKacRenW4EL4SRGC/eZd1qasjwS2 cXgAP3eIkMrcSCfouk1jFCJmAe+jJ4WKqCfQbzrt+J4qDoDjNaVak+cdilW0CbujdHb2DS S50daeUjnIvhpfapMjy5qa/SKRtIe58= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A0EDAB2CF; Thu, 29 Oct 2020 09:08:07 +0000 (UTC) Date: Thu, 29 Oct 2020 10:08:06 +0100 From: Michal Hocko To: Muchun Song Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, iamjoonsoo.kim@lge.com, laoar.shao@gmail.com, chris@chrisdown.name, christian.brauner@ubuntu.com, peterz@infradead.org, mingo@kernel.org, keescook@chromium.org, tglx@linutronix.de, esyr@redhat.com, surenb@google.com, areber@redhat.com, elver@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec Message-ID: <20201029090806.GD17500@dhcp22.suse.cz> References: <20201028035013.99711-1-songmuchun@bytedance.com> <20201028035013.99711-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028035013.99711-4-songmuchun@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 28-10-20 11:50:13, Muchun Song wrote: [...] > -struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat) > +static struct lruvec * > +__mem_cgroup_node_lruvec(struct mem_cgroup *memcg, struct pglist_data *pgdat, > + int nid) I thought I have made it clear that this is not a good approach. Please do not repost new version without that being addressed. If there are any questions then feel free to ask for details. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec Date: Thu, 29 Oct 2020 10:08:06 +0100 Message-ID: <20201029090806.GD17500@dhcp22.suse.cz> References: <20201028035013.99711-1-songmuchun@bytedance.com> <20201028035013.99711-4-songmuchun@bytedance.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603962487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pRfvIcEC60eWRFi87by9E7+LFhlD5mHOp4kKoOmBQUI=; b=jhHChYEGIqkgyrVF2bZZDAP9fShBJKnw5Z76v7XG/lfKacRenW4EL4SRGC/eZd1qasjwS2 cXgAP3eIkMrcSCfouk1jFCJmAe+jJ4WKqCfQbzrt+J4qDoDjNaVak+cdilW0CbujdHb2DS S50daeUjnIvhpfapMjy5qa/SKRtIe58= Content-Disposition: inline In-Reply-To: <20201028035013.99711-4-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Muchun Song Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, guro-b10kYP2dOMg@public.gmane.org, iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org, laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org, christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org, peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, esyr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, areber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, elver-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On Wed 28-10-20 11:50:13, Muchun Song wrote: [...] > -struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat) > +static struct lruvec * > +__mem_cgroup_node_lruvec(struct mem_cgroup *memcg, struct pglist_data *pgdat, > + int nid) I thought I have made it clear that this is not a good approach. Please do not repost new version without that being addressed. If there are any questions then feel free to ask for details. -- Michal Hocko SUSE Labs