All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Christoph Hellwig <hch@infradead.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"open list:DMA BUFFER SHARING FRAMEWORK" 
	<linux-media@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races
Date: Thu, 29 Oct 2020 09:28:00 +0000	[thread overview]
Message-ID: <20201029092800.GA494@infradead.org> (raw)
In-Reply-To: <CAKMK7uEV7sQ48w1Dd=WCY1r6LrY+aEq3ASnouOebQoo=Zr=CTQ@mail.gmail.com>

On Thu, Oct 29, 2020 at 10:25:16AM +0100, Daniel Vetter wrote:
> On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > Maybe I'm missing something, but shouldn't follow_pfn be unexported
> > at the end of the series?
> 
> kvm is a legit user and modular afaict. But since you can't use this
> without an mmu_notifier anyway (or digging around in pagetable
> locking), maybe it should be EXPORT_SYMBOL_GPL now at least?

I think it should then take the notifier as an argument even if it isn't
diretly used as a safety check, and get a new name describing it.

EXPORT_SYMBOL_GPL is probably ok for now, but I'm drafting a new
EXPORT_SYMBOL_FOR_MODULE() which will export symbols that can only be
used by one specific module, with kvm being a prime user due to all
the odd exports it requires that aren't really the kernel interface by
any normal means.

WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@infradead.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: linux-s390 <linux-s390@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Christoph Hellwig <hch@infradead.org>,
	Linux MM <linux-mm@kvack.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"open list:DMA BUFFER SHARING FRAMEWORK"
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races
Date: Thu, 29 Oct 2020 09:28:00 +0000	[thread overview]
Message-ID: <20201029092800.GA494@infradead.org> (raw)
In-Reply-To: <CAKMK7uEV7sQ48w1Dd=WCY1r6LrY+aEq3ASnouOebQoo=Zr=CTQ@mail.gmail.com>

On Thu, Oct 29, 2020 at 10:25:16AM +0100, Daniel Vetter wrote:
> On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > Maybe I'm missing something, but shouldn't follow_pfn be unexported
> > at the end of the series?
> 
> kvm is a legit user and modular afaict. But since you can't use this
> without an mmu_notifier anyway (or digging around in pagetable
> locking), maybe it should be EXPORT_SYMBOL_GPL now at least?

I think it should then take the notifier as an argument even if it isn't
diretly used as a safety check, and get a new name describing it.

EXPORT_SYMBOL_GPL is probably ok for now, but I'm drafting a new
EXPORT_SYMBOL_FOR_MODULE() which will export symbols that can only be
used by one specific module, with kvm being a prime user due to all
the odd exports it requires that aren't really the kernel interface by
any normal means.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-29  9:28 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 10:58 Daniel Vetter
2020-10-26 10:58 ` Daniel Vetter
2020-10-26 10:58 ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 01/15] drm/exynos: Stop using frame_vector helpers Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 02/15] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 03/15] misc/habana: Stop using frame_vector helpers Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 04/15] misc/habana: Use FOLL_LONGTERM for userptr Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 05/15] mm/frame-vector: Use FOLL_LONGTERM Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 22:15   ` Tomasz Figa
2020-10-26 22:15     ` Tomasz Figa
2020-10-26 22:15     ` Tomasz Figa
2020-10-26 22:15     ` Tomasz Figa
2020-10-27  8:05     ` Daniel Vetter
2020-10-27  8:05       ` Daniel Vetter
2020-10-27  8:05       ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 06/15] media: videobuf2: Move frame_vector into media subsystem Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 22:03   ` Tomasz Figa
2020-10-26 22:03     ` Tomasz Figa
2020-10-26 22:03     ` Tomasz Figa
2020-10-26 22:03     ` Tomasz Figa
2020-10-26 10:58 ` [PATCH v4 07/15] mm: Close race in generic_access_phys Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 08/15] mm: Add unsafe_follow_pfn Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-29  8:56   ` Christoph Hellwig
2020-10-29  8:56     ` Christoph Hellwig
2020-10-29  9:23     ` Daniel Vetter
2020-10-29  9:23       ` Daniel Vetter
2020-10-29  9:23       ` Daniel Vetter
2020-10-29  9:23       ` Daniel Vetter
2020-10-29  9:23       ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 09/15] media/videbuf1|2: Mark follow_pfn usage as unsafe Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 22:02   ` Tomasz Figa
2020-10-26 22:02     ` Tomasz Figa
2020-10-26 22:02     ` Tomasz Figa
2020-10-26 22:02     ` Tomasz Figa
2020-10-26 10:58 ` [PATCH v4 10/15] vfio/type1: Mark follow_pfn " Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 11/15] PCI: Obey iomem restrictions for procfs mmap Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 12/15] /dev/mem: Only set filp->f_mapping Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 13/15] resource: Move devmem revoke code to resource framework Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 14/15] sysfs: Support zapping of binary attr mmaps Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58 ` [PATCH v4 15/15] PCI: Revoke mappings like devmem Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-26 10:58   ` Daniel Vetter
2020-10-29  8:57 ` [PATCH v4 00/15] follow_pfn and other iomap races Christoph Hellwig
2020-10-29  8:57   ` Christoph Hellwig
2020-10-29  9:25   ` Daniel Vetter
2020-10-29  9:25     ` Daniel Vetter
2020-10-29  9:25     ` Daniel Vetter
2020-10-29  9:25     ` Daniel Vetter
2020-10-29  9:25     ` Daniel Vetter
2020-10-29  9:28     ` Christoph Hellwig [this message]
2020-10-29  9:28       ` Christoph Hellwig
2020-10-29  9:28       ` Christoph Hellwig
2020-10-29  9:38       ` Daniel Vetter
2020-10-29  9:38         ` Daniel Vetter
2020-10-29  9:38         ` Daniel Vetter
2020-10-29  9:38         ` Daniel Vetter
2020-10-29  9:38         ` Daniel Vetter
2020-10-29 10:01         ` Christoph Hellwig
2020-10-29 10:01           ` Christoph Hellwig
2020-10-29 10:01           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029092800.GA494@infradead.org \
    --to=hch@infradead.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --subject='Re: [PATCH v4 00/15] follow_pfn and other iomap races' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.