From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE62BC2D0A3 for ; Thu, 29 Oct 2020 14:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74F192087D for ; Thu, 29 Oct 2020 14:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SEf94aX0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbgJ2Obd (ORCPT ); Thu, 29 Oct 2020 10:31:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbgJ2Obc (ORCPT ); Thu, 29 Oct 2020 10:31:32 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 000DAC0613CF; Thu, 29 Oct 2020 07:31:31 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id b3so2497136pfo.2; Thu, 29 Oct 2020 07:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zRncE1X7mePBiM0SYCp+vTaN/KpzBsiKiLmub/YURAE=; b=SEf94aX0Mj5GFY5YDSKNwqE/utvYYlY/Lb7HeosZov2jgxv2gQHB3CTbmBjqvDh592 TfKaw21L/d/A4cNZgXQjvtwNmYmoklQKHcLt8b1xhhUrKV+oSUInq9YfpNCgm7ltbHRz c87BygMqgwe6068Xf37nzDlWqPRApME11A4xrSLGoyHZOpCmPkOPM5VNtNOKJILCs7m+ fWV543LE9gjRQ1eVzJrGtvwkNk2RvTvL7vjHQasLFaRo7MfXvrfMsoPSiXuchWzD3i7z XjSfFWTwgj57agC4nOh+kf2sSKtXFzqBAxJ78VyXs5lMt3sZnPjDyyZX4pVqF3cQBCiX gqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zRncE1X7mePBiM0SYCp+vTaN/KpzBsiKiLmub/YURAE=; b=typwhz8hXkYe4eU+BBp+ZsS6R0/RHwsOSeW4Rkhx+gciq07FF7IZsz0TqfmASUX+tx u9gC8UrCGiakkvhc6PGvRt/AEG2vdWL0R60HKDk3Gs/NyBqV5T/2quR3+pCCt3l8hQSm EdXOZvm2ywm8OGQE/C46CNIrQ8nvK03NvBEgiZ1np3Chnf6K7Tz9PRcTPA3vuMUnd0fG PeheWe3H7yAuXBhFQnxfpyirN2ur8fEPDoswGs4LzNrW4j2j9GQQqI0NxGeOLG+YWIDr XApfmlApYIdSJbSVv9FS5c1lKahzNrsrttfw/Jc9RxSuEt0AQACZYCvTXodBOLXZI0I4 u0Ag== X-Gm-Message-State: AOAM5338scLrJW8daoOcb5hQA9voWxasrw5vsS6ocaj21pMADGoIsRzI dmyvs9L5VTvJpMIz2h9vND7AN2wMwjVCt0id X-Google-Smtp-Source: ABdhPJwRZiOQswCD21PzvvHuL4m3SzFzRUBfMy3SVA4VkKPRl2cgt7nvK7JiRme9qXLTj03tFUYJPw== X-Received: by 2002:a17:90a:d082:: with SMTP id k2mr39078pju.195.1603981891636; Thu, 29 Oct 2020 07:31:31 -0700 (PDT) Received: from localhost ([2409:8a28:3c42:6840:9efc:e8ff:fef2:1cdc]) by smtp.gmail.com with ESMTPSA id hj11sm13685pjb.55.2020.10.29.07.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 07:31:31 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 29 Oct 2020 22:30:13 +0800 To: Guenter Roeck Cc: Wim Van Sebroeck , Barry Song , "open list:WATCHDOG DEVICE DRIVERS" , "moderated list:ARM/CSR SIRFPRIMA2 MACHINE SUPPORT" , open list Subject: Re: [PATCH 3/3] watchdog: sirfsoc_wdt: remove unnecessary CONFIG_PM_SLEEP Message-ID: <20201029143013.4y4am5z7tw65b43y@Rk> References: <20201029075327.228570-1-coiby.xu@gmail.com> <20201029075327.228570-3-coiby.xu@gmail.com> <41e73435-375f-1865-69ce-462395476258@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <41e73435-375f-1865-69ce-462395476258@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 06:05:21AM -0700, Guenter Roeck wrote: >On 10/29/20 12:53 AM, Coiby Xu wrote: >> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. >> >> Signed-off-by: Coiby Xu >> --- >> drivers/watchdog/sirfsoc_wdt.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/watchdog/sirfsoc_wdt.c b/drivers/watchdog/sirfsoc_wdt.c >> index 734cf2966ecb..dc8341cd7d44 100644 >> --- a/drivers/watchdog/sirfsoc_wdt.c >> +++ b/drivers/watchdog/sirfsoc_wdt.c >> @@ -170,7 +170,6 @@ static int sirfsoc_wdt_probe(struct platform_device *pdev) >> return 0; >> } >> >> -#ifdef CONFIG_PM_SLEEP >> static int sirfsoc_wdt_suspend(struct device *dev) > >And again: __maybe_unused > >I would suggest to test compile the code with CONFIG_PM_SLEEP disabled. I will test it before send v2! Thank you for the feedback! > >> { >> return 0; >> @@ -189,7 +188,6 @@ static int sirfsoc_wdt_resume(struct device *dev) >> >> return 0; >> } >> -#endif >> >> static SIMPLE_DEV_PM_OPS(sirfsoc_wdt_pm_ops, >> sirfsoc_wdt_suspend, sirfsoc_wdt_resume); >> > -- Best regards, Coiby From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F76C4363A for ; Thu, 29 Oct 2020 14:32:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E7C0206A1 for ; Thu, 29 Oct 2020 14:32:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3GrSQvk0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SEf94aX0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E7C0206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lX53xRm9vtYoY6E7mIcMvFidkDHDp0jv/WAwE233CF0=; b=3GrSQvk0v2k5z5EapYROc0YiT zdVyDjrUhgOLbtgvPgWGIIgWxL3ernv/u6OW3+bjUws9FKpQ3ilzaA3qqeKPRYSzSeF7LAGHfEoYf KTpAr5HCl122xOpIa111TLWoTzYew/5DuLddp1SzX0yiqP4gK0F4ZJ3Zqe11xuBYMz8KuqbXpjNIR 6evJX+6pvX/V5LQsB4k/QNnZyi6Q860/v2K1BGxfu4W/EKzKqpG7X5q4Z7q4hS1DCETkFIY5aTTJc 6ytbVutVqkMWzOYLK4etyhADQdqWErznbYrNs5lr1UcyAzFVbqwbdSQd88FzlGO54vp0zmcst9Bd1 45AaXT23w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY8xk-0007XN-Au; Thu, 29 Oct 2020 14:31:36 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY8xh-0007WV-Ld for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 14:31:34 +0000 Received: by mail-pg1-x542.google.com with SMTP id o3so2465418pgr.11 for ; Thu, 29 Oct 2020 07:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zRncE1X7mePBiM0SYCp+vTaN/KpzBsiKiLmub/YURAE=; b=SEf94aX0Mj5GFY5YDSKNwqE/utvYYlY/Lb7HeosZov2jgxv2gQHB3CTbmBjqvDh592 TfKaw21L/d/A4cNZgXQjvtwNmYmoklQKHcLt8b1xhhUrKV+oSUInq9YfpNCgm7ltbHRz c87BygMqgwe6068Xf37nzDlWqPRApME11A4xrSLGoyHZOpCmPkOPM5VNtNOKJILCs7m+ fWV543LE9gjRQ1eVzJrGtvwkNk2RvTvL7vjHQasLFaRo7MfXvrfMsoPSiXuchWzD3i7z XjSfFWTwgj57agC4nOh+kf2sSKtXFzqBAxJ78VyXs5lMt3sZnPjDyyZX4pVqF3cQBCiX gqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zRncE1X7mePBiM0SYCp+vTaN/KpzBsiKiLmub/YURAE=; b=cYCRZ7LXLaTkxXj5KInkq4+9HvnC3kpVuDFqoxgReQCPPf/lK+ybx2q+3IXN7C4/gN Xk5tjtupkK4OYhSeZJtSPdKUp2qcPMy1QL8k/rYt7D19CV8W6vRxuRZqYagvJd2VBA1r Px5mekPIY6kb6E9rdle+lTzHkteJIEkJzGJ05cPdjMdlVTNTgyKsjnscUoR+dkQbexhE dW9zT2LLxyHXn4dL8LTjbIz4SMLORkViNH0aRkdEungDQhcd9bKkK/ttNh9IijqsvLGS Vo07/PN7MjcX49bC1arlPkdLVdPg5A6kuTh1GvZaiP+DCuO6lH0q37cTJxtNVd03TX3a 4D/A== X-Gm-Message-State: AOAM531cjgf5o5Msoo0gHa9lhsISViiIm+wFqx5oov4L0upnnt+dj56k ABlipim30evecawzM892hCc= X-Google-Smtp-Source: ABdhPJwRZiOQswCD21PzvvHuL4m3SzFzRUBfMy3SVA4VkKPRl2cgt7nvK7JiRme9qXLTj03tFUYJPw== X-Received: by 2002:a17:90a:d082:: with SMTP id k2mr39078pju.195.1603981891636; Thu, 29 Oct 2020 07:31:31 -0700 (PDT) Received: from localhost ([2409:8a28:3c42:6840:9efc:e8ff:fef2:1cdc]) by smtp.gmail.com with ESMTPSA id hj11sm13685pjb.55.2020.10.29.07.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 07:31:31 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 29 Oct 2020 22:30:13 +0800 To: Guenter Roeck Subject: Re: [PATCH 3/3] watchdog: sirfsoc_wdt: remove unnecessary CONFIG_PM_SLEEP Message-ID: <20201029143013.4y4am5z7tw65b43y@Rk> References: <20201029075327.228570-1-coiby.xu@gmail.com> <20201029075327.228570-3-coiby.xu@gmail.com> <41e73435-375f-1865-69ce-462395476258@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <41e73435-375f-1865-69ce-462395476258@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_103133_723066_905A52E5 X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Wim Van Sebroeck , "open list:WATCHDOG DEVICE DRIVERS" , "moderated list:ARM/CSR SIRFPRIMA2 MACHINE SUPPORT" , open list Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 29, 2020 at 06:05:21AM -0700, Guenter Roeck wrote: >On 10/29/20 12:53 AM, Coiby Xu wrote: >> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. >> >> Signed-off-by: Coiby Xu >> --- >> drivers/watchdog/sirfsoc_wdt.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/watchdog/sirfsoc_wdt.c b/drivers/watchdog/sirfsoc_wdt.c >> index 734cf2966ecb..dc8341cd7d44 100644 >> --- a/drivers/watchdog/sirfsoc_wdt.c >> +++ b/drivers/watchdog/sirfsoc_wdt.c >> @@ -170,7 +170,6 @@ static int sirfsoc_wdt_probe(struct platform_device *pdev) >> return 0; >> } >> >> -#ifdef CONFIG_PM_SLEEP >> static int sirfsoc_wdt_suspend(struct device *dev) > >And again: __maybe_unused > >I would suggest to test compile the code with CONFIG_PM_SLEEP disabled. I will test it before send v2! Thank you for the feedback! > >> { >> return 0; >> @@ -189,7 +188,6 @@ static int sirfsoc_wdt_resume(struct device *dev) >> >> return 0; >> } >> -#endif >> >> static SIMPLE_DEV_PM_OPS(sirfsoc_wdt_pm_ops, >> sirfsoc_wdt_suspend, sirfsoc_wdt_resume); >> > -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel