From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D9C9C2D0A3 for ; Fri, 30 Oct 2020 01:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A71432054F for ; Fri, 30 Oct 2020 01:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Scy580i0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725379AbgJ3BGC (ORCPT ); Thu, 29 Oct 2020 21:06:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgJ3BGB (ORCPT ); Thu, 29 Oct 2020 21:06:01 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CACC0C0613CF for ; Thu, 29 Oct 2020 18:06:01 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id f38so3797864pgm.2 for ; Thu, 29 Oct 2020 18:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/Z9C0NVtKgSrCKgcBlAxi/Y4cKHhcTsj2/yM6HYHUek=; b=Scy580i0UHzZzXqkHZ4VHpmFPVGSr+3V3z2MUG8IpsUD/qjLEfZ8JPhV3xGmBI8O5S nKAOyE1LZONHVMjhWjEbKmy8oazjr2AtWgkt+e84l5jlPQd5Vt1TIpQhlGFrvZ1G+1xv c0ixxs8HyFBvEv2a+kWFMAOFunX2x3BkNDAmKpi0aQ+Ng7wAZcTqn2lp/V7llEMj3UMj mHWAdosv4SLDfaGDi0JymEAjUr6gCTTBC5hL7NjTDAECcr/lc/thWXohkRy9CE2mqYgo b26ARhCdEolBaX+mfuwNmFcmUbjpMMgez1NElEKbmBcDZKPjZgu8U0so0zPZzA1HM1Ig nGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/Z9C0NVtKgSrCKgcBlAxi/Y4cKHhcTsj2/yM6HYHUek=; b=PXhCsUtpJC1FLM+KabX7Mgbmt2XcyDj0E/JIv8PtNh+Coo1diCD6rBkNFH7MP442YY nKArxOpUgNeJkk/wR1m+cdcA5YCVZA/FmQ9NyAL5iVdkADr5zQf0grKW7n6oBH4lDI0V +Sp7wwaLLsPNggxR2YMDvKCvG9bwy3PYVjasvBPkATPe/QgEtODWTaAX8o7Lan1xgTtB DaSF6ztqEI/xGX9cOEkhgYquBDlZA9hJyQreuSilevWNcrZH2RVC40Oi1eb7igferP7B 0guiBNtmeD5U75RNWsZ0IU0HW+TMAC9oyCKt1ORVPg/wwc21v4NNe6A7DiqZPMPFX54n ppBw== X-Gm-Message-State: AOAM530ii4+63kuzvML2amdgLFBBgotemNUfcEnLQDebQYtj0ACnNhQi vcsAK2hLos5BHvvgjIeHig4= X-Google-Smtp-Source: ABdhPJxtkO5vv4fEW1dhs/ioJMQ6LO5YmjyCnxyFXmyAWrzC544nUV+moYBHMueIozV6ygGy1WrQ2w== X-Received: by 2002:a17:90a:1b6e:: with SMTP id q101mr1895337pjq.79.1604019961245; Thu, 29 Oct 2020 18:06:01 -0700 (PDT) Received: from Ryzen-9-3900X.localdomain (ip68-98-75-144.ph.ph.cox.net. [68.98.75.144]) by smtp.gmail.com with ESMTPSA id u4sm3695189pgu.35.2020.10.29.18.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 18:06:00 -0700 (PDT) Date: Thu, 29 Oct 2020 18:06:00 -0700 From: Nathan Chancellor To: Dong Aisheng Cc: linux-clk@vger.kernel.org, sboyd@kernel.org, mturquette@baylibre.com, linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 03/11] clk: imx: scu: add two cells binding support Message-ID: <20201030010600.GA2760@Ryzen-9-3900X.localdomain> References: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com> <1596009618-25516-4-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596009618-25516-4-git-send-email-aisheng.dong@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, Jul 29, 2020 at 04:00:10PM +0800, Dong Aisheng wrote: > This patch implements the new two cells binding for SCU clocks. > The usage is as follows: > clocks = <&uart0_clk IMX_SC_R_UART_0 IMX_SC_PM_CLK_PER> > > Due to each SCU clock is associated with a power domain, without power > on the domain, the SCU clock can't work. So we create platform devices > for each domain clock respectively and manually attach the required domain > before register the clock devices, then we can register clocks in the > clock platform driver accordingly. > > Note because we do not have power domain info in device tree and the SCU > resource ID is the same for power domain and clock, so we use resource ID > to find power domains. > > Later, we will also use this clock platform driver to support suspend/resume > and runtime pm. > > Cc: Stephen Boyd > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Michael Turquette > Signed-off-by: Dong Aisheng This patch breaks allmodconfig. $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- distclean allmodconfig drivers/clk/imx/ In file included from ./include/linux/device.h:32, from ./include/linux/of_platform.h:9, from drivers/clk/imx/clk-scu.c:11: ./include/linux/device/driver.h:290:1: warning: data definition has no type or storage class 290 | device_initcall(__driver##_init); | ^~~~~~~~~~~~~~~ ./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver' 258 | builtin_driver(__platform_driver, platform_driver_register) | ^~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/device/driver.h:290:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int] 290 | device_initcall(__driver##_init); | ^~~~~~~~~~~~~~~ ./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver' 258 | builtin_driver(__platform_driver, platform_driver_register) | ^~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: warning: parameter names (without types) in function declaration In file included from ./include/linux/device.h:32, from ./include/linux/of_platform.h:9, from drivers/clk/imx/clk-scu.c:11: drivers/clk/imx/clk-scu.c:545:25: warning: 'imx_clk_scu_driver_init' defined but not used [-Wunused-function] 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~ ./include/linux/device/driver.h:286:19: note: in definition of macro 'builtin_driver' 286 | static int __init __driver##_init(void) \ | ^~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:283: drivers/clk/imx/clk-scu.o] Error 1 make[4]: Target '__build' not remade because of errors. make[3]: *** [scripts/Makefile.build:500: drivers/clk/imx] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [scripts/Makefile.build:500: drivers/clk] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1799: drivers] Error 2 make[1]: Target 'drivers/clk/imx/' not remade because of errors. make: *** [Makefile:335: __build_one_by_one] Error 2 make: Target 'distclean' not remade because of errors. make: Target 'allmodconfig' not remade because of errors. make: Target 'drivers/clk/imx/' not remade because of errors. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FEEC4741F for ; Fri, 30 Oct 2020 01:07:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC7D1206FA for ; Fri, 30 Oct 2020 01:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1Mzahqph"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Scy580i0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC7D1206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VuFqCNWWkGtnk0Yg4oJptMsp2un0bHl+vHLhAhLgASI=; b=1MzahqphErdP+VkUwUexCxml4 KkHURFOqGNDDMLr9jrNfl2JX7VyN2AyNdQJFkxOvk+tHzTrrUk7YU+761NA7dSVutDyYvSOtg20kl 25eqs9iotXwTHKUgxSKgfFBP6KiZPws1LQsu2+nU3cJEC8xvJbmE2BGjjorSDsE1ZOQpXpn/cS20f dtWjkbkX5zgm6I45SAjTcpHFxfoTkQATL1sVgkGjyJjkWx8CmP7DyLXAJnb5xEoT+sARoIWRzfl7D Uy/XmJO7U1SgY3RNQtDHGcnOuFdgLUgy9uhQHDbe8IYStnZGqjA3ds+3HLZjJLuo4s5Wns2MgwfkP J+c2KjuUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYIrm-0000oK-Ts; Fri, 30 Oct 2020 01:06:06 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYIrj-0000nQ-HO for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 01:06:05 +0000 Received: by mail-pf1-x441.google.com with SMTP id j18so3855482pfa.0 for ; Thu, 29 Oct 2020 18:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/Z9C0NVtKgSrCKgcBlAxi/Y4cKHhcTsj2/yM6HYHUek=; b=Scy580i0UHzZzXqkHZ4VHpmFPVGSr+3V3z2MUG8IpsUD/qjLEfZ8JPhV3xGmBI8O5S nKAOyE1LZONHVMjhWjEbKmy8oazjr2AtWgkt+e84l5jlPQd5Vt1TIpQhlGFrvZ1G+1xv c0ixxs8HyFBvEv2a+kWFMAOFunX2x3BkNDAmKpi0aQ+Ng7wAZcTqn2lp/V7llEMj3UMj mHWAdosv4SLDfaGDi0JymEAjUr6gCTTBC5hL7NjTDAECcr/lc/thWXohkRy9CE2mqYgo b26ARhCdEolBaX+mfuwNmFcmUbjpMMgez1NElEKbmBcDZKPjZgu8U0so0zPZzA1HM1Ig nGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/Z9C0NVtKgSrCKgcBlAxi/Y4cKHhcTsj2/yM6HYHUek=; b=PawpfvDQTuDwgyH+vJHP+hyBhU0ZtfRMjg1uiPsWfq+vfin/8IH1ak2I5zGj+Roi7B IhInrFFlROXZgpN3k+QNZhLAT4sV8+0uubxC8wVehfXuLoWb/dZOADHsAd6FnILgtDyk pPOe4YkyCmWyK7p/b0nXDUk7mzs8qQ6wRmO6VAVOkJMTzPfV5XhTz9ilKuJVynKXC0JF aHhshMZ599m+y8uW1vndA1MLsEeLN5e/55eMYSh5+fRwAaoNubYD8ccbg/XgO5dpAecR YcvJ10h8CvQms6mAUlTnXt3v2TxUstzj4FZPst8ubtIGX2cClwDh7ZWh+IKpsjRWS9m9 jtsQ== X-Gm-Message-State: AOAM532JLVq1O6FbS7eXyXzi+cH+/JTTor50h68D51zWLTHClHL3pXh/ 6lAjvA4lVD/zHdUhuFZsnawXur4jwESqUg== X-Google-Smtp-Source: ABdhPJxtkO5vv4fEW1dhs/ioJMQ6LO5YmjyCnxyFXmyAWrzC544nUV+moYBHMueIozV6ygGy1WrQ2w== X-Received: by 2002:a17:90a:1b6e:: with SMTP id q101mr1895337pjq.79.1604019961245; Thu, 29 Oct 2020 18:06:01 -0700 (PDT) Received: from Ryzen-9-3900X.localdomain (ip68-98-75-144.ph.ph.cox.net. [68.98.75.144]) by smtp.gmail.com with ESMTPSA id u4sm3695189pgu.35.2020.10.29.18.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 18:06:00 -0700 (PDT) Date: Thu, 29 Oct 2020 18:06:00 -0700 From: Nathan Chancellor To: Dong Aisheng Subject: Re: [PATCH v7 03/11] clk: imx: scu: add two cells binding support Message-ID: <20201030010600.GA2760@Ryzen-9-3900X.localdomain> References: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com> <1596009618-25516-4-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1596009618-25516-4-git-send-email-aisheng.dong@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_210603_620453_FC90E217 X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 29, 2020 at 04:00:10PM +0800, Dong Aisheng wrote: > This patch implements the new two cells binding for SCU clocks. > The usage is as follows: > clocks = <&uart0_clk IMX_SC_R_UART_0 IMX_SC_PM_CLK_PER> > > Due to each SCU clock is associated with a power domain, without power > on the domain, the SCU clock can't work. So we create platform devices > for each domain clock respectively and manually attach the required domain > before register the clock devices, then we can register clocks in the > clock platform driver accordingly. > > Note because we do not have power domain info in device tree and the SCU > resource ID is the same for power domain and clock, so we use resource ID > to find power domains. > > Later, we will also use this clock platform driver to support suspend/resume > and runtime pm. > > Cc: Stephen Boyd > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Michael Turquette > Signed-off-by: Dong Aisheng This patch breaks allmodconfig. $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- distclean allmodconfig drivers/clk/imx/ In file included from ./include/linux/device.h:32, from ./include/linux/of_platform.h:9, from drivers/clk/imx/clk-scu.c:11: ./include/linux/device/driver.h:290:1: warning: data definition has no type or storage class 290 | device_initcall(__driver##_init); | ^~~~~~~~~~~~~~~ ./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver' 258 | builtin_driver(__platform_driver, platform_driver_register) | ^~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/device/driver.h:290:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int] 290 | device_initcall(__driver##_init); | ^~~~~~~~~~~~~~~ ./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver' 258 | builtin_driver(__platform_driver, platform_driver_register) | ^~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: warning: parameter names (without types) in function declaration In file included from ./include/linux/device.h:32, from ./include/linux/of_platform.h:9, from drivers/clk/imx/clk-scu.c:11: drivers/clk/imx/clk-scu.c:545:25: warning: 'imx_clk_scu_driver_init' defined but not used [-Wunused-function] 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~ ./include/linux/device/driver.h:286:19: note: in definition of macro 'builtin_driver' 286 | static int __init __driver##_init(void) \ | ^~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' 545 | builtin_platform_driver(imx_clk_scu_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:283: drivers/clk/imx/clk-scu.o] Error 1 make[4]: Target '__build' not remade because of errors. make[3]: *** [scripts/Makefile.build:500: drivers/clk/imx] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [scripts/Makefile.build:500: drivers/clk] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1799: drivers] Error 2 make[1]: Target 'drivers/clk/imx/' not remade because of errors. make: *** [Makefile:335: __build_one_by_one] Error 2 make: Target 'distclean' not remade because of errors. make: Target 'allmodconfig' not remade because of errors. make: Target 'drivers/clk/imx/' not remade because of errors. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel