All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com,
	kuba@kernel.org, Christian Eggers <ceggers@arri.de>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Per Forlin <per.forlin@axis.com>,
	Oleksij Rempel <linux@rempel-privat.de>
Subject: [PATCH v2 net-next 12/12] net: dsa: tag_ar9331: let DSA core deal with TX reallocation
Date: Fri, 30 Oct 2020 03:49:10 +0200	[thread overview]
Message-ID: <20201030014910.2738809-13-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20201030014910.2738809-1-vladimir.oltean@nxp.com>

Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.

Cc: Per Forlin <per.forlin@axis.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Changes in v2:
None.

 net/dsa/tag_ar9331.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c
index 55b00694cdba..002cf7f952e2 100644
--- a/net/dsa/tag_ar9331.c
+++ b/net/dsa/tag_ar9331.c
@@ -31,9 +31,6 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb,
 	__le16 *phdr;
 	u16 hdr;
 
-	if (skb_cow_head(skb, AR9331_HDR_LEN) < 0)
-		return NULL;
-
 	phdr = skb_push(skb, AR9331_HDR_LEN);
 
 	hdr = FIELD_PREP(AR9331_HDR_VERSION_MASK, AR9331_HDR_VERSION);
-- 
2.25.1


  parent reply	other threads:[~2020-10-30  1:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  1:48 [PATCH v2 net-next 00/12] Generic TX reallocation for DSA Vladimir Oltean
2020-10-30  1:48 ` [PATCH v2 net-next 01/12] net: dsa: implement a central TX reallocation procedure Vladimir Oltean
2020-10-30  6:41   ` Kurt Kanzenbach
2020-11-01  1:00   ` Jakub Kicinski
2020-11-01  1:14     ` Vladimir Oltean
2020-11-01  1:37       ` Vladimir Oltean
2020-11-02 19:57         ` Jakub Kicinski
2020-10-30  1:49 ` [PATCH v2 net-next 02/12] net: dsa: tag_ksz: don't allocate additional memory for padding/tagging Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 03/12] net: dsa: trailer: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 04/12] net: dsa: tag_qca: let DSA core deal with TX reallocation Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 05/12] net: dsa: tag_ocelot: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 06/12] net: dsa: tag_mtk: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 07/12] net: dsa: tag_lan9303: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 08/12] net: dsa: tag_edsa: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 09/12] net: dsa: tag_brcm: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 10/12] net: dsa: tag_dsa: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 11/12] net: dsa: tag_gswip: " Vladimir Oltean
2020-10-30  1:49 ` Vladimir Oltean [this message]
2020-10-30  9:21   ` [PATCH v2 net-next 12/12] net: dsa: tag_ar9331: " Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030014910.2738809-13-vladimir.oltean@nxp.com \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=ceggers@arri.de \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux@rempel-privat.de \
    --cc=netdev@vger.kernel.org \
    --cc=per.forlin@axis.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.