From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 882B3C388F9 for ; Fri, 30 Oct 2020 11:19:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4E3B20756 for ; Fri, 30 Oct 2020 11:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="euF0ILmL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4E3B20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYSRB-00027D-Go for qemu-devel@archiver.kernel.org; Fri, 30 Oct 2020 07:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYSOw-00015C-Vd for qemu-devel@nongnu.org; Fri, 30 Oct 2020 07:16:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kYSOu-0002h0-Oe for qemu-devel@nongnu.org; Fri, 30 Oct 2020 07:16:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604056614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XdftMZGrTyWYnOQxNWpR4KUVyEt4uF+65WREa90OZ6I=; b=euF0ILmL1PlamTv2lyXHTjHNcrKU2unSbc650hf9iRpGjO9tvshQP7tTMg6EI6HXujNmv2 8D07EhlmNli/LBxB8BSXHcJSWEGawD1OY3ooy6Ci6a2kWSp/BOidU9oQSgLnadw6h6cQHZ E2c7tr/DnB925VcfvODcNdssN8gQ6As= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-J5Rt32GXNMCHZqXL5u8uEw-1; Fri, 30 Oct 2020 07:16:49 -0400 X-MC-Unique: J5Rt32GXNMCHZqXL5u8uEw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B2F921006702; Fri, 30 Oct 2020 11:16:47 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id D90BF5B4A1; Fri, 30 Oct 2020 11:16:43 +0000 (UTC) Date: Fri, 30 Oct 2020 07:16:43 -0400 From: Eduardo Habkost To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument Message-ID: <20201030111643.GN5733@habkost.net> References: <20201029220246.472693-1-ehabkost@redhat.com> <20201029220246.472693-13-ehabkost@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/30 02:24:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P. Berrange" , David Hildenbrand , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , QEMU , Markus Armbruster , Halil Pasic , Christian Borntraeger , Qemu-s390x list , Paolo Bonzini , Igor Mammedov , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Oct 30, 2020 at 12:00:33PM +0400, Marc-André Lureau wrote: > On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost wrote: > > > Make the code more generic and not specific to TYPE_DEVICE. > > > > Signed-off-by: Eduardo Habkost > > > > What about dropping _qdev from the function name too? I have a series that deletes the function completely, but I decided to leave it outside of this first batch. > > Also, I am not sure it's a well designed function.. I would rather have 3 > different helper functions than dispatching with an errno... Might be worth > a TODO note :) > > Reviewed-by: Marc-André Lureau Thanks! -- Eduardo