From: Jakub Kicinski <kuba@kernel.org>
To: Camelia Groza <camelia.groza@nxp.com>
Cc: willemdebruijn.kernel@gmail.com, madalin.bucur@oss.nxp.com,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment
Date: Fri, 30 Oct 2020 18:43:47 -0700 [thread overview]
Message-ID: <20201030184347.4a8ad004@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <5b077d5853123db0c8794af1ed061850b94eae37.1603899392.git.camelia.groza@nxp.com>
On Wed, 28 Oct 2020 18:41:00 +0200 Camelia Groza wrote:
> @@ -2842,7 +2842,8 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv *priv)
> return err;
> }
>
> -static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl)
> +static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl,
> + enum port_type port)
Please drop the "inline" while you're touching this definition.
The compiler will make the right inlining decision here.
next prev parent reply other threads:[~2020-10-31 1:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 16:40 [PATCH net v2 0/2] dpaa_eth: buffer layout fixes Camelia Groza
2020-10-28 16:40 ` [PATCH net v2 1/2] dpaa_eth: update the buffer layout for non-A050385 erratum scenarios Camelia Groza
2020-10-31 1:41 ` Jakub Kicinski
2020-11-02 17:08 ` Camelia Alexandra Groza
2020-10-28 16:41 ` [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment Camelia Groza
2020-10-28 20:45 ` Willem de Bruijn
2020-10-31 1:43 ` Jakub Kicinski [this message]
2020-11-02 17:09 ` Camelia Alexandra Groza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030184347.4a8ad004@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.