From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52063C388F7 for ; Sat, 31 Oct 2020 17:04:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08162206B6 for ; Sat, 31 Oct 2020 17:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbgJaREN (ORCPT ); Sat, 31 Oct 2020 13:04:13 -0400 Received: from bmailout1.hostsharing.net ([83.223.95.100]:36349 "EHLO bmailout1.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgJaREN (ORCPT ); Sat, 31 Oct 2020 13:04:13 -0400 X-Greylist: delayed 331 seconds by postgrey-1.27 at vger.kernel.org; Sat, 31 Oct 2020 13:04:12 EDT Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id C69F2300002A5; Sat, 31 Oct 2020 17:58:35 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 1E41F1B55F; Sat, 31 Oct 2020 17:58:36 +0100 (CET) Date: Sat, 31 Oct 2020 17:58:36 +0100 From: Lukas Wunner To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH v2 16/29] dt-bindings:iio:dac:ti,dac082s085 yaml conversion Message-ID: <20201031165836.GA12341@wunner.de> References: <20201031134110.724233-1-jic23@kernel.org> <20201031134110.724233-17-jic23@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031134110.724233-17-jic23@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Oct 31, 2020 at 01:40:57PM +0000, Jonathan Cameron wrote: > + spi-cpha: true > + spi-cpol: > + description: > + Should be either spi-cpha, or spi-cpol but not both. Do the YAML files follow RFC 2119 terminology? If so, this is a "must", not a "should". (As it was in the txt file.) > +required: > + - compatible > + - reg > + - vref-supply This is missing "spi-cpha xor spi-cpol", not sure if it can be specified here using the xor YAML trick. Thanks, Lukas