From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47ABC4741F for ; Sun, 1 Nov 2020 12:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9166D2085B for ; Sun, 1 Nov 2020 12:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726588AbgKAM3F (ORCPT ); Sun, 1 Nov 2020 07:29:05 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:48760 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgKAM3F (ORCPT ); Sun, 1 Nov 2020 07:29:05 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 39B0020022; Sun, 1 Nov 2020 13:29:02 +0100 (CET) Date: Sun, 1 Nov 2020 13:29:00 +0100 From: Sam Ravnborg To: Paul Cercueil Cc: Thierry Reding , Rob Herring , Christophe Branchereau , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings Message-ID: <20201101122900.GB1269759@ravnborg.org> References: <20201101093150.8071-1-paul@crapouillou.net> <20201101093150.8071-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101093150.8071-3-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=gEfo2CItAAAA:8 a=Lqvclo0UE7ZJoC8b96MA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=sptkURWiP4Gy88Gu7hUp:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote: > The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" 320x480 > 24-bit IPS LCD panel. Its particularity is that it has non-square pixels > (as it is 4:3 for a resolution of 320x480), and that it requires odd > lines to be sent as RGB and even lines to be sent as GRB on its 8-bit > bus. > > Signed-off-by: Paul Cercueil > --- > .../display/panel/abt,y030xx067a.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > new file mode 100644 > index 000000000000..6407e8bf45fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS LCD panel > + > +description: | > + The panel must obey the rules for a SPI slave device as specified in > + spi/spi-controller.yaml > + > +maintainers: > + - Paul Cercueil > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: abt,y030xx067a > + > + backlight: true > + port: true > + power-supply: true > + reg: true > + reset-gpios: true The binding is missing: required: - compatible - reg - power-supply - reset-gpios - ... additionalProperties: false So r-b only with these added. Sam > + > +examples: > + - | > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "abt,y030xx067a"; > + reg = <0>; > + > + spi-max-frequency = <3125000>; > + > + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>; > + > + backlight = <&backlight>; > + power-supply = <&vcc>; > + > + port { > + panel_input: endpoint { > + remote-endpoint = <&panel_output>; > + }; > + }; > + }; > + }; > -- > 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DFAC55178 for ; Sun, 1 Nov 2020 12:29:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13ED42085B for ; Sun, 1 Nov 2020 12:29:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13ED42085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3165A6EAAC; Sun, 1 Nov 2020 12:29:05 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 257B66EAAC for ; Sun, 1 Nov 2020 12:29:04 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 39B0020022; Sun, 1 Nov 2020 13:29:02 +0100 (CET) Date: Sun, 1 Nov 2020 13:29:00 +0100 From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings Message-ID: <20201101122900.GB1269759@ravnborg.org> References: <20201101093150.8071-1-paul@crapouillou.net> <20201101093150.8071-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201101093150.8071-3-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=gEfo2CItAAAA:8 a=Lqvclo0UE7ZJoC8b96MA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=sptkURWiP4Gy88Gu7hUp:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding , Christophe Branchereau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote: > The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" 320x480 > 24-bit IPS LCD panel. Its particularity is that it has non-square pixels > (as it is 4:3 for a resolution of 320x480), and that it requires odd > lines to be sent as RGB and even lines to be sent as GRB on its 8-bit > bus. > > Signed-off-by: Paul Cercueil > --- > .../display/panel/abt,y030xx067a.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > new file mode 100644 > index 000000000000..6407e8bf45fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS LCD panel > + > +description: | > + The panel must obey the rules for a SPI slave device as specified in > + spi/spi-controller.yaml > + > +maintainers: > + - Paul Cercueil > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: abt,y030xx067a > + > + backlight: true > + port: true > + power-supply: true > + reg: true > + reset-gpios: true The binding is missing: required: - compatible - reg - power-supply - reset-gpios - ... additionalProperties: false So r-b only with these added. Sam > + > +examples: > + - | > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "abt,y030xx067a"; > + reg = <0>; > + > + spi-max-frequency = <3125000>; > + > + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>; > + > + backlight = <&backlight>; > + power-supply = <&vcc>; > + > + port { > + panel_input: endpoint { > + remote-endpoint = <&panel_output>; > + }; > + }; > + }; > + }; > -- > 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel