From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C99C2D0A3 for ; Sun, 1 Nov 2020 23:18:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C21752225C for ; Sun, 1 Nov 2020 23:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bShCDDRM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbgKAXSu (ORCPT ); Sun, 1 Nov 2020 18:18:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbgKAXSt (ORCPT ); Sun, 1 Nov 2020 18:18:49 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3E9EC0617A6; Sun, 1 Nov 2020 15:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=sTRhwwuh1Zi6sB1NgYlq0oaV8WSpgNbpK9CTGiqites=; b=bShCDDRMagDMtiIg9n2RukkblC lMZwCm7Mph2tFZz5AON9zyvYnvxJt07OJfqLx9W8yqV/BX5lRi7xmWlxYe+8wRYCr4g86r6ZPnXKP riAqMdmZYZ+ye/OiJ7f2RIyvDPtx962AhjPb54Kn0NGYVBHkHvFhFuzdj0bikzeVoR8GbM1/RufRU tBLryRAaatuMVO11GkVJ1SgK4iaQ3YefrUiv7FGN8v3EfxBwAub8t0iEsl7bRNnh6wCHs6ySqyBnz PVZMsCaSB9ocOByF8DQcYrwzMtT8PRgPq1Z0okNQNyWJt7AH1rHUyBxh7VaG2kMLvyZALk97lC/F5 bT6E50HQ==; Received: from [2601:1c0:6280:3f0::60d5] (helo=smtpauth.infradead.org) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZMcT-000296-CB; Sun, 01 Nov 2020 23:18:42 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , David Howells , Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Andrew Morton , Stephen Rothwell Subject: [PATCH v2] asm-generic: barrier.h: fix ALPHA builds when SMP is not enabled Date: Sun, 1 Nov 2020 15:18:35 -0800 Message-Id: <20201101231835.4589-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org uses barrier() but needs to #include to get a generic definition of it to fix build errors in arch/alpha/ builds when CONFIG_SMP is not enabled. Fixes build errors like this (there are several like this): [49 in the kernel config that was supplied by the 0day bot] In file included from ../arch/alpha/include/asm/barrier.h:21, from ../arch/alpha/include/asm/atomic.h:6, from ../include/linux/atomic.h:7, from ../include/linux/dcache.h:5, from ../fs/proc/util.c:1: ../arch/alpha/include/asm/atomic.h: In function 'atomic_add_return_relaxed': ../include/asm-generic/barrier.h:78:18: error: implicit declaration of function 'barrier' [-Werror=implicit-function-declaration] 78 | #define smp_mb() barrier() | ^~~~~~~ Fixes: 885df91ca357 ("Create asm-generic/barrier.h") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: David Howells Cc: Arnd Bergmann Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: linux-alpha@vger.kernel.org Cc: Andrew Morton Cc: Stephen Rothwell --- v2: also send to Andrew and Stephen. include/asm-generic/barrier.h | 1 + 1 file changed, 1 insertion(+) --- linux-next-20201030.orig/include/asm-generic/barrier.h +++ linux-next-20201030/include/asm-generic/barrier.h @@ -13,6 +13,7 @@ #ifndef __ASSEMBLY__ +#include #include #ifndef nop