From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D709C388F2 for ; Mon, 2 Nov 2020 11:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C42C72231B for ; Mon, 2 Nov 2020 11:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K3mlqsA/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbgKBLFV (ORCPT ); Mon, 2 Nov 2020 06:05:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55720 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728253AbgKBLFV (ORCPT ); Mon, 2 Nov 2020 06:05:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604315119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r+Q0QGef/Chloit35akJAvp2UK5y4+Yr2p6vISWEuwM=; b=K3mlqsA/dkP5D4qaZi6cjFjeil2ud2jZUJhbaka55N8L2QdIg/vDMuebea1xzE/5iJ3kHn GTJjxrU/uuFh7UT4H+xIalfgFoPptvzzgznfwZJ7ZDNIq8391qbNxKP8fPa9kTWxY0nLRV z51Lwgsz+zW0Jaefhrw3budLwDqAiMQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-0ik42Tk4MOiTulEbFFGWFw-1; Mon, 02 Nov 2020 06:05:18 -0500 X-MC-Unique: 0ik42Tk4MOiTulEbFFGWFw-1 Received: by mail-wm1-f70.google.com with SMTP id b68so1755515wme.5 for ; Mon, 02 Nov 2020 03:05:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r+Q0QGef/Chloit35akJAvp2UK5y4+Yr2p6vISWEuwM=; b=Pug4IUtTbxFQ2nQn8xExlD9z6hij0xp4Kfrx4E8JZvUHfZSKV4XqO/4FwKTVbxQDtG xWsaB6lTMmSu99ttrWQAJ0/RuTvtzR1bkQ3NdxzJJQSXhbBjFEB/MZaa93ZiTV60qu0U rLTnEcuaWrZFrtPSy1yAbt1Jd8QQ0HZ5HHP8/ras+pcw4X3ng+XFzETZB2TEtA/MqjhP Vd90T1Pr0slZU4WuqXXNZzrQkZP6zp4H9WX0eSoWUrnIOBFfjbdNc6JlsSTTQ0bVt7m/ GOFu8sy2N5YkBNIhG/OCLgrvF8wv60xIWJ/l5GGktuXuw+/8S76i25+QuJy6+VewWkBT U/KQ== X-Gm-Message-State: AOAM530rxJRlcn436hFLdt5usfN8YBJC0xFB+LBHf6iyCksWgcZNhPWY kgOvanVl95KycNuFrHMhBHWJFKA0CxQ/coze6cmy738COl54nyF3vzewEw2NUotm+adaK11FOJn Szrk4qb+P2h/Wi85wA82v99F6 X-Received: by 2002:a1c:4054:: with SMTP id n81mr12021233wma.48.1604315117006; Mon, 02 Nov 2020 03:05:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmEIqLJMyDiiIjNpv7lb80eabtXHYd5HB0MoVHivQmdUJd1PBVcw8MORSBRsifC7fHtfm/vg== X-Received: by 2002:a1c:4054:: with SMTP id n81mr12021212wma.48.1604315116864; Mon, 02 Nov 2020 03:05:16 -0800 (PST) Received: from redhat.com (bzq-79-181-134-187.red.bezeqint.net. [79.181.134.187]) by smtp.gmail.com with ESMTPSA id y4sm21531180wrp.74.2020.11.02.03.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:05:16 -0800 (PST) Date: Mon, 2 Nov 2020 06:05:12 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: Daniel Vetter , Stephen Rothwell , Intel Graphics , DRI , Christian K??nig , Joerg Roedel , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the drm-misc tree Message-ID: <20201102060422-mutt-send-email-mst@kernel.org> References: <20201102124327.2f82b2a7@canb.auug.org.au> <20201102102711.GA28511@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102102711.GA28511@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2020 at 10:27:11AM +0000, Christoph Hellwig wrote: > On Mon, Nov 02, 2020 at 10:28:34AM +0100, Daniel Vetter wrote: > > > --- a/include/linux/swiotlb.h > > > +++ b/include/linux/swiotlb.h > > > @@ -5,6 +5,9 @@ > > > #include > > > #include > > > #include > > > +#ifndef CONFIG_SWIOTLB > > > +#include > > > +#endif > > No conditional includes please. And the proper fix for the reported > issue is to stop poking into swiotlb internals in random drivers.. Meaning? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC31C56201 for ; Mon, 2 Nov 2020 11:05:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C201A223C6 for ; Mon, 2 Nov 2020 11:05:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KmdpoaMA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C201A223C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F33ED6E4B3; Mon, 2 Nov 2020 11:05:22 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D9356E4AE for ; Mon, 2 Nov 2020 11:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604315120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r+Q0QGef/Chloit35akJAvp2UK5y4+Yr2p6vISWEuwM=; b=KmdpoaMA3qrMTYgJb8OA+o3caxIKNDOXL0hY3rAy7v1CiaRC100RgNI6EO6nZjlmATGi3Z 5yc89pZHScjAKW/d70AAuruEPyHCwhS1RhWKrnBcNAJT9ZHZ0Kb3LEXgkH1ndFRDQrB6Uv 3mgtUUC4ZIZqq+zDd6MdHZlBakKYJDw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-lHIAsAQuP6SwvBh1mk0sRA-1; Mon, 02 Nov 2020 06:05:18 -0500 X-MC-Unique: lHIAsAQuP6SwvBh1mk0sRA-1 Received: by mail-wm1-f69.google.com with SMTP id o81so686585wma.0 for ; Mon, 02 Nov 2020 03:05:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r+Q0QGef/Chloit35akJAvp2UK5y4+Yr2p6vISWEuwM=; b=cxYQW3SYXDLEeWiW1fTnwsX1tDBWEvER269+kxOE31bP4MwoABefbHoLvwFbcJOIH8 99dpjzXd0S0qJ1//kz+FBgmP+GIOUnahDhZU62NB3+H49CDe0RVL8rCs8vUM9sNdkmt0 iVG+bwVUoIxb1Sk21aA26yWJfUv6xBWHIok54d4be1AXQUzGQPvaVW5o+5l1aKfReKeI Es/EL+D3tsPfS+AGsEXfJ6nMIZOyXfYG6GcojtJJeviW/XVE1x9sIbNQSShrVxD4JohX GvMPfSaLRG+52mlNN28X6CexQiWnDO0VzRbnnnyMLhvCRog0jiyjRS8+4FpRfrAlB0d6 h/qg== X-Gm-Message-State: AOAM533xkFKjAzKH9kLvvbuyxxpnv5gEAuTGr1neHzxLfC/DLT01HtG7 6s0gawERCnXuSrEBmdvqvjh0WXf4eNZAeFy/KCmtkDL3w0dpFF+6sa5O5nAhNluaSKs7zFS8Awu 9mCaJMJFZgfe2CevdEQKe4YOLYRC1 X-Received: by 2002:a1c:4054:: with SMTP id n81mr12021238wma.48.1604315117026; Mon, 02 Nov 2020 03:05:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmEIqLJMyDiiIjNpv7lb80eabtXHYd5HB0MoVHivQmdUJd1PBVcw8MORSBRsifC7fHtfm/vg== X-Received: by 2002:a1c:4054:: with SMTP id n81mr12021212wma.48.1604315116864; Mon, 02 Nov 2020 03:05:16 -0800 (PST) Received: from redhat.com (bzq-79-181-134-187.red.bezeqint.net. [79.181.134.187]) by smtp.gmail.com with ESMTPSA id y4sm21531180wrp.74.2020.11.02.03.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:05:16 -0800 (PST) Date: Mon, 2 Nov 2020 06:05:12 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Subject: Re: linux-next: build failure after merge of the drm-misc tree Message-ID: <20201102060422-mutt-send-email-mst@kernel.org> References: <20201102124327.2f82b2a7@canb.auug.org.au> <20201102102711.GA28511@infradead.org> MIME-Version: 1.0 In-Reply-To: <20201102102711.GA28511@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Joerg Roedel , Daniel Vetter , Intel Graphics , Linux Kernel Mailing List , DRI , Linux Next Mailing List , Christian K??nig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 02, 2020 at 10:27:11AM +0000, Christoph Hellwig wrote: > On Mon, Nov 02, 2020 at 10:28:34AM +0100, Daniel Vetter wrote: > > > --- a/include/linux/swiotlb.h > > > +++ b/include/linux/swiotlb.h > > > @@ -5,6 +5,9 @@ > > > #include > > > #include > > > #include > > > +#ifndef CONFIG_SWIOTLB > > > +#include > > > +#endif > > No conditional includes please. And the proper fix for the reported > issue is to stop poking into swiotlb internals in random drivers.. Meaning? _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52281C2D0A3 for ; Mon, 2 Nov 2020 11:05:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0DA2223BD for ; Mon, 2 Nov 2020 11:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K3mlqsA/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0DA2223BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18ABF6E4AE; Mon, 2 Nov 2020 11:05:22 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2AC96E4AE for ; Mon, 2 Nov 2020 11:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604315119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r+Q0QGef/Chloit35akJAvp2UK5y4+Yr2p6vISWEuwM=; b=K3mlqsA/dkP5D4qaZi6cjFjeil2ud2jZUJhbaka55N8L2QdIg/vDMuebea1xzE/5iJ3kHn GTJjxrU/uuFh7UT4H+xIalfgFoPptvzzgznfwZJ7ZDNIq8391qbNxKP8fPa9kTWxY0nLRV z51Lwgsz+zW0Jaefhrw3budLwDqAiMQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-GdRH_hlRPRqG54s5KfOFfg-1; Mon, 02 Nov 2020 06:05:18 -0500 X-MC-Unique: GdRH_hlRPRqG54s5KfOFfg-1 Received: by mail-wm1-f69.google.com with SMTP id l16so1757687wmh.1 for ; Mon, 02 Nov 2020 03:05:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r+Q0QGef/Chloit35akJAvp2UK5y4+Yr2p6vISWEuwM=; b=Hh/52KaKLjGWz+P4zCgoQBJgvglArS0UzvcCqWGBjM3LdLjCQ2Fu9bhohY8dldwmoI nFy0VApSpbTjNF8k6jOZrv9hQWuruCvzag+L9BcSEQc43eTp2RXte7Vji+IXssg7lRgA uA9kdRmsvAM9ynbRutaIOdggjMRmItMm+Nxk9hqEFlr13JEoPbOOC0xA2cdEhfVuBggu e3wEyzyN7a+Eg3iQDfa7cEKxm8/olnwhnZFiSc+o3TyNnmdqnJqyc7FevoKDzVWLNFw9 HbQR8t+87N8I86c5M8VOE4dqvX2+ljOwabgRFzrssbLRZdAvsrCW/CbSQ0HqAMu+/8dR lkbQ== X-Gm-Message-State: AOAM532tM/nsyTbYegg+dxJK1AttbrGXwjhrFp0U35FVfUCz78BstMuE NIX19YaHPe1TCupGnXyicPHRtMYvmrS09VVYiWFL86TMHyYFayhb1+Tpwee42SC3OeEJs45Pjy3 Kae4n/ILKNOYJCzUyrj1BR5dljgs5 X-Received: by 2002:a1c:4054:: with SMTP id n81mr12021231wma.48.1604315117006; Mon, 02 Nov 2020 03:05:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmEIqLJMyDiiIjNpv7lb80eabtXHYd5HB0MoVHivQmdUJd1PBVcw8MORSBRsifC7fHtfm/vg== X-Received: by 2002:a1c:4054:: with SMTP id n81mr12021212wma.48.1604315116864; Mon, 02 Nov 2020 03:05:16 -0800 (PST) Received: from redhat.com (bzq-79-181-134-187.red.bezeqint.net. [79.181.134.187]) by smtp.gmail.com with ESMTPSA id y4sm21531180wrp.74.2020.11.02.03.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:05:16 -0800 (PST) Date: Mon, 2 Nov 2020 06:05:12 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Message-ID: <20201102060422-mutt-send-email-mst@kernel.org> References: <20201102124327.2f82b2a7@canb.auug.org.au> <20201102102711.GA28511@infradead.org> MIME-Version: 1.0 In-Reply-To: <20201102102711.GA28511@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Subject: Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Joerg Roedel , Daniel Vetter , Intel Graphics , Linux Kernel Mailing List , DRI , Linux Next Mailing List , Christian K??nig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Nov 02, 2020 at 10:27:11AM +0000, Christoph Hellwig wrote: > On Mon, Nov 02, 2020 at 10:28:34AM +0100, Daniel Vetter wrote: > > > --- a/include/linux/swiotlb.h > > > +++ b/include/linux/swiotlb.h > > > @@ -5,6 +5,9 @@ > > > #include > > > #include > > > #include > > > +#ifndef CONFIG_SWIOTLB > > > +#include > > > +#endif > > No conditional includes please. And the proper fix for the reported > issue is to stop poking into swiotlb internals in random drivers.. Meaning? _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx