All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: davem@davemloft.net
Cc: Lee Jones <lee.jones@linaro.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Hayes Wang <hayeswang@realtek.com>,
	nic maintainers <nic_swsd@realtek.com>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members
Date: Mon,  2 Nov 2020 11:45:04 +0000	[thread overview]
Message-ID: <20201102114512.1062724-23-lee.jones@linaro.org> (raw)
In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/net/usb/r8152.c:934: warning: Function parameter or member 'blk_hdr' not described in 'fw_mac'
 drivers/net/usb/r8152.c:934: warning: Function parameter or member 'reserved' not described in 'fw_mac'
 drivers/net/usb/r8152.c:947: warning: Function parameter or member 'blk_hdr' not described in 'fw_phy_patch_key'
 drivers/net/usb/r8152.c:947: warning: Function parameter or member 'reserved' not described in 'fw_phy_patch_key'
 drivers/net/usb/r8152.c:986: warning: Function parameter or member 'blk_hdr' not described in 'fw_phy_nc'
 drivers/net/usb/r8152.c:986: warning: Function parameter or member 'mode_pre' not described in 'fw_phy_nc'
 drivers/net/usb/r8152.c:986: warning: Function parameter or member 'mode_post' not described in 'fw_phy_nc'
 drivers/net/usb/r8152.c:986: warning: Function parameter or member 'reserved' not described in 'fw_phy_nc'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Hayes Wang <hayeswang@realtek.com>
Cc: nic maintainers <nic_swsd@realtek.com>
Cc: linux-usb@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/net/usb/r8152.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index b1770489aca51..cebe2dc15c3f0 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -898,6 +898,7 @@ struct fw_header {
  * struct fw_mac - a firmware block used by RTL_FW_PLA and RTL_FW_USB.
  *	The layout of the firmware block is:
  *	<struct fw_mac> + <info> + <firmware data>.
+ * @blk_hdr: firmware descriptor (type, length)
  * @fw_offset: offset of the firmware binary data. The start address of
  *	the data would be the address of struct fw_mac + @fw_offset.
  * @fw_reg: the register to load the firmware. Depends on chip.
@@ -911,6 +912,7 @@ struct fw_header {
  * @bp_num: the break point number which needs to be set for this firmware.
  *	Depends on the firmware.
  * @bp: break points. Depends on firmware.
+ * @reserved: reserved space (unused)
  * @fw_ver_reg: the register to store the fw version.
  * @fw_ver_data: the firmware version of the current type.
  * @info: additional information for debugging, and is followed by the
@@ -936,8 +938,10 @@ struct fw_mac {
 /**
  * struct fw_phy_patch_key - a firmware block used by RTL_FW_PHY_START.
  *	This is used to set patch key when loading the firmware of PHY.
+ * @blk_hdr: firmware descriptor (type, length)
  * @key_reg: the register to write the patch key.
  * @key_data: patch key.
+ * @reserved: reserved space (unused)
  */
 struct fw_phy_patch_key {
 	struct fw_block blk_hdr;
@@ -950,6 +954,7 @@ struct fw_phy_patch_key {
  * struct fw_phy_nc - a firmware block used by RTL_FW_PHY_NC.
  *	The layout of the firmware block is:
  *	<struct fw_phy_nc> + <info> + <firmware data>.
+ * @blk_hdr: firmware descriptor (type, length)
  * @fw_offset: offset of the firmware binary data. The start address of
  *	the data would be the address of struct fw_phy_nc + @fw_offset.
  * @fw_reg: the register to load the firmware. Depends on chip.
@@ -960,6 +965,7 @@ struct fw_phy_patch_key {
  * @mode_reg: the regitster of switching the mode.
  * @mod_pre: the mode needing to be set before loading the firmware.
  * @mod_post: the mode to be set when finishing to load the firmware.
+ * @reserved: reserved space (unused)
  * @bp_start: the start register of break points. Depends on chip.
  * @bp_num: the break point number which needs to be set for this firmware.
  *	Depends on the firmware.
-- 
2.25.1


  parent reply	other threads:[~2020-11-02 11:48 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
2020-11-04  0:46   ` Jakub Kicinski
2020-11-04  7:28     ` Lee Jones
2020-11-04  7:30       ` Lee Jones
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 10:04   ` Lee Jones
2020-11-12 10:50     ` Greg KH
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
2020-11-02 11:44 ` [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
2020-11-03 16:18   ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
2020-11-02 11:45 ` Lee Jones [this message]
2020-11-02 12:06   ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Hayes Wang
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
2020-11-03 16:19   ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
2020-11-02 12:06   ` Hayes Wang
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
2020-11-12 10:06   ` Lee Jones
2020-11-12 16:18     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102114512.1062724-23-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.