From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DABC4742C for ; Mon, 2 Nov 2020 13:51:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8551223AB for ; Mon, 2 Nov 2020 13:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604325090; bh=9qIUbE3lwH4ZvgtTC9bbV3+9hXUEaYm6WiiqQ4WE/Co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TJO2IJwwKGK+8kqpqprcV7+44c+M8A1y9C3K9XvKHvd9txk8My9kJduR9L0CAhLFA wGlZ+snatWUdyf6eyNC+MdKdFZ68qI1cWFZeihtq3mlGfGRVfPLdh1eq9GTJ+MSzka VbfCZ/8K3QaKXV0dy6ElLTqLLtkb8kkB/yTN/XRo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725848AbgKBNvM (ORCPT ); Mon, 2 Nov 2020 08:51:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:47994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbgKBNvK (ORCPT ); Mon, 2 Nov 2020 08:51:10 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C0442231B; Mon, 2 Nov 2020 13:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604325067; bh=9qIUbE3lwH4ZvgtTC9bbV3+9hXUEaYm6WiiqQ4WE/Co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rpbg/1lEiVgNn9Ysvs/9LknHZYACC7zXQOCGCw264IRu8ax1gLK6WH9zSjr+uRe43 j5PkmmIzKYvzuR6uPdj0UxdnGNyDn2tiAsnr4m+Rc6wtDwZreVMVedmDOCqs8DpK24 uLH4O6s20Bi63bMTeguJmmwdpc+o+rm+otUlIokQ= Date: Mon, 2 Nov 2020 14:52:02 +0100 From: 'Greg KH' To: David Laight Cc: 'David Hildenbrand' , Al Viro , Nick Desaulniers , Christoph Hellwig , "kernel-team@android.com" , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-aio@kvack.org" , "io-uring@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "keyrings@vger.kernel.org" , "linux-security-module@vger.kernel.org" Subject: Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c" Message-ID: <20201102135202.GA1016272@kroah.com> References: <20201022121849.GA1664412@kroah.com> <98d9df88-b7ef-fdfb-7d90-2fa7a9d7bab5@redhat.com> <20201022125759.GA1685526@kroah.com> <20201022135036.GA1787470@kroah.com> <134f162d711d466ebbd88906fae35b33@AcuMS.aculab.com> <935f7168-c2f5-dd14-7124-412b284693a2@redhat.com> <999e2926-9a75-72fd-007a-1de0af341292@redhat.com> <35d0ec90ef4f4a35a75b9df7d791f719@AcuMS.aculab.com> <20201023144718.GA2525489@kroah.com> <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Nov 02, 2020 at 09:06:38AM +0000, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +0000, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > > > ... > > > > I just checked against upstream code generated by clang 10 and it > > > > properly discards the upper 32bit via a mov w23 w2. > > > > > > > > So at least clang 10 indeed properly assumes we could have garbage and > > > > masks it off. > > > > > > > > Maybe the issue is somewhere else, unrelated to nr_pages ... or clang 11 > > > > behaves differently. > > > > > > We'll need the disassembly from a failing kernel image. > > > It isn't that big to hand annotate. > > > > I've worked around the merge at the moment in the android tree, but it > > is still quite reproducable, and will try to get a .o file to > > disassemble on Monday or so... > > Did this get properly resolved? For some reason, 5.10-rc2 fixed all of this up. I backed out all of the patches I had to revert to get 5.10-rc1 to work properly, and then did the merge and all is well. It must have been something to do with the compat changes in this same area that went in after 5.10-rc1, and something got reorganized in the files somehow. I really do not know, and at the moment, don't have the time to track it down anymore. So for now, I'd say it's all good, sorry for the noise. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:47994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbgKBNvK (ORCPT ); Mon, 2 Nov 2020 08:51:10 -0500 Date: Mon, 2 Nov 2020 14:52:02 +0100 From: 'Greg KH' Subject: Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c" Message-ID: <20201102135202.GA1016272@kroah.com> References: <20201022121849.GA1664412@kroah.com> <98d9df88-b7ef-fdfb-7d90-2fa7a9d7bab5@redhat.com> <20201022125759.GA1685526@kroah.com> <20201022135036.GA1787470@kroah.com> <134f162d711d466ebbd88906fae35b33@AcuMS.aculab.com> <935f7168-c2f5-dd14-7124-412b284693a2@redhat.com> <999e2926-9a75-72fd-007a-1de0af341292@redhat.com> <35d0ec90ef4f4a35a75b9df7d791f719@AcuMS.aculab.com> <20201023144718.GA2525489@kroah.com> <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> List-ID: To: David Laight Cc: 'David Hildenbrand' , Al Viro , Nick Desaulniers , Christoph Hellwig , "kernel-team@android.com" , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-aio@kvack.org" , "io-uring@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "keyrings@vger.kernel.org" , "linux-security-module@vger.kernel.org" On Mon, Nov 02, 2020 at 09:06:38AM +0000, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +0000, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > > > ... > > > > I just checked against upstream code generated by clang 10 and it > > > > properly discards the upper 32bit via a mov w23 w2. > > > > > > > > So at least clang 10 indeed properly assumes we could have garbage and > > > > masks it off. > > > > > > > > Maybe the issue is somewhere else, unrelated to nr_pages ... or clang 11 > > > > behaves differently. > > > > > > We'll need the disassembly from a failing kernel image. > > > It isn't that big to hand annotate. > > > > I've worked around the merge at the moment in the android tree, but it > > is still quite reproducable, and will try to get a .o file to > > disassemble on Monday or so... > > Did this get properly resolved? For some reason, 5.10-rc2 fixed all of this up. I backed out all of the patches I had to revert to get 5.10-rc1 to work properly, and then did the merge and all is well. It must have been something to do with the compat changes in this same area that went in after 5.10-rc1, and something got reorganized in the files somehow. I really do not know, and at the moment, don't have the time to track it down anymore. So for now, I'd say it's all good, sorry for the noise. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: 'Greg KH' Date: Mon, 02 Nov 2020 13:52:02 +0000 Subject: Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_it Message-Id: <20201102135202.GA1016272@kroah.com> List-Id: References: <20201022121849.GA1664412@kroah.com> <98d9df88-b7ef-fdfb-7d90-2fa7a9d7bab5@redhat.com> <20201022125759.GA1685526@kroah.com> <20201022135036.GA1787470@kroah.com> <134f162d711d466ebbd88906fae35b33@AcuMS.aculab.com> <935f7168-c2f5-dd14-7124-412b284693a2@redhat.com> <999e2926-9a75-72fd-007a-1de0af341292@redhat.com> <35d0ec90ef4f4a35a75b9df7d791f719@AcuMS.aculab.com> <20201023144718.GA2525489@kroah.com> <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> In-Reply-To: <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Laight Cc: 'David Hildenbrand' , Al Viro , Nick Desaulniers , Christoph Hellwig , "kernel-team@android.com" , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-aio@kvack.org" , "io-uring@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "keyrings@vger.kernel.org" , "linux-security-module@vger.kernel.org" On Mon, Nov 02, 2020 at 09:06:38AM +0000, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +0000, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > > > ... > > > > I just checked against upstream code generated by clang 10 and it > > > > properly discards the upper 32bit via a mov w23 w2. > > > > > > > > So at least clang 10 indeed properly assumes we could have garbage and > > > > masks it off. > > > > > > > > Maybe the issue is somewhere else, unrelated to nr_pages ... or clang 11 > > > > behaves differently. > > > > > > We'll need the disassembly from a failing kernel image. > > > It isn't that big to hand annotate. > > > > I've worked around the merge at the moment in the android tree, but it > > is still quite reproducable, and will try to get a .o file to > > disassemble on Monday or so... > > Did this get properly resolved? For some reason, 5.10-rc2 fixed all of this up. I backed out all of the patches I had to revert to get 5.10-rc1 to work properly, and then did the merge and all is well. It must have been something to do with the compat changes in this same area that went in after 5.10-rc1, and something got reorganized in the files somehow. I really do not know, and at the moment, don't have the time to track it down anymore. So for now, I'd say it's all good, sorry for the noise. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DBAC00A89 for ; Mon, 2 Nov 2020 13:56:24 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA2722231B for ; Mon, 2 Nov 2020 13:56:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rpbg/1lE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA2722231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CPvb70jRDzDqMM for ; Tue, 3 Nov 2020 00:56:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=rpbg/1lE; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CPvTF114HzDqQq for ; Tue, 3 Nov 2020 00:51:10 +1100 (AEDT) Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C0442231B; Mon, 2 Nov 2020 13:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604325067; bh=9qIUbE3lwH4ZvgtTC9bbV3+9hXUEaYm6WiiqQ4WE/Co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rpbg/1lEiVgNn9Ysvs/9LknHZYACC7zXQOCGCw264IRu8ax1gLK6WH9zSjr+uRe43 j5PkmmIzKYvzuR6uPdj0UxdnGNyDn2tiAsnr4m+Rc6wtDwZreVMVedmDOCqs8DpK24 uLH4O6s20Bi63bMTeguJmmwdpc+o+rm+otUlIokQ= Date: Mon, 2 Nov 2020 14:52:02 +0100 From: 'Greg KH' To: David Laight Subject: Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c" Message-ID: <20201102135202.GA1016272@kroah.com> References: <20201022121849.GA1664412@kroah.com> <98d9df88-b7ef-fdfb-7d90-2fa7a9d7bab5@redhat.com> <20201022125759.GA1685526@kroah.com> <20201022135036.GA1787470@kroah.com> <134f162d711d466ebbd88906fae35b33@AcuMS.aculab.com> <935f7168-c2f5-dd14-7124-412b284693a2@redhat.com> <999e2926-9a75-72fd-007a-1de0af341292@redhat.com> <35d0ec90ef4f4a35a75b9df7d791f719@AcuMS.aculab.com> <20201023144718.GA2525489@kroah.com> <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-aio@kvack.org" , 'David Hildenbrand' , "linux-mips@vger.kernel.org" , David Howells , "linux-mm@kvack.org" , "keyrings@vger.kernel.org" , "sparclinux@vger.kernel.org" , Christoph Hellwig , "linux-arch@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" , Arnd Bergmann , "linux-block@vger.kernel.org" , Al Viro , "io-uring@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jens Axboe , "linux-parisc@vger.kernel.org" , "netdev@vger.kernel.org" , Nick Desaulniers , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Nov 02, 2020 at 09:06:38AM +0000, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +0000, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > > > ... > > > > I just checked against upstream code generated by clang 10 and it > > > > properly discards the upper 32bit via a mov w23 w2. > > > > > > > > So at least clang 10 indeed properly assumes we could have garbage and > > > > masks it off. > > > > > > > > Maybe the issue is somewhere else, unrelated to nr_pages ... or clang 11 > > > > behaves differently. > > > > > > We'll need the disassembly from a failing kernel image. > > > It isn't that big to hand annotate. > > > > I've worked around the merge at the moment in the android tree, but it > > is still quite reproducable, and will try to get a .o file to > > disassemble on Monday or so... > > Did this get properly resolved? For some reason, 5.10-rc2 fixed all of this up. I backed out all of the patches I had to revert to get 5.10-rc1 to work properly, and then did the merge and all is well. It must have been something to do with the compat changes in this same area that went in after 5.10-rc1, and something got reorganized in the files somehow. I really do not know, and at the moment, don't have the time to track it down anymore. So for now, I'd say it's all good, sorry for the noise. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06CEC388F2 for ; Mon, 2 Nov 2020 13:52:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52921208B6 for ; Mon, 2 Nov 2020 13:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="swNyh0UN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rpbg/1lE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52921208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wGMFIwo5VAETu8ay56c9NU0smiwDr9r5APNQQcNrUhk=; b=swNyh0UNKssVNtUE7mYJ82e9+ eeUlbMXutJXaEHWc8QYQF+WGHMxFBrcmT8esng9ikrf2/EO/M6v17WgDKz0wo8t5U6YKExvX6aEhX Tcg54aiTAcEk287jVyyEyqCQSTcwgE/iI9MO3Igy6yGxZ/7UqXV3j7P2ryr2qPUghSRZqgefezI5w 3uNneVGPP6mJQ+18exAqBOQ2jHv0NDIaGoPGI986d8HpaYXN1nGzmkBwI1+2LmjTi50gE22/TWYkG 4gs2kRUYY7cqwlaRJ8CqwiHhZ2paWzVhhhYtS6vv0NgiEGju3s9AbzOGAEdQlZW4GyPFw/CWuK3t2 AisMNSYpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZaEq-000494-1h; Mon, 02 Nov 2020 13:51:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZaEm-00047V-8Y for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 13:51:09 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C0442231B; Mon, 2 Nov 2020 13:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604325067; bh=9qIUbE3lwH4ZvgtTC9bbV3+9hXUEaYm6WiiqQ4WE/Co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rpbg/1lEiVgNn9Ysvs/9LknHZYACC7zXQOCGCw264IRu8ax1gLK6WH9zSjr+uRe43 j5PkmmIzKYvzuR6uPdj0UxdnGNyDn2tiAsnr4m+Rc6wtDwZreVMVedmDOCqs8DpK24 uLH4O6s20Bi63bMTeguJmmwdpc+o+rm+otUlIokQ= Date: Mon, 2 Nov 2020 14:52:02 +0100 From: 'Greg KH' To: David Laight Subject: Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c" Message-ID: <20201102135202.GA1016272@kroah.com> References: <20201022121849.GA1664412@kroah.com> <98d9df88-b7ef-fdfb-7d90-2fa7a9d7bab5@redhat.com> <20201022125759.GA1685526@kroah.com> <20201022135036.GA1787470@kroah.com> <134f162d711d466ebbd88906fae35b33@AcuMS.aculab.com> <935f7168-c2f5-dd14-7124-412b284693a2@redhat.com> <999e2926-9a75-72fd-007a-1de0af341292@redhat.com> <35d0ec90ef4f4a35a75b9df7d791f719@AcuMS.aculab.com> <20201023144718.GA2525489@kroah.com> <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0ab5ac71f28d459db2f350c2e07b88ca@AcuMS.aculab.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_085108_448920_6DE0593B X-CRM114-Status: GOOD ( 24.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-aio@kvack.org" , 'David Hildenbrand' , "linux-mips@vger.kernel.org" , David Howells , "linux-mm@kvack.org" , "keyrings@vger.kernel.org" , "sparclinux@vger.kernel.org" , Christoph Hellwig , "linux-arch@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" , Arnd Bergmann , "linux-block@vger.kernel.org" , Al Viro , "io-uring@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jens Axboe , "linux-parisc@vger.kernel.org" , "netdev@vger.kernel.org" , Nick Desaulniers , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 02, 2020 at 09:06:38AM +0000, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +0000, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > > > ... > > > > I just checked against upstream code generated by clang 10 and it > > > > properly discards the upper 32bit via a mov w23 w2. > > > > > > > > So at least clang 10 indeed properly assumes we could have garbage and > > > > masks it off. > > > > > > > > Maybe the issue is somewhere else, unrelated to nr_pages ... or clang 11 > > > > behaves differently. > > > > > > We'll need the disassembly from a failing kernel image. > > > It isn't that big to hand annotate. > > > > I've worked around the merge at the moment in the android tree, but it > > is still quite reproducable, and will try to get a .o file to > > disassemble on Monday or so... > > Did this get properly resolved? For some reason, 5.10-rc2 fixed all of this up. I backed out all of the patches I had to revert to get 5.10-rc1 to work properly, and then did the merge and all is well. It must have been something to do with the compat changes in this same area that went in after 5.10-rc1, and something got reorganized in the files somehow. I really do not know, and at the moment, don't have the time to track it down anymore. So for now, I'd say it's all good, sorry for the noise. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel