From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FF6C388F2 for ; Mon, 2 Nov 2020 14:26:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99AD0206B7 for ; Mon, 2 Nov 2020 14:26:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="EcVmzz9j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbgKBO0U (ORCPT ); Mon, 2 Nov 2020 09:26:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbgKBOWg (ORCPT ); Mon, 2 Nov 2020 09:22:36 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD26CC061A04 for ; Mon, 2 Nov 2020 06:22:35 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id h62so4852862wme.3 for ; Mon, 02 Nov 2020 06:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=EcVmzz9jth/73LQEedUdNCEyD5xs5p5MrEHBHb5vnk+/Fhd6bkVFftxytaQ98ipoi2 E7o8OHb6Yj9gmE5x5+rfThOvj9oZYoEpsZhKZDXRdJ5C7T4tzde8EdYcpT4DohOb/0OB QBIQIFx+0s4OJ0KSlHkLKm4zQbUyVL3yPrVzN8k9IMQ5pyfaqyyhRV9EROX94IGpZcW7 nKaCjKX5gcLcDQBG9z07e0FrG0CD9kLjyMyiz6vGUnt5h2e6UNSqKH//ptHRGgLbY33z HGY7ZpNcovsFzKYMww8DIz6Q0V/t2wrYTpNpbgocFjaF+44Bjjnlp8fPlq616UdRR6KQ jNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=reyv4CxI4shSyXKWXBicmXf1fWGHskm2+14SbZldLn16JMQpEQ1SmMu9qCLSa+gYcC rFjqf51r4fVjZZjc/vl/rxMjKy5qxbqAodt1t938HjQ4Dsi+PpYXtFNnYVoAzXhVm07b uXraDidLJDu1ey8+ygmWs+pxCH/v0ZvadVRDxTK2hoAly2GVdNiyJmytZzRxSH+wWqdN O+8lR5TE4MnsH4Ivyp+zgcfBEWY8GYbjfGz85rHAaTH00LQ9K9DpAzyf97g8zy0DlsYd R3jGjhjIxB5JYRwV8JYA9JB+bzABR+zDTsx4oXVFtIFIRovPDUo8Mmf8Xs5Vsi4flB3n Vaww== X-Gm-Message-State: AOAM530wBB0pRCum9v2MJOhvlA2ASYZ2FRPK9mR+H2kmTYSRpXhzvJnV sCbUu0v/Buc8aFdxNlY5jH2vog== X-Google-Smtp-Source: ABdhPJy4aiDk0PjW2NDVFwcRQ7QvYaGh//Ek/ANQ8H+KnrDn3+7QwhU39uVvCEUSktsWeSUAcRlx5A== X-Received: by 2002:a1c:6405:: with SMTP id y5mr7346371wmb.150.1604326954564; Mon, 02 Nov 2020 06:22:34 -0800 (PST) Received: from debian-brgl.home (amarseille-656-1-4-167.w90-8.abo.wanadoo.fr. [90.8.158.167]) by smtp.gmail.com with ESMTPSA id 3sm16182987wmd.19.2020.11.02.06.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:22:34 -0800 (PST) From: Bartosz Golaszewski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 2/4] iio: adc: xilinx: use helper variable for &pdev->dev Date: Mon, 2 Nov 2020 15:22:26 +0100 Message-Id: <20201102142228.14949-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201102142228.14949-1-brgl@bgdev.pl> References: <20201102142228.14949-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski It's more elegant to use a helper local variable to store the address of the underlying struct device than to dereference pdev everywhere. Signed-off-by: Bartosz Golaszewski --- drivers/iio/adc/xilinx-xadc-core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index f93c34fe5873..8494eb424b33 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1186,6 +1186,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np, static int xadc_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; const struct of_device_id *id; struct iio_dev *indio_dev; unsigned int bipolar_mask; @@ -1195,10 +1196,10 @@ static int xadc_probe(struct platform_device *pdev) int irq; int i; - if (!pdev->dev.of_node) + if (!dev->of_node) return -ENODEV; - id = of_match_node(xadc_of_match_table, pdev->dev.of_node); + id = of_match_node(xadc_of_match_table, dev->of_node); if (!id) return -EINVAL; @@ -1206,7 +1207,7 @@ static int xadc_probe(struct platform_device *pdev) if (irq <= 0) return -ENXIO; - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*xadc)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*xadc)); if (!indio_dev) return -ENOMEM; @@ -1226,7 +1227,7 @@ static int xadc_probe(struct platform_device *pdev) indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &xadc_info; - ret = xadc_parse_dt(indio_dev, pdev->dev.of_node, &conf0); + ret = xadc_parse_dt(indio_dev, dev->of_node, &conf0); if (ret) return ret; @@ -1250,7 +1251,7 @@ static int xadc_probe(struct platform_device *pdev) } } - xadc->clk = devm_clk_get(&pdev->dev, NULL); + xadc->clk = devm_clk_get(dev, NULL); if (IS_ERR(xadc->clk)) { ret = PTR_ERR(xadc->clk); goto err_free_samplerate_trigger; @@ -1276,7 +1277,7 @@ static int xadc_probe(struct platform_device *pdev) } ret = request_irq(xadc->irq, xadc->ops->interrupt_handler, 0, - dev_name(&pdev->dev), indio_dev); + dev_name(dev), indio_dev); if (ret) goto err_clk_disable_unprepare; -- 2.29.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8B5C00A89 for ; Mon, 2 Nov 2020 14:23:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79928206B7 for ; Mon, 2 Nov 2020 14:23:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0RqBRG1R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="EcVmzz9j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79928206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DeghFafAITrCP4aXhN1tng6N7rUAuLdNFy5oMXK+jyY=; b=0RqBRG1RaOE2JGoFSHshzL2Ps FYEDM0/E6oJ/O9RL1q9TpsANCwpJuJ0eOF+yWyoA9BqnyDBRsFd4aJbr3gQ7Q5tVMKvfx/HRZTzmM HHN2H6a0QNAAcity3lki0apxcgWptd0vs5SPZJKdQWAX++Gx0+k5Y/KBahzy9f/Bt38UB6ajgPlhW QOImXxH6dwX3blBRCxKgqOBdCjfTHR+Xb0fxdHyL2h6yh7NpphhXaJXsPNys9NpBJfLTW8jQ5Imxt 4iKBlDOJ2ZVtQ4HVs2BDAnoh8E7hm40RYvfVQD5yGw4Bc/IIjyEhxQefbggrYz7nm1rSjSjd0raC7 kXyzzvBJA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZajK-0001Bq-Tl; Mon, 02 Nov 2020 14:22:42 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZajD-00018h-L4 for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 14:22:36 +0000 Received: by mail-wm1-x342.google.com with SMTP id h22so9693978wmb.0 for ; Mon, 02 Nov 2020 06:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=EcVmzz9jth/73LQEedUdNCEyD5xs5p5MrEHBHb5vnk+/Fhd6bkVFftxytaQ98ipoi2 E7o8OHb6Yj9gmE5x5+rfThOvj9oZYoEpsZhKZDXRdJ5C7T4tzde8EdYcpT4DohOb/0OB QBIQIFx+0s4OJ0KSlHkLKm4zQbUyVL3yPrVzN8k9IMQ5pyfaqyyhRV9EROX94IGpZcW7 nKaCjKX5gcLcDQBG9z07e0FrG0CD9kLjyMyiz6vGUnt5h2e6UNSqKH//ptHRGgLbY33z HGY7ZpNcovsFzKYMww8DIz6Q0V/t2wrYTpNpbgocFjaF+44Bjjnlp8fPlq616UdRR6KQ jNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=Szh0dpmvhYT4LT7TIdzcuFhjvwpON4bY4lkAlJkpe/7vbRDp0XjgBM3Be5RtJA1mcY ZJHs7o12aiBEZBPCTMj1l3GpRkfyw9zegNHpDMThuezprotlznWbtvbULgHEfOgb8uUx 2yd0d2cn5DpsefTHJXZ1WChxUMr6pupze0IOawCuqkCrwzOAA+Loq2yy/PeNCn46yIZn IKGFtKslWeZpR+NSkiSMIxHHmBPJUjRqxA4K93cA3T5eqwIBB1whiJP6DB24QVbYZp43 rauCm1siFZOumaX/7wbPCMazJ0K5xXtqzPn5Zargwz4agaKb1WdUaK62ALU/TOTQuR31 wh4g== X-Gm-Message-State: AOAM532/ReWJwuOyYoS+MJe0G5Xns+0jPE1LIERRYTZs1y37jLL1cdKb aSinDLT/ATfIuTyL3zxKnlXcow== X-Google-Smtp-Source: ABdhPJy4aiDk0PjW2NDVFwcRQ7QvYaGh//Ek/ANQ8H+KnrDn3+7QwhU39uVvCEUSktsWeSUAcRlx5A== X-Received: by 2002:a1c:6405:: with SMTP id y5mr7346371wmb.150.1604326954564; Mon, 02 Nov 2020 06:22:34 -0800 (PST) Received: from debian-brgl.home (amarseille-656-1-4-167.w90-8.abo.wanadoo.fr. [90.8.158.167]) by smtp.gmail.com with ESMTPSA id 3sm16182987wmd.19.2020.11.02.06.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:22:34 -0800 (PST) From: Bartosz Golaszewski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek Subject: [PATCH v2 2/4] iio: adc: xilinx: use helper variable for &pdev->dev Date: Mon, 2 Nov 2020 15:22:26 +0100 Message-Id: <20201102142228.14949-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201102142228.14949-1-brgl@bgdev.pl> References: <20201102142228.14949-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_092235_724218_E7AF9B87 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski It's more elegant to use a helper local variable to store the address of the underlying struct device than to dereference pdev everywhere. Signed-off-by: Bartosz Golaszewski --- drivers/iio/adc/xilinx-xadc-core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index f93c34fe5873..8494eb424b33 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1186,6 +1186,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np, static int xadc_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; const struct of_device_id *id; struct iio_dev *indio_dev; unsigned int bipolar_mask; @@ -1195,10 +1196,10 @@ static int xadc_probe(struct platform_device *pdev) int irq; int i; - if (!pdev->dev.of_node) + if (!dev->of_node) return -ENODEV; - id = of_match_node(xadc_of_match_table, pdev->dev.of_node); + id = of_match_node(xadc_of_match_table, dev->of_node); if (!id) return -EINVAL; @@ -1206,7 +1207,7 @@ static int xadc_probe(struct platform_device *pdev) if (irq <= 0) return -ENXIO; - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*xadc)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*xadc)); if (!indio_dev) return -ENOMEM; @@ -1226,7 +1227,7 @@ static int xadc_probe(struct platform_device *pdev) indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &xadc_info; - ret = xadc_parse_dt(indio_dev, pdev->dev.of_node, &conf0); + ret = xadc_parse_dt(indio_dev, dev->of_node, &conf0); if (ret) return ret; @@ -1250,7 +1251,7 @@ static int xadc_probe(struct platform_device *pdev) } } - xadc->clk = devm_clk_get(&pdev->dev, NULL); + xadc->clk = devm_clk_get(dev, NULL); if (IS_ERR(xadc->clk)) { ret = PTR_ERR(xadc->clk); goto err_free_samplerate_trigger; @@ -1276,7 +1277,7 @@ static int xadc_probe(struct platform_device *pdev) } ret = request_irq(xadc->irq, xadc->ops->interrupt_handler, 0, - dev_name(&pdev->dev), indio_dev); + dev_name(dev), indio_dev); if (ret) goto err_clk_disable_unprepare; -- 2.29.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel