From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D51C55179 for ; Mon, 2 Nov 2020 15:40:45 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 887A022277 for ; Mon, 2 Nov 2020 15:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="n0o11Hfl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 887A022277 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 33A48163101E5; Mon, 2 Nov 2020 07:40:45 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=rppt@kernel.org; receiver= Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59216162B9E66 for ; Mon, 2 Nov 2020 07:40:42 -0800 (PST) Received: from kernel.org (unknown [87.71.17.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 202C12222B; Mon, 2 Nov 2020 15:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604331641; bh=JULj2YQjQ3lL8L8mphnth/XMQ+6I1NJ7oIH3/fDK0iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0o11Hfll3daQtruT1vsISN+BbHP9yaMYQE4FQMEMibOkJCKqnhjRxA+eho5Laarv OhRwtWZyY8Wy3q5T3/CRffMJ7SInY7t/Bd/Gdm1eHv/y6zMnVypYr0S7YhVNWRGAWn 75tM+sdcYEOnYl8dKrbNCJbF2bUOfaK/T5JUAaOI= Date: Mon, 2 Nov 2020 17:40:28 +0200 From: Mike Rapoport To: Hagen Paul Pfeifer Subject: Re: [PATCH v6 0/6] mm: introduce memfd_secret system call to create "secret" memory areas Message-ID: <20201102154028.GD4879@kernel.org> References: <20200924132904.1391-1-rppt@kernel.org> <20201101110935.GA4105325@laniakea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201101110935.GA4105325@laniakea> Message-ID-Hash: HUIJBBGDQN2LIYB5UL7KDIEACKACVLKG X-Message-ID-Hash: HUIJBBGDQN2LIYB5UL7KDIEACKACVLKG X-MailFrom: rppt@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Idan Yaniv , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Thomas Gleixner , Shuah Khan , Tycho Andersen , Will Deacon , linux-api@vger.kerne l.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Nov 01, 2020 at 12:09:35PM +0100, Hagen Paul Pfeifer wrote: > * Mike Rapoport | 2020-09-24 16:28:58 [+0300]: > > >This is an implementation of "secret" mappings backed by a file descriptor. > >I've dropped the boot time reservation patch for now as it is not strictly > >required for the basic usage and can be easily added later either with or > >without CMA. > > Isn't memfd_secret currently *unnecessarily* designed to be a "one task > feature"? memfd_secret fulfills exactly two (generic) features: > > - address space isolation from kernel (aka SECRET_EXCLUSIVE, not in kernel's > direct map) - hide from kernel, great > - disabling processor's memory caches against speculative-execution vulnerabilities > (spectre and friends, aka SECRET_UNCACHED), also great > > But, what about the following use-case: implementing a hardened IPC mechanism > where even the kernel is not aware of any data and optionally via SECRET_UNCACHED > even the hardware caches are bypassed! With the patches we are so close to > achieving this. > > How? Shared, SECRET_EXCLUSIVE and SECRET_UNCACHED mmaped pages for IPC > involved tasks required to know this mapping (and memfd_secret fd). After IPC > is done, tasks can copy sensitive data from IPC pages into memfd_secret() > pages, un-sensitive data can be used/copied everywhere. As long as the task share the file descriptor, they can share the secretmem pages, pretty much like normal memfd. > One missing piece is still the secure zeroization of the page(s) if the > mapping is closed by last process to guarantee a secure cleanup. This can > probably done as an general mmap feature, not coupled to memfd_secret() and > can be done independently ("reverse" MAP_UNINITIALIZED feature). There are "init_on_alloc" and "init_on_free" kernel parameters that enable zeroing of the pages on alloc and on free globally. Anyway, I'll add zeroing of the freed memory to secretmem. > PS: thank you Mike for your effort! > > See the following pseudo-code as an example: > > > // simple assume file-descriptor and mapping is inherited > // by child for simplicity, ptr is > int fd = memfd_secret(SECRETMEM_UNCACHED); > ftruncate(fd, PAGE_SIZE); > uint32_t *ptr = mmap(NULL, PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); The ptr here will be visible to both parent and child. > pid_t pid_other; > > void signal_handler(int sig) > { > // update IPC data on shared, uncachaed, exclusive mapped page > *ptr += 1; > // inform other > sleep(1); > kill(pid_other, SIGUSR1); > } > > void ipc_loop(void) > { > signal(SIGUSR1, signal_handler); > while (1) { > sleep(1); > } > } > > int main(void) > { > pid_t child_pid; > > switch (child_pid = fork()) { > case 0: > pid_other = getppid(); > break; > default: > pid_other = child_pid > break; > } > > ipc_loop(); > } > > > Hagen > -- Sincerely yours, Mike. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C11D9C4742C for ; Mon, 2 Nov 2020 15:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B28A2225B for ; Mon, 2 Nov 2020 15:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604331643; bh=JULj2YQjQ3lL8L8mphnth/XMQ+6I1NJ7oIH3/fDK0iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yeT74fYLhp/9GnMhGgjuwR2jYlLamj2zWYA35fbPjhs5kDWfE28ghmzRxntu5UXxo XLu1nvGIjqskHGMPf6SpXOMt7DS5rmzNRXRdmssfuxxS/lIjC6AgR2eCEE38LjjZoc /OoOPpQLAIOTQ9x/5HjtEn/hHt3k+65IlwbkCb60= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbgKBPkm (ORCPT ); Mon, 2 Nov 2020 10:40:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:38504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgKBPkm (ORCPT ); Mon, 2 Nov 2020 10:40:42 -0500 Received: from kernel.org (unknown [87.71.17.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 202C12222B; Mon, 2 Nov 2020 15:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604331641; bh=JULj2YQjQ3lL8L8mphnth/XMQ+6I1NJ7oIH3/fDK0iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0o11Hfll3daQtruT1vsISN+BbHP9yaMYQE4FQMEMibOkJCKqnhjRxA+eho5Laarv OhRwtWZyY8Wy3q5T3/CRffMJ7SInY7t/Bd/Gdm1eHv/y6zMnVypYr0S7YhVNWRGAWn 75tM+sdcYEOnYl8dKrbNCJbF2bUOfaK/T5JUAaOI= Date: Mon, 2 Nov 2020 17:40:28 +0200 From: Mike Rapoport To: Hagen Paul Pfeifer Cc: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Idan Yaniv , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Thomas Gleixner , Shuah Khan , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v6 0/6] mm: introduce memfd_secret system call to create "secret" memory areas Message-ID: <20201102154028.GD4879@kernel.org> References: <20200924132904.1391-1-rppt@kernel.org> <20201101110935.GA4105325@laniakea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101110935.GA4105325@laniakea> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2020 at 12:09:35PM +0100, Hagen Paul Pfeifer wrote: > * Mike Rapoport | 2020-09-24 16:28:58 [+0300]: > > >This is an implementation of "secret" mappings backed by a file descriptor. > >I've dropped the boot time reservation patch for now as it is not strictly > >required for the basic usage and can be easily added later either with or > >without CMA. > > Isn't memfd_secret currently *unnecessarily* designed to be a "one task > feature"? memfd_secret fulfills exactly two (generic) features: > > - address space isolation from kernel (aka SECRET_EXCLUSIVE, not in kernel's > direct map) - hide from kernel, great > - disabling processor's memory caches against speculative-execution vulnerabilities > (spectre and friends, aka SECRET_UNCACHED), also great > > But, what about the following use-case: implementing a hardened IPC mechanism > where even the kernel is not aware of any data and optionally via SECRET_UNCACHED > even the hardware caches are bypassed! With the patches we are so close to > achieving this. > > How? Shared, SECRET_EXCLUSIVE and SECRET_UNCACHED mmaped pages for IPC > involved tasks required to know this mapping (and memfd_secret fd). After IPC > is done, tasks can copy sensitive data from IPC pages into memfd_secret() > pages, un-sensitive data can be used/copied everywhere. As long as the task share the file descriptor, they can share the secretmem pages, pretty much like normal memfd. > One missing piece is still the secure zeroization of the page(s) if the > mapping is closed by last process to guarantee a secure cleanup. This can > probably done as an general mmap feature, not coupled to memfd_secret() and > can be done independently ("reverse" MAP_UNINITIALIZED feature). There are "init_on_alloc" and "init_on_free" kernel parameters that enable zeroing of the pages on alloc and on free globally. Anyway, I'll add zeroing of the freed memory to secretmem. > PS: thank you Mike for your effort! > > See the following pseudo-code as an example: > > > // simple assume file-descriptor and mapping is inherited > // by child for simplicity, ptr is > int fd = memfd_secret(SECRETMEM_UNCACHED); > ftruncate(fd, PAGE_SIZE); > uint32_t *ptr = mmap(NULL, PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); The ptr here will be visible to both parent and child. > pid_t pid_other; > > void signal_handler(int sig) > { > // update IPC data on shared, uncachaed, exclusive mapped page > *ptr += 1; > // inform other > sleep(1); > kill(pid_other, SIGUSR1); > } > > void ipc_loop(void) > { > signal(SIGUSR1, signal_handler); > while (1) { > sleep(1); > } > } > > int main(void) > { > pid_t child_pid; > > switch (child_pid = fork()) { > case 0: > pid_other = getppid(); > break; > default: > pid_other = child_pid > break; > } > > ipc_loop(); > } > > > Hagen > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7787EC00A89 for ; Mon, 2 Nov 2020 15:41:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0527322258 for ; Mon, 2 Nov 2020 15:41:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pm8C/Mnt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="n0o11Hfl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0527322258 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CWk0lt0ePxeMdztuLd4cfjQj9cNcYxLTtP9Mco5vsKc=; b=Pm8C/Mnt215CijO5ppVQI3ieA puLk6xzhy8+tiiGMiUkWLxOiZ3g19mXcRraaXcTSqWX9io/F9Uqv+qWZFfGzJsFvocx3+3pKDSveb MsgHUc5/GzmqJO0ut+nD3Qbk74aAWaRJQgVrHWQX8sCKWTWKcYqfgDt63TMei1hSU/4X4tCfqVnhm xahM2NgGp3NbQO/o0SMjkxf7T8WhY3o2fgsivvvq9Y7M4q5H8TsoXY9+NRwcZm/fdtA8zwL+U0pg9 Nt6Th6inbpQlYs0A4fxXG3E//faV6DOmFjDjfOIFtG+h6Jz55wmR65Se0K+7T5Kmg51RMdLT4+g5s 23HvIC0Bw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbwt-00033f-SG; Mon, 02 Nov 2020 15:40:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbwo-00031Z-Qs; Mon, 02 Nov 2020 15:40:44 +0000 Received: from kernel.org (unknown [87.71.17.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 202C12222B; Mon, 2 Nov 2020 15:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604331641; bh=JULj2YQjQ3lL8L8mphnth/XMQ+6I1NJ7oIH3/fDK0iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0o11Hfll3daQtruT1vsISN+BbHP9yaMYQE4FQMEMibOkJCKqnhjRxA+eho5Laarv OhRwtWZyY8Wy3q5T3/CRffMJ7SInY7t/Bd/Gdm1eHv/y6zMnVypYr0S7YhVNWRGAWn 75tM+sdcYEOnYl8dKrbNCJbF2bUOfaK/T5JUAaOI= Date: Mon, 2 Nov 2020 17:40:28 +0200 From: Mike Rapoport To: Hagen Paul Pfeifer Subject: Re: [PATCH v6 0/6] mm: introduce memfd_secret system call to create "secret" memory areas Message-ID: <20201102154028.GD4879@kernel.org> References: <20200924132904.1391-1-rppt@kernel.org> <20201101110935.GA4105325@laniakea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201101110935.GA4105325@laniakea> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_104043_067875_36CC98E8 X-CRM114-Status: GOOD ( 25.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, Will Deacon , linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Idan Yaniv , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Shuah Khan , x86@kernel.org, Matthew Wilcox , Mike Rapoport , Ingo Molnar , Michael Kerrisk , Arnd Bergmann , James Bottomley , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-fsdevel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Nov 01, 2020 at 12:09:35PM +0100, Hagen Paul Pfeifer wrote: > * Mike Rapoport | 2020-09-24 16:28:58 [+0300]: > > >This is an implementation of "secret" mappings backed by a file descriptor. > >I've dropped the boot time reservation patch for now as it is not strictly > >required for the basic usage and can be easily added later either with or > >without CMA. > > Isn't memfd_secret currently *unnecessarily* designed to be a "one task > feature"? memfd_secret fulfills exactly two (generic) features: > > - address space isolation from kernel (aka SECRET_EXCLUSIVE, not in kernel's > direct map) - hide from kernel, great > - disabling processor's memory caches against speculative-execution vulnerabilities > (spectre and friends, aka SECRET_UNCACHED), also great > > But, what about the following use-case: implementing a hardened IPC mechanism > where even the kernel is not aware of any data and optionally via SECRET_UNCACHED > even the hardware caches are bypassed! With the patches we are so close to > achieving this. > > How? Shared, SECRET_EXCLUSIVE and SECRET_UNCACHED mmaped pages for IPC > involved tasks required to know this mapping (and memfd_secret fd). After IPC > is done, tasks can copy sensitive data from IPC pages into memfd_secret() > pages, un-sensitive data can be used/copied everywhere. As long as the task share the file descriptor, they can share the secretmem pages, pretty much like normal memfd. > One missing piece is still the secure zeroization of the page(s) if the > mapping is closed by last process to guarantee a secure cleanup. This can > probably done as an general mmap feature, not coupled to memfd_secret() and > can be done independently ("reverse" MAP_UNINITIALIZED feature). There are "init_on_alloc" and "init_on_free" kernel parameters that enable zeroing of the pages on alloc and on free globally. Anyway, I'll add zeroing of the freed memory to secretmem. > PS: thank you Mike for your effort! > > See the following pseudo-code as an example: > > > // simple assume file-descriptor and mapping is inherited > // by child for simplicity, ptr is > int fd = memfd_secret(SECRETMEM_UNCACHED); > ftruncate(fd, PAGE_SIZE); > uint32_t *ptr = mmap(NULL, PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); The ptr here will be visible to both parent and child. > pid_t pid_other; > > void signal_handler(int sig) > { > // update IPC data on shared, uncachaed, exclusive mapped page > *ptr += 1; > // inform other > sleep(1); > kill(pid_other, SIGUSR1); > } > > void ipc_loop(void) > { > signal(SIGUSR1, signal_handler); > while (1) { > sleep(1); > } > } > > int main(void) > { > pid_t child_pid; > > switch (child_pid = fork()) { > case 0: > pid_other = getppid(); > break; > default: > pid_other = child_pid > break; > } > > ipc_loop(); > } > > > Hagen > -- Sincerely yours, Mike. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C1AC388F2 for ; Mon, 2 Nov 2020 15:41:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B938E222B9 for ; Mon, 2 Nov 2020 15:41:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zAbKVr/G"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="n0o11Hfl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B938E222B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qnqypO7RzughD2p1uDDMlCj+hez9HzoG6VXLPXvlXpU=; b=zAbKVr/GKxEOVZLZVITdeM0Z3 7gm982zBmcnMgfKfiNdXe+SO01GEyugukfJo/DbRiBAiKiwznGyq/QgVDCFhLLWDqdAa4Fo9jgsjk qJTrugYpfZ9VKILUyI95uvpg+7srjZ9vRWNqHpp4Yrxe9meVcHijgAABNYMNKBbvDVSXJDurWUquz f/fxBH7o1b4iWE/ag+VbJN4/D+W1JA90ftSrHMeKeITyFHJsoti8e6Jq4wYFve6zjpHuJ1IRFo4s0 QtbE3kC4gNRnb5NQvpl7DKzeF45hxxyA/weTGHv6CYPdkZ5NcW5z3DCzj5VKQFRaXLhncVJaE0FQv vlMFsfcAQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbwr-000334-Ri; Mon, 02 Nov 2020 15:40:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbwo-00031Z-Qs; Mon, 02 Nov 2020 15:40:44 +0000 Received: from kernel.org (unknown [87.71.17.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 202C12222B; Mon, 2 Nov 2020 15:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604331641; bh=JULj2YQjQ3lL8L8mphnth/XMQ+6I1NJ7oIH3/fDK0iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0o11Hfll3daQtruT1vsISN+BbHP9yaMYQE4FQMEMibOkJCKqnhjRxA+eho5Laarv OhRwtWZyY8Wy3q5T3/CRffMJ7SInY7t/Bd/Gdm1eHv/y6zMnVypYr0S7YhVNWRGAWn 75tM+sdcYEOnYl8dKrbNCJbF2bUOfaK/T5JUAaOI= Date: Mon, 2 Nov 2020 17:40:28 +0200 From: Mike Rapoport To: Hagen Paul Pfeifer Subject: Re: [PATCH v6 0/6] mm: introduce memfd_secret system call to create "secret" memory areas Message-ID: <20201102154028.GD4879@kernel.org> References: <20200924132904.1391-1-rppt@kernel.org> <20201101110935.GA4105325@laniakea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201101110935.GA4105325@laniakea> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_104043_067875_36CC98E8 X-CRM114-Status: GOOD ( 25.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, Will Deacon , linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Idan Yaniv , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Shuah Khan , x86@kernel.org, Matthew Wilcox , Mike Rapoport , Ingo Molnar , Michael Kerrisk , Arnd Bergmann , James Bottomley , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-fsdevel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 01, 2020 at 12:09:35PM +0100, Hagen Paul Pfeifer wrote: > * Mike Rapoport | 2020-09-24 16:28:58 [+0300]: > > >This is an implementation of "secret" mappings backed by a file descriptor. > >I've dropped the boot time reservation patch for now as it is not strictly > >required for the basic usage and can be easily added later either with or > >without CMA. > > Isn't memfd_secret currently *unnecessarily* designed to be a "one task > feature"? memfd_secret fulfills exactly two (generic) features: > > - address space isolation from kernel (aka SECRET_EXCLUSIVE, not in kernel's > direct map) - hide from kernel, great > - disabling processor's memory caches against speculative-execution vulnerabilities > (spectre and friends, aka SECRET_UNCACHED), also great > > But, what about the following use-case: implementing a hardened IPC mechanism > where even the kernel is not aware of any data and optionally via SECRET_UNCACHED > even the hardware caches are bypassed! With the patches we are so close to > achieving this. > > How? Shared, SECRET_EXCLUSIVE and SECRET_UNCACHED mmaped pages for IPC > involved tasks required to know this mapping (and memfd_secret fd). After IPC > is done, tasks can copy sensitive data from IPC pages into memfd_secret() > pages, un-sensitive data can be used/copied everywhere. As long as the task share the file descriptor, they can share the secretmem pages, pretty much like normal memfd. > One missing piece is still the secure zeroization of the page(s) if the > mapping is closed by last process to guarantee a secure cleanup. This can > probably done as an general mmap feature, not coupled to memfd_secret() and > can be done independently ("reverse" MAP_UNINITIALIZED feature). There are "init_on_alloc" and "init_on_free" kernel parameters that enable zeroing of the pages on alloc and on free globally. Anyway, I'll add zeroing of the freed memory to secretmem. > PS: thank you Mike for your effort! > > See the following pseudo-code as an example: > > > // simple assume file-descriptor and mapping is inherited > // by child for simplicity, ptr is > int fd = memfd_secret(SECRETMEM_UNCACHED); > ftruncate(fd, PAGE_SIZE); > uint32_t *ptr = mmap(NULL, PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); The ptr here will be visible to both parent and child. > pid_t pid_other; > > void signal_handler(int sig) > { > // update IPC data on shared, uncachaed, exclusive mapped page > *ptr += 1; > // inform other > sleep(1); > kill(pid_other, SIGUSR1); > } > > void ipc_loop(void) > { > signal(SIGUSR1, signal_handler); > while (1) { > sleep(1); > } > } > > int main(void) > { > pid_t child_pid; > > switch (child_pid = fork()) { > case 0: > pid_other = getppid(); > break; > default: > pid_other = child_pid > break; > } > > ipc_loop(); > } > > > Hagen > -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel