From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2419C55178 for ; Tue, 3 Nov 2020 01:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A0EC2063A for ; Tue, 3 Nov 2020 01:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366704; bh=86wGNSI8JmYe8ggY2XcpLkC6ohVEoexUDpj4tCkLil0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zGoCVP9W56nkBQ3SmqpFDup7KR4l7osfqjmyBJkIOwwsLBoo950HAZf7jrrJD08Qj hTZCKU4p8Gno/HkD3xt/CYpIVSlQ3MmL7+hY+a5PzjTts3HrILCXDYMQMM6C5wx+fF Ecgw0MYn/rrHmXi09d1JUJQJVQ9jOqWyotvsQIhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728406AbgKCBZD (ORCPT ); Mon, 2 Nov 2020 20:25:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:34456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727981AbgKCBUD (ORCPT ); Mon, 2 Nov 2020 20:20:03 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A7252242F; Tue, 3 Nov 2020 01:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366402; bh=86wGNSI8JmYe8ggY2XcpLkC6ohVEoexUDpj4tCkLil0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BSMbjTfGZjOS72STf9BwP8H1/XEpdrK5EovH5gr2i2PkP7Zu4N24lM0cABp7KvN4F OlkDAyPNPeX6tGE2pcIOpWoAjLYAOQ8FdMqtBGFMuqrHZy8Yb1rRJHOpCLFkMVnPUE DyMjsSwzIu2dJzI/+moAJmap1aWn6r4g0LQiWTvE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Chen , Jun Li , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.8 26/29] usb: cdns3: gadget: suspicious implicit sign extension Date: Mon, 2 Nov 2020 20:19:25 -0500 Message-Id: <20201103011928.183145-26-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201103011928.183145-1-sashal@kernel.org> References: <20201103011928.183145-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Chen [ Upstream commit 5fca3f062879f8e5214c56f3e3e2be6727900f5d ] The code: trb->length = cpu_to_le32(TRB_BURST_LEN(priv_ep->trb_burst_size) | TRB_LEN(length)); TRB_BURST_LEN(priv_ep->trb_burst_size) may be overflow for int 32 if priv_ep->trb_burst_size is equal or larger than 0x80; Below is the Coverity warning: sign_extension: Suspicious implicit sign extension: priv_ep->trb_burst_size with type u8 (8 bits, unsigned) is promoted in priv_ep->trb_burst_size << 24 to type int (32 bits, signed), then sign-extended to type unsigned long (64 bits, unsigned). If priv_ep->trb_burst_size << 24 is greater than 0x7FFFFFFF, the upper bits of the result will all be 1. To fix it, it needs to add an explicit cast to unsigned int type for ((p) << 24). Reviewed-by: Jun Li Signed-off-by: Peter Chen Signed-off-by: Sasha Levin --- drivers/usb/cdns3/gadget.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/gadget.h b/drivers/usb/cdns3/gadget.h index 52765b098b9e1..28c4f6aca6891 100644 --- a/drivers/usb/cdns3/gadget.h +++ b/drivers/usb/cdns3/gadget.h @@ -1067,7 +1067,7 @@ struct cdns3_trb { #define TRB_TDL_SS_SIZE_GET(p) (((p) & GENMASK(23, 17)) >> 17) /* transfer_len bitmasks - bits 31:24 */ -#define TRB_BURST_LEN(p) (((p) << 24) & GENMASK(31, 24)) +#define TRB_BURST_LEN(p) ((unsigned int)((p) << 24) & GENMASK(31, 24)) #define TRB_BURST_LEN_GET(p) (((p) & GENMASK(31, 24)) >> 24) /* Data buffer pointer bitmasks*/ -- 2.27.0