Hi "Valdis, Thank you for the patch! Yet something to improve: [auto build test ERROR on shawnguo/for-next] [also build test ERROR on next-20201102] [cannot apply to clk/clk-next v5.10-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Valdis-Kl-tnieks/clk-imx-scu-Fix-compile-error-with-module-build-of-clk-scu-o/20201102-200354 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4fc6783d0d72b5c3c9e0ff96a391150584b85a0e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Valdis-Kl-tnieks/clk-imx-scu-Fix-compile-error-with-module-build-of-clk-scu-o/20201102-200354 git checkout 4fc6783d0d72b5c3c9e0ff96a391150584b85a0e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): arm-linux-gnueabi-ld: drivers/clk/imx/clk-imx8qxp.o: in function `imx8qxp_clk_driver_init': >> clk-imx8qxp.c:(.init.text+0x0): multiple definition of `init_module'; drivers/clk/imx/clk-scu.o:clk-scu.c:(.init.text+0x0): first defined here --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org