From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D417C2D0A3 for ; Tue, 3 Nov 2020 07:27:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D06B92222B for ; Tue, 3 Nov 2020 07:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725997AbgKCH1D (ORCPT ); Tue, 3 Nov 2020 02:27:03 -0500 Received: from verein.lst.de ([213.95.11.211]:35975 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgKCH1D (ORCPT ); Tue, 3 Nov 2020 02:27:03 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id CD71B67373; Tue, 3 Nov 2020 08:27:00 +0100 (CET) Date: Tue, 3 Nov 2020 08:27:00 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH 01/17] mm/filemap: Rename generic_file_buffered_read subfunctions Message-ID: <20201103072700.GA8389@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-2-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Nov 02, 2020 at 06:42:56PM +0000, Matthew Wilcox (Oracle) wrote: > The recent split of generic_file_buffered_read() created some very > long function names which are hard to distinguish from each other. > Rename as follows: > > generic_file_buffered_read_readpage -> filemap_read_page > generic_file_buffered_read_pagenotuptodate -> filemap_update_page > generic_file_buffered_read_no_cached_page -> filemap_create_page > generic_file_buffered_read_get_pages -> filemap_get_pages Find with me, although I think filemap_find_get_pages would be a better name for filemap_get_pages.