All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Shuo A Liu <shuo.a.liu@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	Yu Wang <yu1.wang@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Yin Fengwei <fengwei.yin@intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Zhi Wang <zhi.a.wang@intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v5 03/17] x86/acrn: Introduce an API to check if a VM is privileged
Date: Tue, 3 Nov 2020 11:25:38 +0100	[thread overview]
Message-ID: <20201103102538.GB6310@zn.tnic> (raw)
In-Reply-To: <20201103062718.GD12408@shuo-intel.sh.intel.com>

On Tue, Nov 03, 2020 at 02:27:18PM +0800, Shuo A Liu wrote:
> The code just followed KVM style (see kvm_arch_para_features()).

Do you see Documentation/virt/kvm/cpuid.rst?

Now where is yours explaining what your hypervisor is doing?

> I can change to use
> 	cpuid_eax(acrn_cpuid_base() + 1)...
> If you prefer to.

Yes please.

> hypervisor_cpuid_base() implies the base is variable, no? We use
> this function to detect the base.

Yes, but you need to document all that and make it clear and
understandable. If Linux is supposed to run as an acrn guest, that
interface better be documented just like KVM does.

Also, if there's a bug in the KVM guest/host interface, we might be able
to fix it modulo ABI. Is that possible with acrn?

I'm guessing the answer to that is yes if I'm looking at

https://github.com/projectacrn/acrn-hypervisor

?

> OK. Then i will define acrn_cpuid_base() as a static inline function
> in asm/acrn.h for callers.

Yah, that function is simple enough.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2020-11-03 10:25 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19  6:17 [PATCH v5 00/17] HSM driver for ACRN hypervisor shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 01/17] docs: acrn: Introduce ACRN shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 02/17] x86/acrn: Introduce acrn_{setup, remove}_intr_handler() shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 03/17] x86/acrn: Introduce an API to check if a VM is privileged shuo.a.liu
2020-11-02 14:37   ` Borislav Petkov
2020-11-03  6:27     ` Shuo A Liu
2020-11-03 10:25       ` Borislav Petkov [this message]
2020-11-04  3:50         ` Shuo A Liu
2020-11-04 18:51           ` Borislav Petkov
2020-11-05  3:25             ` Shuo A Liu
2020-10-19  6:17 ` [PATCH v5 04/17] x86/acrn: Introduce hypercall interfaces shuo.a.liu
2020-10-19 21:53   ` Nick Desaulniers
2020-10-19 22:15   ` Arvind Sankar
2020-10-20  1:38     ` Shuo A Liu
2020-10-20  2:08       ` Arvind Sankar
2020-10-20  2:30         ` Shuo A Liu
2020-10-20 14:16           ` Arvind Sankar
2020-10-21  1:16             ` Shuo A Liu
2020-11-02 14:56   ` Borislav Petkov
2020-11-02 16:09     ` Segher Boessenkool
2020-11-02 17:19       ` Borislav Petkov
2020-11-02 18:10         ` Segher Boessenkool
2020-11-02 18:34           ` Borislav Petkov
2020-11-02 20:01             ` Segher Boessenkool
2020-11-02 22:54               ` Borislav Petkov
2020-11-02 23:18                 ` Segher Boessenkool
2020-11-03 16:44                   ` Borislav Petkov
2020-11-03 18:47                     ` Segher Boessenkool
2020-11-03 19:43                       ` Borislav Petkov
2020-10-19  6:17 ` [PATCH v5 05/17] virt: acrn: Introduce ACRN HSM basic driver shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 06/17] virt: acrn: Introduce VM management interfaces shuo.a.liu
2020-11-04 19:02   ` Greg Kroah-Hartman
2020-11-05  3:10     ` Shuo A Liu
2020-11-05  6:29       ` Greg Kroah-Hartman
2020-11-05  7:35         ` Shuo A Liu
2020-11-05  8:26           ` Greg Kroah-Hartman
2020-11-05  9:02             ` Shuo A Liu
2020-11-05  9:16               ` Greg Kroah-Hartman
2020-11-05 12:48                 ` Shuo A Liu
2020-11-05 13:04                   ` Greg Kroah-Hartman
2020-10-19  6:17 ` [PATCH v5 07/17] virt: acrn: Introduce an ioctl to set vCPU registers state shuo.a.liu
2020-11-09 17:09   ` Greg Kroah-Hartman
2020-11-10 13:14     ` Shuo A Liu
2020-11-10 14:54       ` Greg Kroah-Hartman
2020-11-11  9:54         ` Shuo A Liu
2020-11-11 10:28           ` Greg Kroah-Hartman
2020-11-11 12:03             ` Shuo A Liu
2020-11-11 12:29               ` Greg Kroah-Hartman
2020-11-11 16:55                 ` Shuo A Liu
2020-10-19  6:17 ` [PATCH v5 08/17] virt: acrn: Introduce EPT mapping management shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 09/17] virt: acrn: Introduce I/O request management shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 10/17] virt: acrn: Introduce PCI configuration space PIO accesses combiner shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 11/17] virt: acrn: Introduce interfaces for PCI device passthrough shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 12/17] virt: acrn: Introduce interrupt injection interfaces shuo.a.liu
2020-10-19  6:17 ` [PATCH v5 13/17] virt: acrn: Introduce interfaces to query C-states and P-states allowed by hypervisor shuo.a.liu
2020-10-19  6:18 ` [PATCH v5 14/17] virt: acrn: Introduce I/O ranges operation interfaces shuo.a.liu
2020-10-19  6:18 ` [PATCH v5 15/17] virt: acrn: Introduce ioeventfd shuo.a.liu
2020-10-19  6:18 ` [PATCH v5 16/17] virt: acrn: Introduce irqfd shuo.a.liu
2020-10-19  6:18 ` [PATCH v5 17/17] virt: acrn: Introduce an interface for Service VM to control vCPU shuo.a.liu
2020-10-21 15:19 ` [PATCH v5 00/17] HSM driver for ACRN hypervisor Dave Hansen
2020-10-26  0:39   ` Shuo A Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103102538.GB6310@zn.tnic \
    --to=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=fengwei.yin@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=shuo.a.liu@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yu1.wang@intel.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.a.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.