All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Marco Elver <elver@google.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
	"Uladzislau Rezki (Sony)" <urezki@gmail.com>,
	fweisbec@gmail.com, neeraj.iitr10@gmail.com
Subject: Re: [PATCH v9 3/7] srcu: Fix invoke_rcu_callbacks() segcb length adjustment
Date: Tue, 3 Nov 2020 09:56:51 -0500	[thread overview]
Message-ID: <20201103145651.GA1304393@google.com> (raw)
In-Reply-To: <20201103144714.GA432431@lothringen>

On Tue, Nov 03, 2020 at 03:47:14PM +0100, Frederic Weisbecker wrote:
> On Tue, Nov 03, 2020 at 09:25:59AM -0500, Joel Fernandes (Google) wrote:
> > With earlier patches, the negative counting of the unsegmented list
> > cannot be used to adjust the segmented one. To fix this, sample the
> > unsegmented length in advance, and use it after CB execution to adjust
> > the segmented list's length.
> > 
> > Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
> > Suggested-by: Frederic Weisbecker <frederic@kernel.org>
> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> 
> This breaks bisection, you need to either fix up the previous patch
> by adding this diff inside or better yet: expand what you did
> in "rcu/tree: Make rcu_do_batch count how many callbacks were executed"
> to also handle srcu before introducing the segcb count.

Right, the latter is better. Let us do that.

thanks,

 - Joel


  reply	other threads:[~2020-11-03 14:58 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 14:25 [PATCH v9 0/7] Add support for length of each segment in the segcblist Joel Fernandes (Google)
2020-11-03 14:25 ` [PATCH v9 1/7] rcu/tree: Make rcu_do_batch count how many callbacks were executed Joel Fernandes (Google)
2020-11-04  0:05   ` Paul E. McKenney
2020-11-04 15:09     ` Joel Fernandes
2020-11-03 14:25 ` [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure Joel Fernandes (Google)
2020-11-04 13:37   ` Neeraj Upadhyay
2020-11-04 17:01   ` Paul E. McKenney
2020-11-07  0:01     ` Joel Fernandes
2020-11-07  0:18       ` Joel Fernandes
2020-11-07  0:48         ` Paul E. McKenney
2020-11-10  1:39           ` Paul E. McKenney
2020-11-03 14:25 ` [PATCH v9 3/7] srcu: Fix invoke_rcu_callbacks() segcb length adjustment Joel Fernandes (Google)
2020-11-03 14:47   ` Frederic Weisbecker
2020-11-03 14:56     ` Joel Fernandes [this message]
2020-11-03 15:07     ` Joel Fernandes
2020-11-03 15:18       ` Paul E. McKenney
2020-11-03 15:19       ` Frederic Weisbecker
2020-11-04 13:37   ` Neeraj Upadhyay
2020-11-03 14:26 ` [PATCH v9 4/7] rcu/trace: Add tracing for how segcb list changes Joel Fernandes (Google)
2020-11-03 15:17   ` Frederic Weisbecker
2020-11-04 14:08     ` Paul E. McKenney
2020-11-04 14:33       ` Frederic Weisbecker
2020-11-07  0:05         ` Joel Fernandes
2020-11-04 13:40   ` Neeraj Upadhyay
2020-11-04 15:05     ` Joel Fernandes
2020-11-11  0:35   ` Paul E. McKenney
2020-11-11 13:49     ` Steven Rostedt
2020-11-11 14:08       ` Joel Fernandes
2020-11-03 14:26 ` [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include Joel Fernandes (Google)
2020-11-05  3:48   ` Paul E. McKenney
2020-11-05 14:28     ` Paul E. McKenney
2020-11-07  0:27       ` Joel Fernandes
2020-11-03 14:26 ` [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s Joel Fernandes (Google)
2020-11-05  3:57   ` Paul E. McKenney
2020-11-07  0:26     ` Joel Fernandes
2020-11-10  1:41       ` Paul E. McKenney
2020-11-03 14:26 ` [PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb() Joel Fernandes (Google)
2020-11-05 18:55   ` Paul E. McKenney
2020-11-06 22:41     ` Joel Fernandes
2020-11-10  1:28       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103145651.GA1304393@google.com \
    --to=joel@joelfernandes.org \
    --cc=elver@google.com \
    --cc=frederic@kernel.org \
    --cc=fweisbec@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=neeraj.iitr10@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.