From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D5BC2D0A3 for ; Tue, 3 Nov 2020 21:25:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE988206E3 for ; Tue, 3 Nov 2020 21:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604438703; bh=qt7/7bBSX48tGDsgKpI9EWQ5t4hychA88ZkggZHgBtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tAd/MTZ/E+JNfr8qh9xi2kORSNFZ3wMzc8rENColTyZCjHIQEZ8PV8cnsw/j4+341 T+rye8Waupy3qKIxFkCauYcnhzAWM4xDjQ7i2fia0MOFcJlTlJlVOm1sDGDkz75nvx D12eyp0wNhoctpwuFy1IWqYMSPCA+hlaKIhOgKM8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732315AbgKCVDL (ORCPT ); Tue, 3 Nov 2020 16:03:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:40424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387757AbgKCVDE (ORCPT ); Tue, 3 Nov 2020 16:03:04 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9836420658; Tue, 3 Nov 2020 21:03:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437384; bh=qt7/7bBSX48tGDsgKpI9EWQ5t4hychA88ZkggZHgBtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HXvk3g6SgtxXFqj/dznb3E8jaO+1R4l4a7up7gWOn2bcmWeDkHArIeSelWMeXxBKz eu4Iz4dI0WNh2bnXZymT5mUUCCmBsvnbTJgSgbnaDYQc6Jgl0/HxV/DOKeYWEZJDFy of1k3WTJz4qYGKjH2QzVo4yZxNQMAUt7yGgd+52Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mateusz Nosek , Thomas Gleixner , Sasha Levin Subject: [PATCH 4.19 054/191] futex: Fix incorrect should_fail_futex() handling Date: Tue, 3 Nov 2020 21:35:46 +0100 Message-Id: <20201103203239.645542204@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mateusz Nosek [ Upstream commit 921c7ebd1337d1a46783d7e15a850e12aed2eaa0 ] If should_futex_fail() returns true in futex_wake_pi(), then the 'ret' variable is set to -EFAULT and then immediately overwritten. So the failure injection is non-functional. Fix it by actually leaving the function and returning -EFAULT. The Fixes tag is kinda blury because the initial commit which introduced failure injection was already sloppy, but the below mentioned commit broke it completely. [ tglx: Massaged changelog ] Fixes: 6b4f4bc9cb22 ("locking/futex: Allow low-level atomic operations to return -EAGAIN") Signed-off-by: Mateusz Nosek Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20200927000858.24219-1-mateusznosek0@gmail.com Signed-off-by: Sasha Levin --- kernel/futex.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/futex.c b/kernel/futex.c index 920d853a8e9e2..eabb9180ffa89 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1517,8 +1517,10 @@ static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_pi_state *pi_ */ newval = FUTEX_WAITERS | task_pid_vnr(new_owner); - if (unlikely(should_fail_futex(true))) + if (unlikely(should_fail_futex(true))) { ret = -EFAULT; + goto out_unlock; + } ret = cmpxchg_futex_value_locked(&curval, uaddr, uval, newval); if (!ret && (curval != uval)) { -- 2.27.0