From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2908C388F9 for ; Tue, 3 Nov 2020 20:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A298C223C7 for ; Tue, 3 Nov 2020 20:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436212; bh=GWBZ3BQU8bcnU0lZCleC02h0tx0fhq8h+mqO1SuTPxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TLsnTBKSrotk4TXNFzB42p8p+8IweO4eKn6BWtEh9FyckVMWengwbT2VjfSaUxK2M JEIj3+gO4UlQd0dg1HA9/e2blt7dr3VnZ814ip5r2cp6FF4JGS74kouxz1V0AiwFuN kna+HIsL8gREsEJiPgDsNaTmkx1TGOtLgbccESNM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730728AbgKCUnb (ORCPT ); Tue, 3 Nov 2020 15:43:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:57156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730712AbgKCUn2 (ORCPT ); Tue, 3 Nov 2020 15:43:28 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B860223AC; Tue, 3 Nov 2020 20:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436207; bh=GWBZ3BQU8bcnU0lZCleC02h0tx0fhq8h+mqO1SuTPxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zpga0HB/5I14A5u9Gw6RmLtvHuQ0wy1HSVDgOp/xhpbo8wmxd6RjzwQWU6UPWl5su 2l06KxcQ8SGyRUvUmZEznfrqUGoPQI8LMLF+Tt2RzRX2K6Qefj1Sa2lANsPmzOEWiH Wd4ojOPvbqd88NNo3RnjmlO7IUWfwcys22bWHacc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "J. Bruce Fields" , Sasha Levin Subject: [PATCH 5.9 150/391] nfsd4: remove check_conflicting_opens warning Date: Tue, 3 Nov 2020 21:33:21 +0100 Message-Id: <20201103203356.953466047@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: J. Bruce Fields [ Upstream commit 50747dd5e47bde3b7d7f839c84d0d3b554090497 ] There are actually rare races where this is possible (e.g. if a new open intervenes between the read of i_writecount and the fi_fds). Signed-off-by: J. Bruce Fields Signed-off-by: Sasha Levin --- fs/nfsd/nfs4state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 0525acfe31314..1f646a27481fb 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -4954,7 +4954,6 @@ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp, writes--; if (fp->fi_fds[O_RDWR]) writes--; - WARN_ON_ONCE(writes < 0); if (writes > 0) return -EAGAIN; spin_lock(&fp->fi_lock); -- 2.27.0